Revert "Bug 42377: Hidden fonts should obey the allow list."

This reverts commit 3488619aedbc183d54c794ac9e9a9c2f642df4e0.

Hidden font families were automatically added to the font.system.whitelist, which is a behavior that conflicts with our font picking.

This hides it from both the toolbar and the unified extensions panel.

We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it).

This commit implmenents the the Base Browser's version of _migrateUI.

This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.

Geckoview: Expose security level interfaceBug 40125: Expose Security Level pref in GeckoView

Backlog
extensions.allowPrivateBrowsingByDefault will be removedBug 40253: Explicitly allow NoScript in Private Browsing mode.

Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.

Also fix Bug
Tor Browser 8.0a10 wants to update to 8.0a10bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug
potentially confusing "restart to update" message in ESR60Bug 26048: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.

BugBugSmashFundUXUpdater
notify users that update is downloadingBug 28885: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress.

As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

Treat about:blank as the default home page and new tab page.

Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need.

Disable unused about: pagesBug 41624: Disable about:pocket-* pages.

BugDesktopFirst ContributionProject 131UX
about:privatebrowsing Firefox brandingBug 40144: Redirect about:privatebrowsing to the user's home

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as $MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/.

It is ignored because of RFP and it is confusing for users.

BugDesktopFirst ContributionRoadmap::FutureUXUpliftUpstream
Remove "New Private Window" option from Tor Browser or make it a separate sessionBug 25660: Remove the "New Private Window" option

Change the language selector to be sorted by language code, rather than name, and to display the language code to the user.

LocalizationMacOSProject 131Q4UX
"Japanese" language menu item is localised in multi-locale testbuild (on mac OS)Bug 41372: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs.

LocalizationNeeds DesignProject 131Q4UX
Inform users when Tor Browser sets their language automaticallyBug 41378: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once.

This commit adds all the strings needed by following Base Browser patches.

Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS.

The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height.

It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows.

On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle.

This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS).

This checks privacy.spoof_english whenever setLocales is called from Fenix side and sets intl.accept_languages accordingly.

Needs Review
Expose privacy.spoof_english pref in GeckoViewBug 40198: Expose privacy.spoof_english pref in GeckoView

The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese).

Bug 42377: Hidden fonts should obey the allow list.

Remove .Helvetica Neue DeskInterface from the allow list. This font might not be actually available, and in any case fonts starting with period will not be displayed by the browser.

This hack directly includes our preference changes in omni.ja.

Apps::Impact::NoneApps::Type::BugBugDesktopRoadmap::FutureUpdaterWindows
staged updates fail on WindowsBug 18292: Staged updates fail on Windows

Temporarily disable staged updates on Windows.

BugFingerprinting
Tor browser uses Chinese-style glyphs to display JapaneseBug 18297: Use separate Noto JP,KR,SC,TC fonts

BugFingerprinting
Noto Sans Buginese missing from macOS font whitelistBug 23404: Add Noto Sans Buginese to the macOS whitelist

Bug
Tab crashes when using Tor Browser to access Google DriveBug 23745: Set dom.indexedDB.enabled = true

BugFingerprintingFirst Contribution
Disable randomised Firefox HTTP cache decay user test groupsBug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)

FeatureLinkabilityPerformance
Confirm TLS session resumption/ID are isolated to the URL bar domain, and re-enable themBug 17252: Enable session identifiers with FPI

Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".

The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)

LinkabilityPerformanceTaskUX
Audit HTTP/2 and SPDY if neededBug 14952: Enable http/2 and AltSvc

In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".

Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.

(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)

However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.

"network.http.spdy.enabled.http2draft" was removed in RESOLVED FIXED(Fx41), [spdy]
remove h2-draft support starting in gecko-40Bug 1132357. "network.http.sped.enabled.v2" was removed in VERIFIED FIXED(Fx27)
remove spdy/2 supportBug 912550. "network.http.sped.enabled.v3" was removed in RESOLVED FIXED(Fx36), spdy
kill spdy/3Bug 1097944. "network.http.sped.enabled.v3-1" was removed in RESOLVED FIXED(Fx51), Blocks: 912549, [necko-active]
remove spdy/3.1 supportBug 1248197.

FingerprintingTask
Adapt to upstreamed AddonManager changesBug 26114: addons.mozilla.org is not special

• Don't expose navigator.mozAddonManager on any site
• Don't block NoScript from modifying addons.mozilla.org or other sites

Enable ReaderView mode again (#27281).

BugProxy Bypass
Group Policies for Firefox can bypass Tor Browser's proxy settingsBug 29916: Make sure enterprise policies are disabled

MikePerry201408RMikePerryIterationFires20110529actualpoints::1backport-to-mozillacomponent::firefox patch issuesowner::mikeperrypoints::4priority::mediumresolution::fixedseverity::blockerstatus::closedtbb-no-uplift-60type::enhancement
Block access to Components.interfaces from content scriptBug 2874: Block Components.interfaces from content

BugBugSmashFundFingerprinting
Setting general.useragent.override does not spoof the platform part anymore in ESR 60 which is confusingBug 26146: Spoof HTTP User-Agent header for desktop platforms

In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.

BugUX
Windows Jump Lists fail for Tor BrowserBug 12885: Windows Jump Lists fail for Tor Browser

Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations
and has a name in the form [a-f0-9]+.customDestinations-ms

The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.

However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.

The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.

Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See Apps::Impact::MinimalApps::Type::BugBugDisk LeakRoadmap::FutureWindows
Tor Browser on Windows creates a file in %APPDATA%\Microsoft\Windows\Recent\CustomDestinations containing the Tor Browser install locationbug 28996.

Bug
Make sure default Firefox themes are enabled on ESR68Bug 30845: Make sure default themes and other internal extensions are enabled

Task
Make sure our bundled WebExtensions are running in Private Browsing ModeBug 28896: Enable extensions in private browsing by default

BugBugSmashFund
Set network.proxy.allow_hijacking_localhost to trueBug 31065: Explicitly allow proxying localhost

Bug
Properly enable letterboxing (again)Bug 31598: Enable letterboxing

Disable Presentation API everywhere

BugSmashFundTask
Investigate wasm for linkability/fingerprintability/disk avoidance issuesBug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels.

BugLinkability
https://mitmdetection.services.mozilla.com/ is contacted over catch-all circuitBug 32321: Disable Mozilla's MitM pings

Bug
Tor Browser warning: "Your Firefox is out of date."Bug 19890: Disable installation of system addons

By setting the URL to "" we make sure that already installed system addons get deleted as well.

BugFingerprinting
Firefox downgrades VP9 videos to VP8 when measured performance is not enoughBug 22548: Firefox downgrades VP9 videos to VP8.

On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8.

This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available".

AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Add mobile-override of 000-tor-browser prefs

BugBugSmashFundSecurityUX
8-month-old Tor Browser offers to "Reset Tor Browser", removes extensionsBug 16441: Suppress "Reset Tor Browser" prompt.

BugDisk LeakUX
Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayableBug 29120: Use the in-memory media cache and increase its maximum size.

BugNext
Investigate new Search Engine configurationBug 33697: use old search config based on list.json

Bug
Don't use site's icon as window icon in Windows when in private browsing modeBug 33855: Ensure that site-specific browser mode is disabled.

Feature
Adapt Intermediate Preloading for Tor BrowserBug 30682: Disable Intermediate CA Preloading.

Fingerprinting
ensure that Windows default browser agent is omittedBug 40061: Omit the Windows default browser agent from the build

Backport
Consider disabling network.connectivity-service.enabledBug 40322: Consider disabling network.connectivity-service.enabled

Set svg.context-properties.content.allowed-domains as emptyBug 40408: Disallow SVG Context Paint in all web content

Doing
Set privacy.partition.network_state = false until we evaluate dFPIBug 40308: Disable network partitioning until we evaluate dFPI

Backport
Consider disabling network.connectivity-service.enabledBug 40322: Consider disabling network.connectivity-service.enabled

Disable dom.enable_event_timingBug 40383: Disable dom.enable_event_timing

Flip network.http.http3.enabledBug 40423: Disable http/3

Doing
Clean up obsolete preferences in our 000-tor-browser.jsBug 40177: Update prefs for Fx91esr

User Feedback
Switch Firefox recommendations off by defaultBug 40700: Disable addons and features recommendations

Doing
Set network.proxy.allow_bypass to falseBug 40682: Disable network.proxy.allow_bypass

DoingFingerprintingLinkability
3rd-party cookies are not disabled anymore in Tor Browser 11Bug 40736: Disable third-party cookies in PBM

FeatureFor Network Health TeamNeeds DesignSecurityUX
Disable Plaintext HTTP Clearnet ConnectionsBug 19850: Enabled HTTPS-Only by default

NextQ2UXUser Feedback
Hide screenshots menu since we don't support itBug 40912: Hide the screenshot menu

DoingProject 131Q3UX
moreFromMozilla pane in about:preferences in 12.0a2Bug 41292: Disable moreFromMozilla in preferences page

All PlatformsApps::Impact::HighApps::Type::InvestigationFingerprintingProject 131Roadmap::FutureTask
ensure that CSS4 system colors are not a fingerprinting vectorBug 40057: Ensure the CSS4 system colors are not a fingerprinting vector

DoingFeatureFingerprintingLinkabilityProject 131Q4esr-102
In Tor Browser context, should network.http.tailing.enabled be set to false?Bug 24686: Set network.http.tailing.enabled to true

Project 131Taskesr-102
Consider disabling TLS ciphersuites containing SHA-1Bug 40183: Disable TLS ciphersuites using SHA-1

Project 131Q4Taskesr-102
Review 000-tor-browser.js and 001-base-profile.js for 102Bug 40783: Review 000-tor-browser.js and 001-base-profile.js for 102

We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them.

Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users.

We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756

Do not include Normandy at all whenever MOZ_NORMANDY is False.

More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser.

All Platforms
Disable about:sync-logsBug 41662: Disable about:sync-logs

Even though we disable sync by default with identity.fxaccounts.enabled, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component.

Revert add-on install permissions introduced in Mozilla's 1560059Bug 40025: Remove Mozilla add-on install permissions

Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

Only ship the pdfjs extension.

In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's RESOLVED FIXED(Fx52), Blocks: 1299627, 1299694, 1528884
Remove MOZ_EME build option and make EME disabled by preferences.bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, Apps::Impact::MinimalApps::Type::BugBugIceboxUpstreamWindows
iis windows authentication prompt not showing uptor-browser#27602

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.

DoingQ2
Rebase geckoview patches to 99.0Bug 40857: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Prevent mach package-multi-locale from actually creating a packageBug 41458: Prevent mach package-multi-locale from actually creating a package

macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it.

BugSecurity
Creating incremental MAR files for the hardened builds is brokenBug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan.

Bug
Create a rebased patch for #18885Bug 21849: Don't allow SSL key logging.

AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Disable features at compile-time

Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION

Bug
wrong default pref values in Tor Browser 8.0Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds

This fixes a problem where some preferences had the wrong default value. Also see AndroidFeature
TBA: Add export MOZILLA_OFFICIALbug 27472 where we made a similar fix for Android.

AndroidBug
Playing videos on Twitter is not working and freezing the mobile browserBug 29859: Disable HLS support for now

BugSmashFundTask
Make sure telemetry reporting is disabled in Tor Browser 9Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING

Task
Consider adding MOZ_SERVICES_HEALTHREPORT to mozconfigBug 32493: Disable MOZ_SERVICES_HEALTHREPORT

Bug
Consider setting MOZ_NORMANDY=FalseBug 33734: Set MOZ_NORMANDY to False

Bug
Patch out Parental Controls detection and loggingBug 33851: Omit Parental Controls.

Add --enable-rust-simd to our tor-browser mozconfig files.Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files

All PlatformsProject 131Task
Move some configuration options to base-browser levelBug 41584: Move some configuration options to base-browser level

13.5 stableDocumentation
Letterboxing manual entry (about:manual#letterboxing)Bug 42440: Remove the "Prioritize .onion sites when known" option

13.5 stableBacklogBuild SystemDesktopDoingLocalizationTask
(Semi-)Automatically merge translation resources across tor browser releases (desktop)Bug 42305: Tidy up stable strings, ready for new translation CI.

Cherry-picked from All PlatformsBacklogLocalizationTask
Remove legacy strings (13.0)Bug 42221: Remove unused strings now that 13.0 is stable.

Plus removed aboutTor.dtd after 13.0 stableApps::Type::MetaBrandDesktopDoingNeeds DesignProject 131UX
Modernize Tor Browser's new-tab page (about:tor)Bug 41333.

Fix some errors introduced while cherry-picking 9920c7225592aac5e05aff56d48bb0bdcc6d9193 as 4b69c25929cce11ca9758996f04ec830bb53e670.

Bug 42444: Remove the "Prioritize .onion sites when known" option

Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar.

13.0 stable13.5 stableAll PlatformsBackportDoingFeature
Add startpage onion service to list of search providersBug 42459: Add Startpage Onion search provider

eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed.

Also: FeatureUX
Use duckduckgo hidden service instead of clearnet oneBug 16322: Update DuckDuckGo search engine

We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to VERIFIED FIXED(Fx36), Blocks: 1073292
Add DuckDuckGo to default search engine listbug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well.

Also: This fixes FeatureUX
Use non-/html search engine URL for DuckDuckGo search pluginsbug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly.

Also fixes Bug
build1 for Tor Browser 8.5a9 is broken in mobile packaging stepbug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for.

Also regression tests.

squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing

First ContributionNextProject 131Q4esr-102
Update Startpage search providerBug 40494: Update Startpage search provider

squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing

Backlog
Add Blockchair as a search engineBug 40438: Add Blockchair as a search engine

Bug
Disconnect search addon causes error at startupBug 33342: Avoid disconnect search addon error after removal.

We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore.

Shown in the downloads panel, about:downloads and places.xhtml.

For now this function only deletes old language packs for which we are already packaging the strings with the application.

This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation.

We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates.

When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key.

If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page.

If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt.

Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt.

Add support for onion services strings to the TorStrings module.

Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of ProjectUX
Objective 2, Activity 4: Better client-side errorsbug 30025.

Also fixes BugBugSmashFundUX
Make a menu to add onion and auth-cookie to TBbug 19757: Add a "Remember this key" checkbox to the client auth prompt.

Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk.

Also fixes FeatureUX
TorBrowser might want to have an error page specific to when .onion links failbug 19251: use enhanced error pages for onion service errors.

Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine.

Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services:

• HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure
• HTTP Onion Service pages would be marked as unencrypted in the Page Info screen
• Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content

This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.

Strings for Onion Service Page Info page are pulled from Torbutton's localization strings.

In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want.

It's time for our rotation again: Move the backup key in the front position and add a new backup key.

DoingSigningTaskUpdater
Generate a second mar signing key for nightlyBug 33803: Move our primary nightly MAR signing key to tor-browser

DoingSigningTaskUpdater
Generate a second mar signing key for nightlyBug 33803: Add a secondary nightly MAR signing key

Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release).

Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts.

Also fix TaskUXUpdater
Update about:tor when Tor Browser is updatedbug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor.

This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122.

Revert most changes from Mozilla RESOLVED FIXED(Fx43)
main thread I/O in update serviceBug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)."

We kept the addition to the AppConstants API in case other JS code references it in the future.

This commit was once part of "SecurityTaskUX
Deploy experimental builds using the Firefox update processBug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit.

Regression tests for MikePerryIteration20110515actualpoints::3component::firefox patch issuesowner::mikeperryparent::2877points::2priority::mediumresolution::fixedseverity::normalstatus::closedtype::defect
Make Permissions-Manager memory-only in TorBrowserBug #2950: Make Permissions Manager memory-only

Regression tests for component::mixminion-clientowner::nickmpriority::lowresolution::fixedseverity::blockerstatus::closedtype::defectversion::0.0.4
Incorrect node routing with mboxTB4: Tor Browser's Firefox preference overrides.

Note: many more functional tests could be made here

Regression tests for #2874: Block Components.interfaces from content

Feature
Add a script in tor-browser.git to run all of our TBB-specific regression testsBug 18923: Add a script to run all Tor Browser specific tests

Regression tests for BugBugSmashFundSecurityUX
8-month-old Tor Browser offers to "Reset Tor Browser", removes extensionsBug #16441: Suppress "Reset Tor Browser" prompt.

13.0 stableApps::Type::MetaBrandDesktopDoingNeeds DesignProject 131UX
Modernize Tor Browser's new-tab page (about:tor)Bug 41333: Update about:tor to new design. Including:

• make the favicon match the branding icon.
• make the location bar show a search icon.

• implements new about:torconnect page as tor-launcher replacement
• adds new torconnect component to browser
• tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
• adds warning/error box to about:preferences#tor when not connected to tor

DoingProject 96 - FINISHEDQ2UX
Update the about:torconnect frontend page to match additional UI flowsBug 40773: Update the about:torconnect frontend page to match additional UI flows.

12.5 stableDesktopDoingFeatureQ1UX
Improve the UX of the location bar's connection statusBug 41608: Add a toolbar status button and a urlbar "Connect" button.

This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present:

• Setting built-in bridges
• Requesting bridges from BridgeDB via moat
• Using user-provided bridges
• Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
• Setting firewall ports
• Viewing and Copying Tor's logs
• The Networking Settings in General preferences has been removed

DoingQ2Sponsor 30 - FINISHEDUX
Update about:preferences page to match new UI designsBug 40774: Update about:preferences page to match new UI designs

Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system".

To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts.

The browser should not need information related to the network interface or network state, tor should take care of that.

See RESOLVED FIXED(Fx55), Blocks: 1357994, [tor-mobile]
Replace url.openConnection with ProxySelector.openConnectionWithProxyBug 1357997 for partial uplift.

Also: AndroidFeature
Build Orbot into TBABug 28051 - Use our Orbot for proxying our connections

Proxy BypassTask
ESR68 Network Code ReviewBug 31144 - ESR68 Network Code Review

DesktopDoingFeatureLinkabilityProject 131Q1UX
Skip Drag & Drop filtering for DNS-safe URLs (no hostname, e.g. RFC3966 tel:)Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs

Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain.

FeatureFirst ContributionNew IdentityUX
Add New Circuit button to TorButtonBug 9442: Add New Circuit button

BugUX
Raise MaxCircuitDirtiness for Tor Browser to 2 hoursBug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ.

Feature
SOCKS isolation should include a process identifier.Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce.

Feature
SOCKS isolation should include a process identifier.Bug 19206: Clear out the domain isolator state on New Identity.

Bug
Adapt torbutton to TBB/FF52ESRBug 21201.2: Isolate by firstPartyDomain from OriginAttributes

Bug
Catch-all circuits are not working properly in ESR 52 based Tor BrowserBug 21745: Fix handling of catch-all circuit

DesktopTask
Refactor the domain isolator and new circuitBug 41741: Refactor the domain isolator and new circuit

• migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module
• TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs
• TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor
• about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module
• all tor settings live in the torbrowser.settings.* preference branch
• removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm

Needs ReviewProject 96 - FINISHED
Implement new Moat apis in Moat.jsm moduleBug 40645: Migrate Moat APIs to Moat.jsm module

Desktop
Refactor the control port client implementationBug 41926: Reimplement the control port

On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode.

Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error.

13.0 stable13.5 stableBackportEmergency
Update moat domain fronting configurationBug 42435: Update moat domain fronting configuration

Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end.

In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply.

DoingLocalizationProject 131Q4esr-102
Enable fluent warnings on nightly and dev buildstor-browser#41285: Enable fluent warnings.

Also: Add an --enable-tor-browser-data-outside-app-dir configure option

Add --with-tor-browser-version configure option

BugBugSmashFund
disable per-installation profilesBug 31457: disable per-installation profiles

The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data.

Bug
TB9.0a7 is asking for a new profileBug 31935: Disable profile downgrade protection.

Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected.

Add --enable-tor-browser-update build option

Move our configure options from old-configure.in to moz.configureBug 40793: moved Tor configuration options from old-configure.in to moz.configure

All PlatformsProject 131Task
Move some configuration options to base-browser levelBug 41584: Move some configuration options to base-browser level

Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning.

Closes #40209.

Correct minor Cryptocurrency warning string typoBug 40428: Fix string attribute names

See also Bugs #5194, #7187, #8115, #8219.

This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons.

Also fix BugUX
many occurrences of "Firefox" in about:preferencesbug 27905.

BugUX
Activity 1.1 Update Tor Browser icon to follow design guidelines.Bug 25702: Update Tor Browser icon to follow design guidelines

• Updated all of the branding in /browser/branding/official with new 'stable' icon series.
• Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory
• Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654)
• Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory
• Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico)
• Added default256.png and default512.png icons
• Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon
• Use the Tor Browser icon within devtools/client/themes/images/.

BugUX
Blurry Tor Browser icon on macOS app switcherBug 30631: Blurry Tor Browser icon on macOS app switcher

It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil.

Bug
about:preferences#general is not properly translated anymore starting with Tor Browser 8.5a4Bug 28196: preparations for using torbutton tor-browser-brand.ftl

A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser.

BugUX
branding for about:debugging needs logo SVGBug 31803: Replaced about:debugging logo with flat version

Bug
Distinguish between Tor Browser and Firefox when macOS opens documentsBug 21724: Make Firefox and Tor Browser distinct macOS apps

When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser.

BugUX
Tor Browser Support should link to our support portalBug 32092: Fix Tor Browser Support link in preferences

For Needs Review
Reorganize patchsetbug 40562, we moved onionPattern* from BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
Remove gap between Tor Launcher window and main browser windowbug 27476 to here, as about:tor needs these files but it is included earlier.

Needs DesignNeeds ReviewProject 131Q1TaskUXWindows
Create PDF icons for both browsersBug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one

13.0 stableBrandDoingFeatureLinuxNeeds Design
Implement Linux application iconsBug 42088: New application icons (used in-app and on linux).

13.0 stableBrandDoingFeatureNeeds DesignWindows
Implement Windows application iconsBug 42087: New application icons (windows).

This commit adds all the strings needed for Tor Browser patches.

Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior.

Besides disabling the "Delete on close checkbox", disable also the "Manage Exceptions" button when always using PBM.

about:preferences allow to override some of our defaults, that could be fingeprintable or have some other unwanted consequences.

All PlatformsDoingNext
Update nightly mar signing keyMB 256: Add mullvad-browser nightly mar signing key

DesktopQ1Task
Set the updater base URL to Mullvad domainMB 71: Set the updater base URL to Mullvad domain

Windows and Linux will be distributed only as portable apps at the beginning, so they should not be settable as default browsers. We will need to improve the logic once we decide to ship system-wide installers, too.

This commit disables the about:login page and removes the "Login and Password" section of about:preferences.

We do not do anything to the real password manager of Firefox, that is in toolkit: it contains C++ parts that make it difficult to actually prevent it from being built..

Finally, we modify the the function that opens about:login to report an error in the console so that we can quickly get a backtrace to the code that tries to use it.

Backport
Mullvad support email has changed from support@mullvad.net to support@mullvadvpn.netMB 270: Update support email

Also: All PlatformsQ1Task
Purge unneeded about: pagesmullvad-browser#57: Purge unneeded about: pages

We install a few addons from the distribution directory, but they are not automatically enabled for PBM mode. This commit modifies the code that installs them to also add the PBM permission to the known ones.

See also: All PlatformsProject 131Q1Task
Product name and directory customizationmullvad-browser#5: Product name and directory customization All PlatformsFeatureProject 131Q1
Create new branding directories and integrate Mullvad icons+brandingmullvad-browser#12: Create new branding directories and integrate Mullvad icons+branding DesktopProject 131Q1Task
Remove Default Built-in bookmarksmullvad-browser#14: Remove Default Built-in bookmarks Project 131Q1TaskWindows
Add custom PDF icons for Windows buildsmullvad-browser#35: Add custom PDF icons for Windows builds BugQ1Windows
Replace Mozilla copyright and legal trademarks in mullvadbrowser.exe metadatamullvad-browser#48: Replace Mozilla copyright and legal trademarks in mullvadbrowser.exe metadata All PlatformsBugQ1
Update trademark stringmullvad-browser#51: Update trademark string BugDoingQ1Windows
Update shipped dll metadata copyright/licensing infomullvad-browser#104: Update shipped dll metadata copyright/licensing info BrandDesktopProject 131Q1TaskUX
Implement Nightly and Alpha app iconsmullvad-browser#107: Add alpha and nightly icons