TB 43786: Add new UX flow for changing security level (Android)

TB 43786: Add new UX flow for changing security level (Android)

TB 43786: Add new UX flow for changing security level (Android)

TB 43783: Expose SecurityLevelPrefs.setSecurityLevelAndRestart to android integration.

Originally, Next
Implement Security Level settingsfenix#40026.

AndroidBuild System
Allow tba-fetch-deps.sh to fetch prebuilt artifacts from tor-browser-build from nightliesBug 43809: allow tba-fetch-deps to download nightlies

Fetch the custom built no-op application services library from tor-browser-build when building for Android.

AndroidBuild System
Allow tba-fetch-deps.sh to fetch prebuilt artifacts from tor-browser-build from nightliesBug 43809: allow tba-fetch-deps to download from nightlies

Make sure Region.jsm fetching is disabledBug 40083: Make locale ordering in BuildConfig deterministic

decide if we need a watershed update prior to our esr78-based Tor BrowserBug 40042: Add option do overwrite timestamp in extension version

Fingerprinting
verify that our external helper apps patch is still effectiveBug 40059: Use MOZ_BUILD_DATE for versionCode

At the same time we adapt MOZ_BUILD_DATE to our needs where it is actually used and not in tor-browser-build. This gives us more flexibility. See: tor-browser-build#40084.

Needs Information
Tor Browser's letterboxing wastes too much screen space in some casesBug 40067: Fix reproducibility issue in classes2.dex

We make sure our MOZ_BUILD_DATE gets used as a source for showing date related information on the Fenix about page.

Icebox
Make a Cross-Platform Portable Browser BundleBug 40071: Show only supported locales

Linkability
consider enabling new cache isolation featuresBug 40064: Use Gecko Beta for Nightly and Debug variants

All PlatformsApps::Impact::MediumApps::Type::InvestigationLinkabilityRoadmap::FutureTask
Evaluate trade-offs between dFPI and FPIBug 40123: Allow building the instrumented tests apks for variants other than debug

This allows to specify the variant of the instrumented tests via a testBuildType gradle argument. It also applies a workaround for a R8 issue from https://issuetracker.google.com/issues/140851070.

UX
There should be warning when using Settings/ExtensionsBug 40143: Use deterministic date in Test apk

The build config was using Date() when generating the Test apk's versionName.

This is needed because the default snackbar will force all caps, which can cause problems in some languages. See 14.5 stableAndroidBugDoingLocalizationProject 163
Don't force ALL CAPS for the fenix snackbar action button texttor-browser#43351 and bugzilla NEW
Remove usages of textAllCapsbug 1935387.

TODO: Remove once the forced all caps is removed by mozilla.

Originally, Implement Network settingsfenix#40041.

TB broken on MacOS 11 Big SurBug 40015: Modify Home menu

All PlatformsApps::Impact::LowApps::Type::InvestigationFeatureRoadmap::Future
Enable SharedArrayBuffers with sequential threads?Bug 40016: Hide unwanted Settings

All PlatformsApps::Impact::LowApps::Type::InvestigationFeatureRoadmap::Future
Enable SharedArrayBuffers with sequential threads?Bug 40016: Modify Default toolbar menu

All PlatformsApps::Impact::LowApps::Type::InvestigationFeatureRoadmap::Future
Enable SharedArrayBuffers with sequential threads?Bug 40016: Add Donate settings button

All PlatformsApps::Impact::LowApps::Type::InvestigationFeatureRoadmap::Future
Enable SharedArrayBuffers with sequential threads?Bug 40016: Move Allow Screenshots under Advanced

All PlatformsApps::Impact::LowApps::Type::InvestigationFeatureRoadmap::Future
Enable SharedArrayBuffers with sequential threads?Bug 40016: Don't install WebCompat webext

All PlatformsApps::Impact::LowApps::Type::InvestigationFeatureRoadmap::Future
Enable SharedArrayBuffers with sequential threads?Bug 40016: Don't onboard Search Suggestions

HTTPS Everywhere Update Channels Preferences has TypeError in 10.0a5Bug 40094: Do not use MasterPasswordTipProvider in HomeFragment

Doing
Review Mozilla developer notes for 79-81 (including)Bug 40095: Hide "Sign in to sync" in bookmarks

FeatureRoadmap::Future
Easier flow to navigate back to clear-URL after an onion-location redirect, e.g. when onion is brokenBug 40031: Hide Mozilla-specific items on About page

Apps::Impact::MediumApps::Type::AuditFingerprintingLinkabilityRoadmap::FutureTaskWindows
investigate browser's use of the MediaControl API (Windows)Bug 40063: Do not sort search engines alphabetically

Icebox
Insecure HTTP pages should display warning about bad exit nodesBug 40141: Hide EME site permission

BackportDoing
Disable security.certerrors.mitm.auto_enable_enterprise_rootsBug 40166: Hide "Normal" tab (again) and Sync tab in TabTray

Icebox
Onion services icons are gray even if secure connection icons should be greenBug 40167: Hide "Save to Collection" in menu

Security UI not updated for non-https .onion pages in FenixBug 40172: Find the Quit button

Prepare switch to mozilla83 for mobileBug 40186: Hide Credit Cards in Settings

Needs Review
Expose privacy.spoof_english pref in GeckoViewBug 40198: Spoof English toggle now overlaps with locale list

Originally, Doing
Modify Fenix Settings Menufenix#40016.

Originally, BugDoingPlatform ParityUX
UI changes for "Only Private Browsing Mode" on Androidfenix#34403.

Originally, Needs Review
Implement a spoof/no spoof toggle in the locale chooserfenix#40087 and Needs Review
Expose spoofEnglish prefandroid-components#40019.

Originally, Use NimbusDisabledfenix#40185.

Icebox
On a v2 onion page, Onion-Location with a v3 onion should count as "onion available"Bug 40020: Change applicationId

Icebox
On a v2 onion page, Onion-Location with a v3 onion should count as "onion available"Bug 40020: Change app name

Icebox
On a v2 onion page, Onion-Location with a v3 onion should count as "onion available"Bug 40020: Change deeplink scheme

Icebox
On a v2 onion page, Onion-Location with a v3 onion should count as "onion available"Bug 40020: Change App icons

Doing
Consider disabling remote Public Suffix List fetchingBug 40073: Use correct branding on About page

Moat "Submit" button does not workBug 40088: Use Tor Browser logo in migration screen

Originally, Disallow Cleartext Trafficfenix#40032.

Androidcomponent::applications/tor browsergitlab-tb-fenixowner::tbb-teamparent::33184priority::mediumseverity::normalsponsor::58-muststatus::newtbb-mobiletype::task
Fenix Use of GleanBug 33594: Disable data collection by default (Glean)

Backport
".onion available" is been displayed in an https onion siteBug 40019: Adjust is disabled on Release when data collection is disabled

TorBrowserTeam202006component::applications/tor browsergitlab-tb-android-componentsowner::tbb-teamparent::34324priority::mediumseverity::normalstatus::newtbb-mobiletype::defect
Audit mozilla_lib_crashBug 34338: Disable the crash reporter

AndroidProject 131Q4esr-102
Check which of our mobile prefs and configuration changes are still valid for GeckoViewBug 40014: Neuter Google Advertising ID

Updater
Linux64 10.0a1-10.0a2 incremental update failsBug 40018: Disable Push service

All PlatformsApps::Impact::HighApps::Type::BugBugProxy BypassRoadmap::Future
DoH/TRR disabled by network.dns.disabled makes it unsafe to test DoHBug 40034: Disable PWA onboading

Incorrect Exit IP shown after New Circuit requestBug 40072: Disable Tracking Protection

Fingerprinting
ensure that Windows default browser agent is omittedBug 40061: Do not show "Send to device" in sharing menu

Doing
Playing videos breaks after reloading pages in ESR 78-based buildsBug 40109: Reduce requested permissions

Exclude LOCATION and NETWORK_STATE

Originally, BugNeeds Review
Isolate Icon loader on Androidandroid-components#34439.

Originally, Completely stop the Private Notifcation Serviceandroid-components#40023.

3rd party cookies are allowedandroid-components#40020: Disable third-party cookies

Tracking Protection onboarding still enabledandroid-components#40024: Disable tracking protection by default

Originally, TaskUX
Port padlock states for .onion services to Fenixandroid-components#40015.

Hide option for disallowing addons in private modeandroid-components#40011: Hide option for disallowing addons in private mode

Needs Review
Allow inheriting from AddonCollectionProviderandroid-components#40016: Allow inheriting from AddonCollectionProvider

This will allow implementing our own AddonsProvider in fenix.

AndroidProject 131Q4esr-102
One-time ultimate switch Tor Browser Android to HTTPS-Only and getting rid of any HTTPS-Everywhere remnantsBug 41160: One-time ultimate switch Tor Browser Android to HTTPS-Only. AndroidProject 131Q3esr-102
Remove HTTPS-Everywhere extension from esr102-based Tor Browser AndroidBug 41159: Remove HTTPS-Everywhere extension from Tor Browser Android.

AndroidProject 131Q3esr-102
Enable HTTPS-Only Mode by default in Tor Browser AndroidBug 41094: Enable HTTPS-Only Mode by default in Tor Browser Android.

Turn shouldUseHttpsOnly's default to true.

Tor Browser window size changes with Windows 10 display scaling (e.g. 125% --> 998x999)Bug 40225: Bundled extensions don't get updated with Android Tor Browser updates.

TBB is not detecting a .onion on a websiteBug 40030: Install NoScript addon on startup.

Also 40070: Consider storing the list of recommended addons

This implements our own AddonsProvider, which loads the list of available addons from assets instead of fetching it from an endpoint.

Also, we hide the uninstall button for builtin addons.

FingerprintingProject 131Q4esr-102
ensure no locale leaks from new Intl APIsBug 40058: Hide option for disallowing addon in private mode

Originally, AndroidBugDoingPlatform Parity
Search engines on mobile Tor Browser don't match the desktop onesandroid-components#40009.

This matches the search engines from desktop, that is: DDG as the default, then YouTube, Google, DDGOnion, Startpage, Twitter, Wikipedia and Yahoo.

Update DuckDuckGo onion search providerandroid-components#40062: Update DuckDuckGo onion search plugin

Originally, Needs Review
Make sure AndroidDownloadManager is not usedandroid-components#40002.

AndroidBackport
Support scoped storage to fix downloads on API >= 29android-components#40075: Support scoped storage to enable downloads on API < 29

• in android-components!7, we blocked all usage of Scoped Storage in an attempt to block usage of Android's DownloadManager, which is known to cause proxy bypasses
• as of Android API 29, downloads will not work without Scoped Storage, causing all downlaods to fail (see: BugUX
  TBA: users are reporting that can't download filesfenix##40192)
• here, we enable usage of scoped storage for API >= 29, but block calls to DownloadManager on API < 29

Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser.

All Platforms
Disable about:sync-logsBug 41662: Disable about:sync-logs

Even though we disable sync by default with identity.fxaccounts.enabled, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component.

Together with the corresponding fenix patch, this allows all startActivity that may open external apps to be replaced by TorUtils.startActivityPrompt.

Originally, Needs Review
Port external helper app promptingandroid-components#40007 and Needs ReviewTask
Port external helper app prompting before opening to Fenixfenix#34378.

Originally Modify WebExtensions Menuandroid-components#40005.

These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/715

We're manually adding them here while working on the interface, but eventually these should be placed in the right location using tor-browser-build.

Shown in the downloads panel, about:downloads and places.xhtml.

For now this function only deletes old language packs for which we are already packaging the strings with the application.

This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation.

We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates.

Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar.

When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key.

If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page.

If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt.

Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt.

Add support for onion services strings to the TorStrings module.

Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of ProjectUX
Objective 2, Activity 4: Better client-side errorsbug 30025.

Also fixes BugBugSmashFundUX
Make a menu to add onion and auth-cookie to TBbug 19757: Add a "Remember this key" checkbox to the client auth prompt.

Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk.

Also fixes FeatureUX
TorBrowser might want to have an error page specific to when .onion links failbug 19251: use enhanced error pages for onion service errors.

Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine.

Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services:

• HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure
• HTTP Onion Service pages would be marked as unencrypted in the Page Info screen
• Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content

This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.

Strings for Onion Service Page Info page are pulled from Torbutton's localization strings.

In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want.

After upstream changes between Firefox 115 and 128, we had to completely rework the way in which we define our search engines.

This commit replaces the old "Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing".

With that commit, we customized a list of addons IDs to ship as built-in search engines, but then upsteam moved to using only RemoteSettings. The configuration has many more fields, and it would be quite long to include it in the source code. Therefore, we use some local JSON files and load the settings from them.

It's time for our rotation again: Move the backup key in the front position and add a new backup key.

DoingSigningTaskUpdater
Generate a second mar signing key for nightlyBug 33803: Move our primary nightly MAR signing key to tor-browser

DoingSigningTaskUpdater
Generate a second mar signing key for nightlyBug 33803: Add a secondary nightly MAR signing key

This commit was once part of "SecurityTaskUX
Deploy experimental builds using the Firefox update processBug 4234: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit.

13.0 stableApps::Type::MetaBrandDesktopDoingNeeds DesignProject 131UX
Modernize Tor Browser's new-tab page (about:tor)Bug 41333: Update about:tor to new design. Including:

• make the favicon match the branding icon.
• make the location bar show a search icon.

We are planning of tempoorarily using about:torconnect on Android, until the native UX is ready.

• implements new about:torconnect page as tor-launcher replacement
• adds new torconnect component to browser
• tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
• adds warning/error box to about:preferences#tor when not connected to tor

DoingProject 96 - FINISHEDQ2UX
Update the about:torconnect frontend page to match additional UI flowsBug 40773: Update the about:torconnect frontend page to match additional UI flows.

12.5 stableDesktopDoingFeatureQ1UX
Improve the UX of the location bar's connection statusBug 41608: Add a toolbar status button and a urlbar "Connect" button.

This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present:

• Setting built-in bridges
• Requesting bridges from BridgeDB via moat
• Using user-provided bridges
• Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
• Setting firewall ports
• Viewing and Copying Tor's logs
• The Networking Settings in General preferences has been removed

DoingQ2Sponsor 30 - FINISHEDUX
Update about:preferences page to match new UI designsBug 40774: Update about:preferences page to match new UI designs

The browser should not need information related to the network interface or network state, tor should take care of that.

DesktopDoingFeatureLinkabilityProject 131Q1UX
Skip Drag & Drop filtering for DNS-safe URLs (no hostname, e.g. RFC3966 tel:)Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs

GeckoView is missing some API we use on desktop for the integration with the tor daemon, such as subprocess. Therefore, we need to implement them in Java and plumb the data back and forth between JS and Java.

Add an XPCOM component that registers a ProtocolProxyChannelFilter which sets the username/password for each web request according to url bar domain.

FeatureFirst ContributionNew IdentityUX
Add New Circuit button to TorButtonBug 9442: Add New Circuit button

BugUX
Raise MaxCircuitDirtiness for Tor Browser to 2 hoursBug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ.

Feature
SOCKS isolation should include a process identifier.Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce.

Feature
SOCKS isolation should include a process identifier.Bug 19206: Clear out the domain isolator state on New Identity.

Bug
Adapt torbutton to TBB/FF52ESRBug 21201.2: Isolate by firstPartyDomain from OriginAttributes

Bug
Catch-all circuits are not working properly in ESR 52 based Tor BrowserBug 21745: Fix handling of catch-all circuit

DesktopTask
Refactor the domain isolator and new circuitBug 41741: Refactor the domain isolator and new circuit

• migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module
• TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs
• TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor
• about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module
• all tor settings live in the torbrowser.settings.* preference branch
• removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm

Needs ReviewProject 96 - FINISHED
Implement new Moat apis in Moat.jsm moduleBug 40645: Migrate Moat APIs to Moat.jsm module

Desktop
Refactor the control port client implementationBug 41926: Reimplement the control port

On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode.

Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error.

Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end.

In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply.

DoingLocalizationProject 131Q4esr-102
Enable fluent warnings on nightly and dev buildstor-browser#41285: Enable fluent warnings.

Also: Add an --enable-tor-browser-data-outside-app-dir configure option

Add --with-tor-browser-version configure option

BugBugSmashFund
disable per-installation profilesBug 31457: disable per-installation profiles

The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data.

Bug
TB9.0a7 is asking for a new profileBug 31935: Disable profile downgrade protection.

Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected.

Add --enable-tor-browser-update build option

Move our configure options from old-configure.in to moz.configureBug 40793: moved Tor configuration options from old-configure.in to moz.configure

All PlatformsProject 131Task
Move some configuration options to base-browser levelBug 41584: Move some configuration options to base-browser level

Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning.

Closes #40209.

Correct minor Cryptocurrency warning string typoBug 40428: Fix string attribute names

See also Bugs #5194, #7187, #8115, #8219.

This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons.

Also fix BugUX
many occurrences of "Firefox" in about:preferencesbug 27905.

BugUX
Activity 1.1 Update Tor Browser icon to follow design guidelines.Bug 25702: Update Tor Browser icon to follow design guidelines

• Updated all of the branding in /browser/branding/official with new 'stable' icon series.
• Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory
• Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654)
• Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory
• Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico)
• Added default256.png and default512.png icons
• Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon
• Use the Tor Browser icon within devtools/client/themes/images/.

BugUX
Blurry Tor Browser icon on macOS app switcherBug 30631: Blurry Tor Browser icon on macOS app switcher

It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil.

Bug
about:preferences#general is not properly translated anymore starting with Tor Browser 8.5a4Bug 28196: preparations for using torbutton tor-browser-brand.ftl

A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser.

BugUX
branding for about:debugging needs logo SVGBug 31803: Replaced about:debugging logo with flat version

Bug
Distinguish between Tor Browser and Firefox when macOS opens documentsBug 21724: Make Firefox and Tor Browser distinct macOS apps

When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser.

BugUX
Tor Browser Support should link to our support portalBug 32092: Fix Tor Browser Support link in preferences

For Needs Review
Reorganize patchsetbug 40562, we moved onionPattern* from BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
Remove gap between Tor Launcher window and main browser windowbug 27476 to here, as about:tor needs these files but it is included earlier.

Needs DesignNeeds ReviewProject 131Q1TaskUXWindows
Create PDF icons for both browsersBug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one

13.0 stableBrandDoingFeatureLinux
Implement Linux application iconsBug 42088: New application icons (used in-app and on linux).

13.0 stableBrandDoingFeatureWindows
Implement Windows application iconsBug 42087: New application icons (windows).

This commit adds all the strings needed for Tor Browser patches.

Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior.

We drop the README.txt that comes from Mozilla Firefox and add README.md for tor-browser.

TB 43782: Update security level UI for new UX flow.

In addition, we drop the distinction between the security levels in the UI when the user has a custom security level.

I.e. we always show shield as unfilled but with a yellow dot in the toolbar, and we just call it "Custom" rather than "Standard Custom", etc.

TB 43783: Prompt user for a restart if their security level preferences are not aligned at startup or mid-session.

Also handle failures to apply NoScript settings.

This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.

Geckoview: Expose security level interfaceBug 40125: Expose Security Level pref in GeckoView

TB 43782: Add strings for new security level UX flow.

TB 43783: Add security level prompt strings.

This commit adds all the strings needed by following Base Browser patches.

TB 43783: Allow the browser to wait for the NoScript settings to be applied.

This commit implmenents the the Base Browser's version of _migrateUI.

This hides it from both the toolbar and the unified extensions panel.

We also hide the unified-extension-button if the panel would be empty: not including the NoScript button when it is hidden. As a result, this will be hidden by default until a user installs another extension (or shows the NoScript button and unpins it).

Backlog
extensions.allowPrivateBrowsingByDefault will be removedBug 40253: Explicitly allow NoScript in Private Browsing mode.

Remove the items not compatible with our features (such as history) from the migration wizard.

On Linux, allow to specify an alternative home directory, since we usually change $HOME in our startup script.

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as $MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/.

Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.

Also fix Bug
Tor Browser 8.0a10 wants to update to 8.0a10bug 27221: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug
potentially confusing "restart to update" message in ESR60Bug 26048: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.

BugBugSmashFundUXUpdater
notify users that update is downloadingBug 28885: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress.

As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

Treat about:blank as the default home page and new tab page.

Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order to avoid several network requests that we do not need.

Disable unused about: pagesBug 41624: Disable about:pocket-* pages.

BugDesktopFirst ContributionProject 131UX
about:privatebrowsing Firefox brandingBug 40144: Redirect about:privatebrowsing to the user's home

Change the language selector to be sorted by language code, rather than name, and to display the language code to the user.

LocalizationMacOSProject 131Q4UX
"Japanese" language menu item is localised in multi-locale testbuild (on mac OS)Bug 41372: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs.

LocalizationNeeds DesignProject 131Q4UX
Inform users when Tor Browser sets their language automaticallyBug 41378: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once.

Firefox shows "vendor remoteName" as a title of the "... is playing media" notification on Linux. However, for our browser the remote name is enough, and prepending the vendor to it creates a string users usually never see.

It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

In RESOLVED FIXED(Fx118), Blocks: 82851
file:// needs to expand ~ to home directory in some OSBug 93141, Mozilla started sending users to their home when they type ~ in the URL bar. On Linux, we change $HOME for various reason, therefore you would be redirected to the spoofed home directory when typing ~. So, we check if the original home directory is known, and use that, instead.

This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows.

On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle.

This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS).

It is ignored because of RFP and it is confusing for users.

BugDesktopFirst ContributionRoadmap::FutureUXUpliftUpstream
Remove "New Private Window" option from Tor Browser or make it a separate sessionBug 25660: Remove the "New Private Window" option

We hide the Website Privacy Preferences section, which controls the "global privacy control" (GPC) and "do not track" (DNT) settings.

This should remain disabled, see 14.0 stableAll PlatformsTaskesr-128
Opt out from Firefox relay by default.tor-browser#42814.

The OS language might be outside the list of actually supported languages and it might leak the user's region. Therefore, we force the locale reported in Accept-Language to match one we support with translations, even when it means using a not exact region tag.

This checks privacy.spoof_english whenever setLocales is called from Fenix side and sets intl.accept_languages accordingly.

Needs Review
Expose privacy.spoof_english pref in GeckoViewBug 40198: Expose privacy.spoof_english pref in GeckoView

Windows has a system to set font aliases through the registry. This allows some customization that could be used as a fingerprinting vector. Moreover, this mechanism is used by Windows itself, and different SKUs might have different default FontSubstitutes.

We ship a fontconfig configuration to esnure all Linux users have the same defaults and reduce the chances of fingerprinting. We used to add this file in tor-browser-build, but some users might skip it by using the browser executable without the wrapper script. Therefore, we decided to activate the file with the FontConfig API instead of the environment variables.

FontsLinux
Investigate why STIX Two becomes the default font on LinuxBug 41043: Hardcode the UI font on Linux

The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese).

14.0 stableFingerprintingFontsLinux
Hardcode Arimo as a system-ui fontBug 43141: Hardcode system-ui to Arimo.

XHR requests initiated by extensions are exempt from RFP. Therefore, they report the actual app name, instead of Firefox, and the actual Firefox minor version.

This happens whenever the app name has been customized and does not match a hardcoded "Firefox".

Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users.

We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756

Do not include Normandy at all whenever MOZ_NORMANDY is False.

More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

Revert add-on install permissions introduced in Mozilla's 1560059Bug 40025: Remove Mozilla add-on install permissions

Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

Only ship the pdfjs extension.

In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's RESOLVED FIXED(Fx52), Blocks: 1299627, 1299694, 1528884
Remove MOZ_EME build option and make EME disabled by preferences.bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, Apps::Impact::MinimalApps::Type::BugBugIceboxUpstreamWindows
iis windows authentication prompt not showing uptor-browser#27602

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.

This is a workaround to fix the GeckoView build with WebRTC disabled. We should replace this workaround with a proper solution, that excludes this test when MOZ_WEBRTC is undefined/False.

DoingQ2
Rebase geckoview patches to 99.0Bug 40857: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Prevent mach package-multi-locale from actually creating a packageBug 41458: Prevent mach package-multi-locale from actually creating a package

macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it.

BugSecurity
Creating incremental MAR files for the hardened builds is brokenBug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan.

Bug
Create a rebased patch for #18885Bug 21849: Don't allow SSL key logging.

AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Disable features at compile-time

Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION

Bug
wrong default pref values in Tor Browser 8.0Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds

This fixes a problem where some preferences had the wrong default value. Also see AndroidFeature
TBA: Add export MOZILLA_OFFICIALbug 27472 where we made a similar fix for Android.

AndroidBug
Playing videos on Twitter is not working and freezing the mobile browserBug 29859: Disable HLS support for now

BugSmashFundTask
Make sure telemetry reporting is disabled in Tor Browser 9Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING

Task
Consider adding MOZ_SERVICES_HEALTHREPORT to mozconfigBug 32493: Disable MOZ_SERVICES_HEALTHREPORT

Bug
Consider setting MOZ_NORMANDY=FalseBug 33734: Set MOZ_NORMANDY to False

Bug
Patch out Parental Controls detection and loggingBug 33851: Omit Parental Controls.

Add --enable-rust-simd to our tor-browser mozconfig files.Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files

All PlatformsProject 131Task
Move some configuration options to base-browser levelBug 41584: Move some configuration options to base-browser level

Ensures that moz-message-bar, including notifications, are announced on Orca.

This addresses upstream bugzilla NEW, Blocks: 374212, 1926044
Redirect blocked autorefresh infobar not read (ORCA)bug 1895857 and should likely be replaced when it is fixed.