This reverts commit c67b847fd43d97bcfe03ac455adbdb283b4872a1.

Bug
avoid reading policies from /etc/firefox on LinuxBug 34315: avoid reading policies from /etc/firefox on Linux

In RFP mode, we do not support PerformanceNavigationTiming, so don't expose it. In particular, window.PerformanceNavigationTiming should return undefined.

Added a new method PerformanceNavigationTiming::Enabled which when used with the WebIDL Func attribute allows us to toggle whether window.PerformanceNavigationTiming is exposed.

Created dom/tests/mochitest/general/test_toggling_performance_navigation_timing.html to test whether the toggling works. Updated browser/components/resistfingerprinting/test/browser/browser_performanceAPI.js to create a new window each time privacy.resistFingerprinting is flipped so this behavior does not leak into other tests.

A custom HTTPS Everywhere update channel is installed, which provides rules for locally redirecting some memorable .tor.onion URLs to non-memorable .onion URLs.

When these redirects occur, we also rewrite the URL in the urlbar to display the human-memorable hostname instead of the actual .onion.

Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar.

We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore.

It's time for our rotation again: Move the backup key in the front position and add a new backup key.

When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key.

If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page.

If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt.

Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt.

Add support for onion services strings to the TorStrings module.

Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of ProjectUX
Objective 2, Activity 4: Better client-side errorsbug 30025.

squash! Feature
Tor Browser: Improve TBB UI of hidden service client authorizationBug 30237: Add v3 onion services client authentication prompt

Also fixes BugBugSmashFundUX
Make a menu to add onion and auth-cookie to TBbug 19757: Add a "Remember this key" checkbox to the client auth prompt.

Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk.

squash! Feature
Tor Browser: Improve TBB UI of hidden service client authorizationBug 30237: Add v3 onion services client authentication prompt

Also fixes FeatureUX
TorBrowser might want to have an error page specific to when .onion links failbug 19251: use enhanced error pages for onion service errors.

More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.

Fixed parseBridgeStrings function in parseFunctions.jsm to now discard 'bridge' string prefix in user-provided bridge strings. Also now properly handling carriage returns ('\r') in bridge strings.

Fixed logic for when the Security Level panel is spawned based on input to mirror behavior of Downloads, Library and Hamburger menus. The panel now spawns on left-mouse button down, and on keyboard activation when user presses 'space' or 'enter'.

Simply removed the 'clever' caching of the underlying toolbar button element. Now, each time the button is needed it is queried from the underlying document.

A correct, but more complicated, fix would be to determine when the toolbar button had been moved to the overflow menu and then update our cached reference. However, this would be super brittle and would break once another way to move the toolbar button is added in the future.

In the end, caching something so infrequently queried is not worth the complexity.

With ESR68 we needed to add a new is="text-link" attribute to label elements used as hyperlinks

This patch adds a new about:preferences#tor page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present:

• Setting built-in bridges
• Requesting bridges from BridgeDB via moat
• Using user-provided bridges
• Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
• Setting firewall ports
• Viewing and Copying Tor's logs

In addition the following changes have been made:

• The Networking Settings in General preferences has been removed
• TorStrings has been removed from the SecurityLevel component and moved into a common shared module also used by about:preferences#tor

Update the "Tor Network" onboarding page to include a note that settings can now be accessed via the application preferences and add an "Adjust Your Tor Network Settings" action button which opens about:preferences#tor.

Replace the Tor Browser 8.5 "update" onboarding tour with a 9.0 one that includes the revised "Tor Network" page and a revised "Toolbar" page. The latter explains that Torbutton's toolbar item has been removed ("Goodbye Onion Button") and explains how to access the New Identity feature using the hamburger menu and new toolbar item.

Also added 'New circuit for this site' button to CustomizableUI, but not visible by default.

Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected.

A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser.

Patching AboutNewTabService so that AboutNewTab is not loaded to avoid several network requests that we do not need. Besides, about:newtab will now point to about:blank or about:tor (depending on browser.newtabpage.enabled) and about:home will point to about:tor.

On Linux and Windows, arrange for the updater to remove the old meek and moat http helper profiles by adding appropriate directives to browser/installer/removed-files.in (on macOS, the cleanup will be done by Tor Launcher).

The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data.

This reverts commit 057fe36fc6f3e93e265505c7dcc703a0941778e2.

We don't use the maintenance service and don't want to have parts of it now included in our updater code. This commit fixes TaskUpdater
Back out or modify patches for Mozilla's bug 1574980bug 31547 for esr68.

There are no default obfs3 bridges remaining after Linus' ones are gone. Remove the UI and localization.

Prior to this patch, TBA was showing onion services as insecure connection and SSL/TLS ones as encrypted connections(lock icon).

This patch fixes the issue adding several new onion icons to indicate all the various permutations of onions services hosted HTTP or HTTPS pages.

Also: AndroidBug
TBA - NPE in ChangeOnionAlphaRunnableBug 30214 - Kill background thread when Activity is null AndroidBug
TBA: Gracefully handle auto-restart after crashBug 30239 - Render Fragments after crash AndroidBugUX
Clicking on cog/gear icon crashes Tor Browser for AndroidBug 29982 - Force single-pane UI on Tor Preferences

Also: AndroidFeature
Build Orbot into TBABug 28051 - Launch Orbot if it isn't running in the background

AndroidFeatureUX
Design TBA+Orbot configuration UI/UXBug 28329 - Part 2. Implement checking if the Tor service is running

AndroidFeatureUX
Design TBA+Orbot configuration UI/UXBug 28329 - Part 3. Remove OrbotActivity dependency

AndroidFeature
Build Orbot into TBABug 28051 - Stop the background service when we're quitting

If the user swips away the app, then initiate quitting as if the user selected Quit from the menu.

• FirstrunTorPagerConfig.java: Create file that sets up all the views in the pager.

• FirstrunPager.java: Update code to use the FirstrunTorPagerConfig.

• FirstrunLastPanel.java: Create view that adds a close handler in the latest pager view.

Also: AndroidBugUX
Design of alpha onboarding for Tor Browser for AndroidBug 25696 - Design of alpha onboarding for Tor Browser for Android TorBrowserTeam201812Rcomponent::community/translationsowner::tbb-teamparent::26782priority::mediumresolution::fixedseverity::normalstatus::closedtbb-localizationtype::defect
Remove superfluous strings on tba-android_stringsdtd branchBug 27125 - Move localized Tor Browser for Android strings into separate file

These configure options should be false already, because we set |--without-google-play-services| in .mozconfig-android. But, this is another layer of certainty.

Picasso, the image retrieval library used by Fennec, ignores the network proxy configuration. We override the openConnection() method and create the connection using the configured proxy.

App stores such as Google Play or F-Droid have their own update service.

The Fennec UpdateService should be used just when the user installs it by themselves.

Signed-off-by: Amogh Pradeep <amoghbl1@gmail.com>

Also: AndroidBugDisk Leak
TBA: Set privacy preferencesBug 28507: Implement fallback to delete private data in the browser startup

When the TBA is forcefully closed, its private data is not deleted, even if the history.clear_on_exit is set.

As fallback, this patch calls the Sanitize:ClearData event in the browser startup to clean the private data if needed.

Signed-off-by: Amogh Pradeep <amoghbl1@gmail.com>

Signed-off-by: Amogh Pradeep <amoghbl1@gmail.com>

The browser should not need information related to the network interface or network state, tor should take care of that.

Adjust the Top Sites shown when a user taps on the URL bar.

Signed-off-by: Amogh Pradeep <amoghbl1@gmail.com>

This includes: Telemetry Geo-Location (Wi-Fi, Cellular location data, etc) Health Report

Do not delete downloaded files on exit.

These correspond with (in order): private.data.openTabs private.data.history private.data.searchHistory private.data.downloadFiles private.data.formdata private.data.cookies_sessions private.data.cache private.data.offlineApps private.data.siteSettings private.data.syncedTabs

Only require the {ACCESS,CHANGE}_WIFI_STATE and ACCESS_NETWORK_STATE permissions if MOZ_ANDROID_NETWORK_STATE is defined in the preprocessor.

Also: AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Conditionally require *_LOCATION permissions

Only require the {FINE,COURSE}_LOCATION permissions if MOZ_ANDROID_LOCATION is defined in the preprocessor. Also include location features (with gps).

AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Move CAMERA permission within MOZ_WEBRTC

Require the CAMERA permissions if MOZ_WEBRTC is defined in the preprocessor.

AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Only include GCM permissions if we want them

AndroidTask
TBA - Does the app need the SYSTEM_ALERT_WINDOW permission?Bug 26826 - Disable tab queue and delete SYSTEM_ALERT_WINDOW permission

AndroidTask
Review all requested and required Android permissionsBug 24796 - Comment out excess permissions from GeckoView

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.

This is another accessibility and usability concern, so we allow this as an opt-in.

Deactivating this is an accessibility concern because this is used for voice dictation, so users should have the option of re-enabling this.

This uses the Android Speech API.

We don't want this while the Sync subsystem is a proxy-bypass risk. We can drop this when the feature is patched (RESOLVED INCOMPLETE, Blocks: 1357994, [tor-mobile]
Make AccountManager related code pref-ableBug 1314778).

Signed-off-by: Amogh Pradeep <amoghbl1@gmail.com>

Also: AndroidBugDisk Leak
TBA: Set privacy preferencesBug 28507 - Don't call Push and Sync services during Sanitize AndroidBug
Tor Browser for Android: Sync Sign-In Button crashesBug 30086 - Prevent Sync-related crashes on Android AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Only include Firefox Account permissions if we want them (using MOZ_ACCOUNT) AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Neuter Firefox Accounts

MOZ_NATIVE_DEVICES for casting and the media player MOZ_TELEMETRY_REPORTING for telemetry MOZ_DATA_REPORTING for all data reporting preferences (crashreport, telemetry, geo)

Based on Orfox initial commits with fixup commits squashed and rebranding Orfox -> Tor Browser

See original source from ce3fab3c90eb4a3892181ee36b037da04c785d99 https://github.com/guardianproject/tor-browser.git

Dropped symlinks

Also: TorBrowserTeam201812Rcomponent::community/translationsowner::tbb-teamparent::26782priority::mediumresolution::fixedseverity::normalstatus::closedtbb-localizationtype::defect
Remove superfluous strings on tba-android_stringsdtd branchBug 27125 - Move localized Tor Browser for Android strings into separate file AndroidPlatform ParityTaskUX
Update Tor Browser Icon for AndroidBug 28622: Update Tor Browser icon for mobile AndroidFeature
TBA: Add export MOZILLA_OFFICIALBug 27472 - Export MOZILLA_OFFICIAL during Android build AndroidBugPlatform Parity
Decide whether to use "Tor Browser" or "Tor Browser for Android" for mobile stableBug 30136: Use 'Tor Browser' as brand name on mobile, too

AndroidBug
TBA: Implement about:torBug 27111: Configure tor browser for mobile to load about:tor

• Add preferences.json: it is used to configure android specific preferences

• Keep the ActivityStream HomePager closed when the user clicks in the url bar

Otherwise the preprocessor is sad because MOZ_ANDROID_GCM_SENDERID is not defined. We don't need any of this, so we exclude it.

When the stumbler service is ifdef-disabled because MOZ_ANDROID_MLS_STUMBLER is not defined, then the unit test compilation fails because some values are never declared and defined. We exclude all testStumbler*.java files from the robocop gecko test source tree.

See RESOLVED FIXED(Fx55), Blocks: 1357994, [tor-mobile]
Replace url.openConnection with ProxySelector.openConnectionWithProxyBug 1357997 for partial uplift.

Also: AndroidFeature
Build Orbot into TBABug 28051 - Use our Orbot for proxying our connections

Proxy BypassTask
ESR68 Network Code ReviewBug 31144 - ESR68 Network Code Review

Changed the anchor to toolbarbutton's anonymous child toolbarbutton-icon xul:image element so that the security level panel has the same vertical alignment as other built-in toolbar buttons. Also needed to add the badged-button class to our toolbar button for this to align properly.

Now setting and deleting the "open" attribute from the toolbarbutton element so that it maintains the "pushed" style while the security level panel is open.

Changed the toolbarbutton's oncommand callback to onmousedown to match the behaviour of firefox's other toolbarbuttons. Security level panel now opens on mouse press rather than on mouse press and release.

Slightly re-arranged the ordering of the SecurityLevelPanel object's method definitions so that callbacks appear in a contiguous block to better match the other objects defined in securityLevel.js

Removed unnecessary async modifier from SecurityLevelPanel.openAdvancedSecuritySettings().

Fixed a few typos, improved comments, and removed trailing whitespace.

It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil.

Add an "update" tour for the Tor Browser 8.5 release that contains two panels: Toolbar and Security (with appropriate description text and images).

Display an attention-grabbing dot on the onboarding text bubble when the update tour is active. The animation lasts for 14 seconds.

Instead of using a simple <a href>, programmatically open onboarding web pages by using tabBrowser.addTab(). The same technique is now used for "See My Path", "See FAQs", and "Visit an Onion".

Add an "Explore" button to the "Circuit Display" panel within new user onboarding which opens the DuckDuckGo .onion and then guides users through a short circuit display tutorial.

Allow a few additional UITour actions while limiting as much as possible how it can be used.

Tweak the UITour styles to match the Tor Browser branding.

All user interface strings are retrieved from Torbutton's browserOnboarding.properties file.

Reuse the Firefox onboarding mechanism with minimal changes. Localizable strings are pulled in from Torbutton (if Torbutton is not installed, we lack about:tor and no tour will be shown). Replace SVG images with PNGs (see BackportBug
always allow SVGs on about:* pagesbug 27002), For defense in depth, omit include OnboardingTelemetry.jsm entirely. Added support for the following UITour page event: torBrowserOpenSecuritySettings

Also fix Bug
The onboarding bubble does not show up in the release candidate for Tor Browserbug 27403: the onboarding bubble is not always displayed.

Arthur suggested to make the onboarding bubble visible on displays with less than 960px width available, so we choose 200px instead.

Also fix BugUX
Introduce New Security Settings to usersbug 28628: Change onboarding Security panel to open new Security Level panel.

Also fix BugUX
Onboarding: unintuitive not-navigation buttons, starting with "Circuit Display" / "See My Path"bug 27484: Improve navigation within onboarding.

This reverts commit f7ffd78b62541d44d0102f8051d2f4080bdbc432.

Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine.

Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services:

• HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure
• HTTP Onion Service pages would be marked as unencrypted in the Page Info screen
• Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content

This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.

Strings for Onion Service Page Info page are pulled from Torbutton's localization strings.

This patch adds a new 'securitylevel' component to Tor Browser intended to replace the torbutton 'Security Slider'.

This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.

Strings used by this patch are pulled from the torbutton extension, but en-US defaults are provided if there is an error loading from the extension. With this patch applied, the usual work-flow of "./mach build && ./mach run" work as expected, even if the torbutton extension is disabled.

• Updated all of the branding in /browser/branding/official with new 'stable' icon series.
• Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory
• Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654)
• Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory
• Updated content/identity-icons-brand.svg with Tor Browser icon (fixes #28111)
• Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico)
• Added default256.png and default512.png icons
• Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon
• Use the Tor Browser icon within devtools/client/themes/images/.

Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.

Disallow access to UITour functionality from all pages other than about:home, about:newtab, and about:tor. Implement a whitelist mechanism for page actions.

We need to have new MAR singning keys for our watershed update: both keys we shipped so far need to get replaced by news ones, now using SHA-384 as their hash algorithm.

Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS.

The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height only and only if the frame is outside the chrome.

Only ship the pdfjs extension.

In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's RESOLVED FIXED(Fx52), Blocks: 1299627, 1299694, 1528884
Remove MOZ_EME build option and make EME disabled by preferences.bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.

In Mozilla RESOLVED FIXED(Fx53), Blocks: 1313097
Build of Firefox Aurora 52.0b2 fails on CentOS 6 with '--enable-default-toolkit=cairo-gtk2'bug 1324780, support for building with glib 2.28 (the version available in CentOS 6) was added. However we are building on Debian Wheezy which has glib 2.32. We fix that by backing out all glib > 2.28 code paths.

This is due to an improper implementation of the WebSocket spec by Mozilla.

"There MUST be no more than one connection in a CONNECTING state. If multiple connections to the same IP address are attempted simultaneously, the client MUST serialize them so that there is no more than one connection at a time running through the following steps.

If the client cannot determine the IP address of the remote host (for example, because all communication is being done through a proxy server that performs DNS queries itself), then the client MUST assume for the purposes of this step that each host name refers to a distinct remote host,"

https://tools.ietf.org/html/rfc6455#page-15

They implmented the first paragraph, but not the second...

While we're at it, we also prevent the DNS service from being used to look up anything other than IP addresses if socks_remote_dns is set to true, so this bug can't turn up in other components or due to 3rd party addons.

eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed.

Also: FeatureUX
Use duckduckgo hidden service instead of clearnet oneBug 16322: Update DuckDuckGo search engine

We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to VERIFIED FIXED(Fx36), Blocks: 1073292
Add DuckDuckGo to default search engine listbug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well.

Also: This fixes FeatureUX
Use non-/html search engine URL for DuckDuckGo search pluginsbug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly.

Also fixes Bug
build1 for Tor Browser 8.5a9 is broken in mobile packaging stepbug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for.

Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release).

Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts.

Also fix TaskUXUpdater
Update about:tor when Tor Browser is updatedbug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor.

Configure with --enable-signmar (build the signmar tool). Configure with --enable-verify-mar (when updating, require a valid signature on the MAR file before it is applied). Use the Tor Browser version instead of the Firefox version inside the MAR file info block (necessary to prevent downgrade attacks). Use NSS on all platforms for checking MAR signatures (instead of using OS-native APIs, which Mozilla does on Mac OS and Windows). So that the NSS and NSPR libraries the updater depends on can be found at runtime, we add the firefox directory to the shared library search path on macOS. On Linux, rpath is used by Mozilla to solve that problem, but that approach won't work on macOS because the updater executable is copied during the update process to a location that is under TorBrowser-Data, and the location of TorBrowser-Data varies.

Also includes the fix for Bug
TB 6.0a5: updater doesn't work on Linux (cannot find libraries)bug 18900.

New configure options: --with-tor-browser-version=VERSION # Pass TB version throughout build (required). --enable-tor-browser-update # Enable bundle update behavior (optional). The following files are never updated: TorBrowser/Data/Browser/profiles.ini TorBrowser/Data/Browser/profile.default/bookmarks.html TorBrowser/Data/Tor/torrc Mac OS: Store update metadata under TorBrowser/UpdateInfo. Removed the %OS_VERSION% component from the update URL (13047) and added support for minSupportedOSVersion, an attribute of the <update> element that may be used to trigger Firefox's "unsupported platform" behavior. Hide the "What's new" links (removed app.releaseNotesURL preference value). Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.

Also fix Bug
consider reducing the delay before the update prompt is displayed (ESR60)Bug 26049: reduce the delay before the update prompt is displayed. Instead of Firefox's 2 days, we use 1 hour (after which time the update doorhanger will be displayed).

Also fix Bug
Tor Browser 8.0a10 wants to update to 8.0a10bug 27221: purge the startup cache if the Tor Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Tor Browser update.

Also fix 27828: "Check for Tor Browser update" doesn't seem to do anything.

squash! SecurityTaskUX
Deploy experimental builds using the Firefox update processBug 4234: Use the Firefox Update Process for Tor Browser.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122.

Revert the nsUpdateService.js changes from Mozilla RESOLVED FIXED(Fx43)
main thread I/O in update serviceBug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)."

Changes to the tests were not reverted; the tests have been changed significantly and we do not run automated updater tests for Tor Browser at this time.

We kept the addition to the AppConstants API in case other JS code references it in the future.

Revert most changes from Mozilla RESOLVED FIXED(Fx56)
Remove hashFunction and hashValue attributes from nsIUpdatePatch and code related to these valuesBug 1373267 "Remove hashFunction and hashValue attributes from nsIUpdatePatch and code related to these attributes." Changes to the tests were not reverted; the tests have been changed significantly and we do not run automated updater tests for Tor Browser at this time.

Add an --enable-tor-browser-data-outside-app-dir configure option. When this is enabled, all user data is stored in a directory named TorBrowser-Data which is located next to the application directory.

Display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error.

On Mac OS, add support for the --invisible command line option which is used by the meek-http-helper to avoid showing an icon for the helper browser on the dock.

When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser.

Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior.

This should eliminate our need to rely on a wrapper script that sets /Users/arthur and launches Firefox with -profile.

By setting the URL to "" we make sure that already installed system addons get deleted as well.

When handling an external URI or downloading a file, invoke Torbutton's external app blocker component (which will present a download warning dialog unless the user has checked the "Automatically download files from now on" box).

For e10s compatibility, avoid using a modal dialog and instead use a callback interface (nsIHelperAppWarningLauncher) to allow Torbutton to indicate the user's desire to cancel or continue each request.

Other bugs fixed: Bug
Tor Browser based on ESR52 with e10s enabled crashed while trying to download a fileBug 21766: Crash with e10s enabled while trying to download a file BugUX
Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s offBug 21886: Download is stalled in non-e10s mode Bug
Downloading pdf files with the download button in the pdf viewer is stallingBug 22471: Downloading files via the PDF viewer download button is broken Bug
Handle downloads via FTP better when external helper app dialog is shownBug 22472: Fix FTP downloads when external helper app dialog is shown Bug
Tor Browser 7 crashes when cancelling downloads on the external helper app warningBug 22610: Avoid crashes when canceling external helper app downloads Bug
Downloading pdf file via file:/// is stalling if the external helper dialog is enabledBug 22618: Downloading pdf file via file:/// is stalling

Instead of using the local computer's IP address within symlink-based profile lock signatures, always use 127.0.0.1.

See also Bugs #5194, #7187, #8115, #8219.

This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons.

Also fix BugUX
many occurrences of "Firefox" in about:preferencesbug 27905.

To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts.

Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system".

It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.

This is technically an embargoed Mozilla bug, so I probably shouldn't provide too many details.

Suffice to say that NTLM and Negotiate auth are bad for Tor users, and I doubt very many (or any of them) actually need it.

The Mozilla bug is https://bugzilla.mozilla.org/show_bug.cgi?id=1046421

We do not want to encourage our users to enable plugins at this point.

The barrier also causes bad UX for HTML5 video fallback on YouTube.

We cannot use the @mozilla.org/extensions/blocklist;1 service, because we actually want to stop plugins from ever entering the browser's process space and/or executing code (for example, AV plugins that collect statistics/analyse urls, magical toolbars that phone home or "help" the user, skype buttons that ruin our day, and censorship filters). Hence we rolled our own.

See https://trac.torproject.org/projects/tor/ticket/3547#comment:6 for musings on a better way. Until then, it is delta-darwinism for us.

Feature
Circuit display - Let's remove link from the Tor ButtonBug 26321: New Circuit and New Identity menu items

Because of the non-restartless nature of Torbutton, it required a two-stage installation process. On mobile, it was a problem, because it was not loading when the user opened the browser for the first time.

Moving it to tor-browser and making it a system extension allows it to load when the user opens the browser for first time.

Additionally, this patch also fixes AndroidBug
Restart Gecko after first-runBug 27611.

Build and package Tor Launcher as part of the browser (similar to how pdfjs is handled).

The --disable-tor-launcher build option may be used to omit Tor Launcher.

If a Tor Launcher extension is present in the user's profile, it is removed.

Mozilla introduced extension signing as a way to make it harder for an attacker to get a malicious add-on running in a user's browser. See: https://blog.mozilla.org/addons/2015/02/10/extension-signing-safer-experience and https://blog.mozilla.org/addons/2016/01/22/add-on-signing-update/ for some background information.

Since ESR45 this feature is enabled by default and we exempt EFF's HTTPS-Everywhere from this requirement.

Note: many more functional tests could be made here

This hack directly includes our preference changes in omni.ja.

Apps::Impact::NoneApps::Type::BugBugDesktopRoadmap::FutureUpdaterWindows
staged updates fail on WindowsBug 18292: Staged updates fail on Windows

Temporarily disable staged updates on Windows.

BugFingerprinting
Tor browser uses Chinese-style glyphs to display JapaneseBug 18297: Use separate Noto JP,KR,SC,TC fonts

BugFingerprinting
Noto Sans Buginese missing from macOS font whitelistBug 23404: Add Noto Sans Buginese to the macOS whitelist

Bug
Tab crashes when using Tor Browser to access Google DriveBug 23745: Set dom.indexedDB.enabled = true

BugFingerprintingFirst Contribution
Disable randomised Firefox HTTP cache decay user test groupsBug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)

FeatureLinkabilityPerformance
Confirm TLS session resumption/ID are isolated to the URL bar domain, and re-enable themBug 17252: Enable session identifiers with FPI

Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".

The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)

LinkabilityPerformanceTaskUX
Audit HTTP/2 and SPDY if neededBug 14952: Enable http/2 and AltSvc

In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".

Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.

(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)

However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.

"network.http.spdy.enabled.http2draft" was removed in RESOLVED FIXED(Fx41), [spdy]
remove h2-draft support starting in gecko-40Bug 1132357. "network.http.sped.enabled.v2" was removed in VERIFIED FIXED(Fx27)
remove spdy/2 supportBug 912550. "network.http.sped.enabled.v3" was removed in RESOLVED FIXED(Fx36), spdy
kill spdy/3Bug 1097944. "network.http.sped.enabled.v3-1" was removed in RESOLVED FIXED(Fx51), Blocks: 912549, [necko-active]
remove spdy/3.1 supportBug 1248197.

FingerprintingTask
Adapt to upstreamed AddonManager changesBug 26114: addons.mozilla.org is not special

• Don't expose navigator.mozAddonManager on any site
• Don't block NoScript from modifying addons.mozilla.org or other sites

Enable ReaderView mode again (#27281).

BugProxy Bypass
Group Policies for Firefox can bypass Tor Browser's proxy settingsBug 29916: Make sure enterprise policies are disabled

MikePerry201408RMikePerryIterationFires20110529actualpoints::1backport-to-mozillacomponent::firefox patch issuesowner::mikeperrypoints::4priority::mediumresolution::fixedseverity::blockerstatus::closedtbb-no-uplift-60type::enhancement
Block access to Components.interfaces from content scriptBug 2874: Block Components.interfaces from content

BugBugSmashFundFingerprinting
Setting general.useragent.override does not spoof the platform part anymore in ESR 60 which is confusingBug 26146: Spoof HTTP User-Agent header for desktop platforms

In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.

BugUX
Windows Jump Lists fail for Tor BrowserBug 12885: Windows Jump Lists fail for Tor Browser

Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations
and has a name in the form [a-f0-9]+.customDestinations-ms

The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.

However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.

The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.

Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See Apps::Impact::MinimalApps::Type::BugBugDisk LeakRoadmap::FutureWindows
Tor Browser on Windows creates a file in %APPDATA%\Microsoft\Windows\Recent\CustomDestinations containing the Tor Browser install locationbug 28996.

Bug
Communication with noscript for security settings not working in nightliesBug 31396: Disable indexedDB WebExtension storage backend.

Bug
Make sure default Firefox themes are enabled on ESR68Bug 30845: Make sure default themes and other internal extensions are enabled

Task
Make sure our bundled WebExtensions are running in Private Browsing ModeBug 28896: Enable extensions in private browsing by default

BugBugSmashFund
Set network.proxy.allow_hijacking_localhost to trueBug 31065: Explicitly allow proxying localhost

Bug
Properly enable letterboxing (again)Bug 31598: Enable letterboxing

Disable Presentation API everywhere

squash! component::mixminion-clientowner::nickmpriority::lowresolution::fixedseverity::blockerstatus::closedtype::defectversion::0.0.4
Incorrect node routing with mboxTB4: Tor Browser's Firefox preference overrides.

BugSmashFundTask
Investigate wasm for linkability/fingerprintability/disk avoidance issuesBug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels.

squash! component::mixminion-clientowner::nickmpriority::lowresolution::fixedseverity::blockerstatus::closedtype::defectversion::0.0.4
Incorrect node routing with mboxTB4: Tor Browser's Firefox preference overrides.

BugLinkability
https://mitmdetection.services.mozilla.com/ is contacted over catch-all circuitBug 32321: Disable Mozilla's MitM pings

Also: MikePerry201312Rcomponent::applications/tor bundles/installationff24-esrowner::erinnparent::10103priority::mediumresolution::fixedstatus::closedtbb-3.0type::defect
Firefox ESR 24 does need a newer compiler than gcc 4.2Bug #9829.1: new .mozconfig file for the new cross-compiler and ESR24 Changes needed to build Mac in 64bit component::applications/tor bundles/installationowner::erinnparent::12460priority::mediumresolution::fixedstatus::closedtbb-3.5tbb-usabilitytype::defect
Cross-Compiling WebGL with mingw-w64 is brokenBug 10715: Enable Webgl for mingw-w64 again. Disable ICU when cross-compiling; clean-up. Bug
Enable ICU for OS X Tor Browser buildsBug 15773: Enable ICU on OS X Task
Get Windows cross-compilation working with Fx38 in GitianBug 15990: Don't build the sandbox with mingw-w64 Task
Switch to OS X 10.7 SDK in our Tor Browser Mac buildsBug 12761: Switch to ESR 38 for OS X Updating .mozconfig-asan FeatureSecurity
Compile Tor Browser with -fwrapv/-fno-strict-overflowBug 12516: Compile hardenend Tor Browser with -fwrapv Task
Update OS X toolchain to work with ESR 45Bug 18331: Switch to Mozilla's toolchain for building Tor Browser for OS X BugSecurity
Creating incremental MAR files for the hardened builds is brokenBug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Task
Fix cross-compiling ICU with mingw-w64 for Windows buildsBug 13419: Add back ICU for Windows Bug
Adapt Linux Firefox descriptor for ESR 52Bug 21239: Use GTK2 for ESR52 Linux builds Bug
Flags to increase hardening on macOSBug 23025: Add hardening flags for macOS Bug
Enable tests and debug assertions in our ASan buildsBug 24478: Enable debug assertions and tests in our ASan builds --enable-proxy-bypass-protection Bug
ASan build option in tor-browser-build is brokenBug 27597: ASan build option in tor-browser-build is broken

Bug
wrong default pref values in Tor Browser 8.0Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds

This fixes a problem where some preferences had the wrong default value. Also see AndroidFeature
TBA: Add export MOZILLA_OFFICIALbug 27472 where we made a similar fix for Android.

BugSmashFundTask
Make sure telemetry reporting is disabled in Tor Browser 9Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING

BugBugSmashFund
Still use GCC for 64bit Linux debug builds after switch to 68 ESRBug 31450: Set proper BINDGEN_CFLAGS for ASan builds

This reverts commit a3f466a3ac73f0d11f3f3ba054173087e66a0ab5.

This reverts commit 303c1ef548d23dfd0d8aa1e9e61481c1baea02a8.

This reverts commit a7cc5967877636728e29ea865dc46a2889b7de58.

This reverts commit 1c54037a5bb7ded841b5a795041772a4571944f9.

This reverts commit 896fa0df588de10b22e827b8f9999c69daa9e05d.

This reverts commit ab8797462cefdaf99d10e1981f2a168750cc697a.

This reverts commit 484ec9407da4234000a73d2426f09de62de0274e.

This reverts commit cfd50aaa49884bc57315b7eab00a1c9ba7b5b0c1.

This reverts commit 400e38b7d39b9f4abc487bd1431df52889bf05d5.

This reverts commit 87e62440c6d114daf54ef2e323f92c274369f424.

This reverts commit 334f572f8b2113c464bd65e1282b7085a1dfb5eb.