Uplift Bug |
Tags |
Commit |
build |
Description |
B |
T |
M |
- NEW, Blocks: 1958496, 1407366, [tor 32220]
Change the letterboxing background to match the theme, and reposition the contentBug 1594455
|
u |
7c8c24f2
|
|
1 |
|
BugUX
Change letterboxing color when dark theme is enabledBug 32220: Improve the letterboxing experience
CSS and JS changes to alter the UX surrounding letterboxing. The browser element containing page content is now anchored to the bottom of the toolbar, and the remaining letterbox margin is the same color as the firefox chrome. The letterbox margin and border are tied to the currently selected theme.
Also adds a 'needsLetterbox' property to tabbrowser.xml to fix a race condition present when using the 'isEmpty' property. Using 'isEmpty' as a proxy for 'needsLetterbox' resulted in over-zealous/unnecessary letterboxing of about:blank tabs. Author: Richard Pospesel, 2019-10-28 17:42:17 -0700
Committer: Matthew Finkel, 2021-03-17 23:41:23 +0000
|
- NEW, Blocks: 1674565, [tor 27604]
After restoring profile to a different location, paths in extensions.json are incorrectBug 1429838
|
u |
9f526f61
|
|
1 |
|
Bug
Relocating the Tor Browser directory is broken with Tor Browser 8Bug 27604: Fix addon issues when moving TB directory
Author: Alex Catarineu, 2019-10-30 10:44:48 +0100
Committer: Matthew Finkel, 2021-03-17 23:41:22 +0000
|
- UNCONFIRMED, Blocks: 1958496, [fingerprinting] [gfx-noted] [fp-triaged] [tor 30541]
Apply Resist Fingerprinting Protection to WebGL's readPixels methodBug 1428034
|
u |
2659c9c8
|
|
1 |
|
BugFingerprinting
webgl readPixels FP entropyBug 30541: Disable WebGL readPixel() for web content
Author: Georg Koppen, 2019-05-29 12:29:19 +0000
Committer: Matthew Finkel, 2021-03-17 23:41:17 +0000
|
|
u |
b8a7ec28
|
|
1 |
|
BugLinkability
First request after copying and pasting an URL in URL bar seems to go over the catch-all circuitBug 26353: Prevent speculative connect that violated FPI.
Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term. Author: Arthur Edelstein, 2018-07-14 08:50:55 -0700
Committer: Matthew Finkel, 2021-03-17 23:41:15 +0000
|
- REOPENED, Blocks: 335545, [tor 21830]
Copying large text from web console leaks to /tmpBug 1433030
- RESOLVED FIXED(Fx107), Blocks: 1123480, [tor 21830]
nsTransferable disk-leaks when private browsing mode is enabled by defaultBug 1768907
|
u |
df221f10
|
|
1 |
|
BugDisk Leak
Copying large text from web console leaks to /tmpBug 21830: Copying large text from web console leaks to /tmp
Patch written by Neill Miller Author: Georg Koppen, 2017-08-04 05:55:49 +0000
Committer: Matthew Finkel, 2021-03-17 23:41:14 +0000
|
- NEW, [tor 16439]
add flag to drop screensharing from buildBug 1432684
|
u |
d0d75436
|
|
1 |
|
Bug
remove screencasting codeBug 16439: Remove screencasting code
We avoid including the screencasting code on mobile (it got ripped out for desktop in RESOLVED FIXED(Fx57), Blocks: 1360406
Remove CastingApps supportbug 1393582) by simply excluding the related JS modules from Tor Browser. Author: Kathy Brade, 2015-06-24 11:01:11 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:03 +0000
|
|
|
252c0411
|
|
3 |
|
fixup! BugBugSmashFundPlatform ParityUX
Integrate TorButton to TorBrowser core to prevent users from disabling itBug 10760: Integrate TorButton to TorBrowser core
Author: Matthew Finkel, 2021-03-25 17:33:07 +0000
Committer: Matthew Finkel, 2021-03-25 17:33:07 +0000
|
3538764d
|
|
2 |
|
fixup! BugBugSmashFundPlatform ParityUX
Integrate TorButton to TorBrowser core to prevent users from disabling itBug 10760: Integrate TorButton to TorBrowser core
Author: Matthew Finkel, 2021-03-22 20:46:24 +0000
Committer: Matthew Finkel, 2021-03-22 20:46:24 +0000
|
f48395b0
|
|
1 |
|
BugBugSmashFundPlatform ParityUX
Integrate TorButton to TorBrowser core to prevent users from disabling itBug 10760: Integrate TorButton to TorBrowser core
Because of the non-restartless nature of Torbutton, it required a two-stage installation process. On mobile, it was a problem, because it was not loading when the user opened the browser for the first time.
Moving it to tor-browser and making it a system extension allows it to load when the user opens the browser for first time.
Additionally, this patch also fixes AndroidBug
Restart Gecko after first-runBug 27611.
Feature
Circuit display - Let's remove link from the Tor ButtonBug 26321: New Circuit and New Identity menu items
BugUX
about:tor should behave more like about:newtabBug 14392: Make about:tor behave like other initial pages.
AndroidBug
Move TorButton code to the tor browser repositoryBug 25013: Add torbutton as a tor-browser submodule Author: Alex Catarineu, 2020-02-19 23:05:08 +0100
Committer: Matthew Finkel, 2021-03-17 23:41:01 +0000
|
- RESOLVED WONTFIX, [tor 40166]
Add a check to clear security.enterprise_roots.enabled when it was auto enabled and security.certerrors.mitm.auto_enable_enterprise_roots is falseBug 1768899
|
|
bac3fcf5
|
|
1 |
|
BackportDoing
Disable security.certerrors.mitm.auto_enable_enterprise_rootsBug 40166: Disable security.certerrors.mitm.auto_enable_enterprise_roots
Author: Alex Catarineu, 2020-10-09 12:55:35 +0200
Committer: Matthew Finkel, 2021-03-17 23:44:19 +0000
|
|
|
45724d03
|
|
1 |
|
Doing
78.4.0esr-based build is busted on LinuxBug 40193: Add AT_EMPTY_PATH definition
AT_EMPTY_PATH comes with glibc 2.14. However, Debian Wheezy, which we still use for building our stable Linux bundles, comes only with glibc 2.13 resulting in an "undeclared-identifier"-error during build time.
This problem got introduced by fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1660901. Author: Georg Koppen, 2020-10-16 08:47:05 +0000
Committer: Matthew Finkel, 2021-03-17 23:43:03 +0000
|
|
c |
4e82e7b9
|
|
1 |
|
VERIFIED FIXED(Fx82), [fingerprinting][reporter-external] [client-bounty-form] [verif?][post-critsmash-triage][adv-main82+]
[VG-VD-20-115] Leaking External URL protocol handler presence through image tagsBug 1658881 - When failing to create a channel and an image request, make sure to set the image blocking status appropriately. r=tnikkel
This is the same status as we do for known no-data protocols here:
https://searchfox.org/mozilla-central/rev/ac142717cc067d875e83e4b1316f004f6e063a46/dom/base/nsNoDataProtocolContentPolicy.cpp#59
This ensures we treat these two cases the same.
Differential Revision: https://phabricator.services.mozilla.com/D89382 Author: Emilio Cobos Álvarez, 2020-09-09 22:58:29 +0000
Committer: Matthew Finkel, 2021-03-17 23:43:02 +0000
|
|
|
7a3323a7
|
|
1 |
|
Needs Review
Move HTTPS Everywhere into omni.jaBug 40091: Load HTTPS Everywhere as a builtin addon in desktop
This loads HTTPS Everywhere as a builtin addon from a hardcoded resource:// URI in desktop. It also ensures that the non-builtin HTTPS Everywhere addon is always uninstalled on browser startup.
The reason of making this desktop-only is that there are some issues when installing a builtin extension from geckoview side, making the extension not available on first startup. So, at least for now we handle the Fenix case separately. See #40118 for a followup for investigating these. Author: Alex Catarineu, 2020-09-04 12:34:35 +0200
Committer: Matthew Finkel, 2021-03-17 23:43:02 +0000
|
|
c |
41374666
|
|
1 |
|
VERIFIED FIXED(Fx80)
browser.privatebrowsing.forceMediaMemoryCache breaks mp4 video siteBug 1650281 - P2: Make sure gCombinedSizes won't be underflowed r=gerald
In any case, gCombinedSizes should be larger than or equal to the buffer within MemoryClockCache .
Differential Revision: https://phabricator.services.mozilla.com/D84274 Author: Chun-Min Chang, 2020-07-21 23:39:14 +0000
Committer: Matthew Finkel, 2021-03-17 23:43:02 +0000
|
701d7cd6
|
|
1 |
|
VERIFIED FIXED(Fx80)
browser.privatebrowsing.forceMediaMemoryCache breaks mp4 video siteBug 1650281 - P1: Widen gCombinedSizes once the buffers grow r=gerald
The gCombinedSizes need to be enlarged once the inner buffer within MemoryBlockCache grows. Otherwise, when the MemoryBlockCache is released, subtracting the buffer-size of the MemoryBlockCache from gCombinedSizes lead to a underflow.
Differential Revision: https://phabricator.services.mozilla.com/D84273 Author: Chun-Min Chang, 2020-07-21 23:38:57 +0000
Committer: Matthew Finkel, 2021-03-17 23:43:01 +0000
|
|
|
42fa04f1
|
|
1 |
|
Consider disabling about:pioneerBug 40002: Remove about:pioneer
Firefox Pioneer is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser. Author: Kathy Brade, 2020-08-14 09:06:33 -0400
Committer: Matthew Finkel, 2021-03-17 23:43:01 +0000
|
|
|
b35f8e02
|
|
1 |
|
Doing
Consider disabling remote Public Suffix List fetchingBug 40073: Disable remote Public Suffix List fetching
In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want. Author: Alex Catarineu, 2020-08-13 11:05:03 +0200
Committer: Matthew Finkel, 2021-03-17 23:43:00 +0000
|
|
|
fcbd1445
|
|
1 |
|
Revert add-on install permissions introduced in Mozilla's 1560059Bug 40025: Remove Mozilla add-on install permissions
Author: Alex Catarineu, 2020-07-27 18:12:55 +0200
Committer: Matthew Finkel, 2021-03-17 23:43:00 +0000
|
|
|
354ede1b
|
|
1 |
|
Bug
Clean up about:logins (LockWise) to avoid mentioning sync, etc.Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.
Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.
Disable the "Create New Login" button when security.nocertdb is true. Author: Kathy Brade, 2020-07-14 11:15:07 -0400
Committer: Matthew Finkel, 2021-03-17 23:42:59 +0000
|
- RESOLVED FIXED(Fx105), [tor 32418]
Add a configure flag to load policies only from the local policies.json fileBug 1769030
|
f |
9086b2ed
|
|
1 |
|
BugBugSmashFundUpdater
Torbrowser tells on every start, that it can't update although it is newestBug 32418: Allow updates to be disabled via an enterprise policy.
Restrict the Enterprise Policies mechanism to only consult a policies.json file (avoiding the Windows Registry and macOS's file system attributes).
Add a few disabledByPolicy() checks to the update service to avoid extraneous (and potentially confusing) log messages when updates are disabled by policy.
Sample content for distribution/policies.json: { "policies": { "DisableAppUpdate": true } }
On Linux, avoid reading policies from /etc/firefox/policies/policies.json Author: Kathy Brade, 2020-04-16 17:07:09 -0400
Committer: Matthew Finkel, 2021-03-17 23:42:59 +0000
|
|
|
c4b3103e
|
|
1 |
|
ProjectUX
Onion-location: increasing the use of onion services through automatic redirects and aliasingBug 21952: Implement Onion-Location
Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar. Author: Alex Catarineu, 2020-03-05 22:16:39 +0100
Committer: Matthew Finkel, 2021-03-17 23:41:27 +0000
|
|
|
39597ebd
|
|
1 |
|
BugBugSmashFundHTTPS EverywhereUX
Officially support onions in HTTPS-EverywhereBug 28005: Implement .onion alias urlbar rewrites
A custom HTTPS Everywhere update channel is installed, which provides rules for locally redirecting some memorable .tor.onion URLs to non-memorable .onion URLs.
When these redirects occur, we also rewrite the URL in the urlbar to display the human-memorable hostname instead of the actual .onion.
BugUX
Update site info URL with the onion nameBug 34196: Update site info URL with the onion name Author: Alex Catarineu, 2020-02-13 13:24:33 +0100
Committer: Matthew Finkel, 2021-03-17 23:41:27 +0000
|
|
|
a4a77442
|
|
1 |
|
Bug
Disconnect search addon causes error at startupBug 33342: Avoid disconnect search addon error after removal.
We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore. Author: Alex Catarineu, 2020-03-13 18:19:30 +0100
Committer: Matthew Finkel, 2021-03-17 23:41:26 +0000
|
|
|
5b8f828c
|
|
1 |
|
AndroidBugProxy Bypass
Don't let Android leak DNS queriesBug 28125 - Prevent non-Necko network connections
Author: Matthew Finkel, 2018-10-25 19:17:09 +0000
Committer: Matthew Finkel, 2021-03-17 23:41:26 +0000
|
|
|
947c6f9d
|
|
1 |
|
AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Disable GeckoNetworkManager
The browser should not need information related to the network interface or network state, tor should take care of that. Author: Matthew Finkel, 2018-04-26 22:22:51 +0000
Committer: Matthew Finkel, 2021-03-17 23:41:25 +0000
|
|
|
7ec921ce
|
|
1 |
|
Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources.
See RESOLVED FIXED(Fx55), Blocks: 1357994, [tor-mobile]
Replace url.openConnection with ProxySelector.openConnectionWithProxyBug 1357997 for partial uplift.
Also: AndroidFeature
Build Orbot into TBABug 28051 - Use our Orbot for proxying our connections
Proxy BypassTask
ESR68 Network Code ReviewBug 31144 - ESR68 Network Code Review Author: Amogh Pradeep, 2015-06-12 02:07:45 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:25 +0000
|
|
|
2d4403a8
|
|
1 |
|
AndroidTask
Review all requested and required Android permissionsBug 24796 - Comment out excess permissions from GeckoView
The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing. Author: Matthew Finkel, 2018-04-11 17:52:59 +0000
Committer: Matthew Finkel, 2021-03-17 23:41:24 +0000
|
|
|
e3674159
|
|
1 |
|
BugSigning
Create new MAR signing key for Tor BrowserBug 32658: Create a new MAR signing key
It's time for our rotation again: Move the backup key in the front position and add a new backup key. Author: Georg Koppen, 2020-01-17 12:54:31 +0000
Committer: Matthew Finkel, 2021-03-17 23:41:24 +0000
|
|
|
b65bdbce
|
|
1 |
|
Feature
Tor Browser: Improve TBB UI of hidden service client authorizationBug 30237: Add v3 onion services client authentication prompt
When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key.
If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page.
If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt.
Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt.
Add support for onion services strings to the TorStrings module.
Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of ProjectUX
Objective 2, Activity 4: Better client-side errorsbug 30025.
Also fixes BugBugSmashFundUX
Make a menu to add onion and auth-cookie to TBbug 19757: Add a "Remember this key" checkbox to the client auth prompt.
Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk.
Also fixes FeatureUX
TorBrowser might want to have an error page specific to when .onion links failbug 19251: use enhanced error pages for onion service errors. Author: Kathy Brade, 2019-11-12 16:11:05 -0500
Committer: Matthew Finkel, 2021-03-17 23:41:23 +0000
|
|
|
0d821f19
|
|
1 |
|
Bug
Review RemoteSettings usages in esr68Bug 31740: Remove some unnecessary RemoteSettings instances
More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.
Avoid creating instance for 'anti-tracking-url-decoration'.
If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.
Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.
We also clear the collections database on the v2 -> v3 migration. Author: Alex Catarineu, 2019-10-16 23:01:12 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:22 +0000
|
|
|
62afab89
|
|
1 |
|
BugUX
Tor Browser Support should link to our support portalBug 32092: Fix Tor Browser Support link in preferences
Author: Alex Catarineu, 2019-10-15 22:54:10 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:22 +0000
|
|
|
d8d58264
|
|
1 |
|
BugSmashFundTaskUX
Include bridge configuration into about:preferencesBug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#tor
This patch adds a new about:preferences#tor page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present:
- Setting built-in bridges
- Requesting bridges from BridgeDB via moat
- Using user-provided bridges
- Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
- Setting firewall ports
- Viewing and Copying Tor's logs
- The Networking Settings in General preferences has been removed
Author: Richard Pospesel, 2019-09-16 15:25:39 -0700
Committer: Matthew Finkel, 2021-03-17 23:41:21 +0000
|
- RESOLVED FIXED(Fx82), Blocks: 1329996, [tor 13543][fingerprinting][fp-triaged]
Support Resist Fingerprinting in canPlayType and Media Capabilities APIsBug 1461454
|
f |
0d341d12
|
|
1 |
|
All PlatformsBugFingerprintingRoadmap::Future
HTML5 media support may lead to fingerprintingBug 13543: Spoof smooth and powerEfficient for Media Capabilities
Author: Alex Catarineu, 2019-10-10 15:08:12 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:21 +0000
|
- RESOLVED FIXED(Fx97), [tor 31607]
hidden window churn causes app menu to stop workingBug 1586061
|
f |
9b050342
|
|
1 |
|
BugBugSmashFund
App menu items stop workingBug 31607: App menu items stop working on macOS
Avoid re-creating the hidden window, since this causes the nsMenuBarX object that is associated with the app menu to be freed (which in turn causes all of the app menu items to stop working).
More detail: There should only be one hidden window. XREMain::XRE_mainRun() contains an explicit call to create the hidden window and that is the normal path by which it is created. However, when Tor Launcher's wizard/progress window is opened during startup, a hidden window is created earlier as a side effect of calls to nsAppShellService::GetHiddenWindow(). Then, when XREMain::XRE_mainRun() creates its hidden window, the original one is freed which also causes the app menu's nsMenuBarX object which is associated with that window to be destroyed. When that happens, the menuGroupOwner property within each Cocoa menu items's MenuItemInfo object is cleared. This breaks the link that is necessary for NativeMenuItemTarget's menuItemHit method to dispatch a menu item event. Author: Kathy Brade, 2019-10-03 10:53:43 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:20 +0000
|
|
|
b2e03ac8
|
|
1 |
|
Bug
implement new user onboardingBug 26961: New user onboarding.
Reuse the Firefox onboarding mechanism with minimal changes. Localizable strings are pulled in from Torbutton (if Torbutton is not installed, we lack about:tor and no tour will be shown). Replace SVG images with PNGs (see BackportBug
always allow SVGs on about:* pagesbug 27002), For defense in depth, omit include OnboardingTelemetry.jsm entirely. Added support for the following UITour page event: torBrowserOpenSecuritySettings
Also fix Bug
The onboarding bubble does not show up in the release candidate for Tor Browserbug 27403: the onboarding bubble is not always displayed.
Arthur suggested to make the onboarding bubble visible on displays with less than 960px width available, so we choose 200px instead.
Also fix BugUX
Introduce New Security Settings to usersbug 28628: Change onboarding Security panel to open new Security Level panel.
Also fix BugUX
Onboarding: unintuitive not-navigation buttons, starting with "Circuit Display" / "See My Path"bug 27484: Improve navigation within onboarding.
Bug
enable a limited UITourBug 27082: enable a limited UITour
Disallow access to UITour functionality from all pages other than about:home, about:newtab, and about:tor. Implement a whitelist mechanism for page actions.
Bug
implement new features onboardingBug 26962 - implement new features onboarding (part 1).
Add an "Explore" button to the "Circuit Display" panel within new user onboarding which opens the DuckDuckGo .onion and then guides users through a short circuit display tutorial.
Allow a few additional UITour actions while limiting as much as possible how it can be used.
Tweak the UITour styles to match the Tor Browser branding.
All user interface strings are retrieved from Torbutton's browserOnboarding.properties file.
BugUX
Onboarding: "Visit an Onion" creates an "about:blank" loading pageBug 27486 Avoid about:blank tabs when opening onboarding pages.
Instead of using a simple <a href>, programmatically open onboarding web pages by using tabBrowser.addTab(). The same technique is now used for "See My Path", "See FAQs", and "Visit an Onion".
Bug
Introduce new features to users in Tor BrowserBug 29768: Introduce new features to users
Add an "update" tour for the Tor Browser 8.5 release that contains two panels: Toolbar and Security (with appropriate description text and images).
Display an attention-grabbing dot on the onboarding text bubble when the update tour is active. The animation lasts for 14 seconds.
BugUX
Introduce Tor network settings and other updates in TB9 onboardingBug 31768: Introduce toolbar and network settings changes in onboarding
Update the "Tor Network" onboarding page to include a note that settings can now be accessed via the application preferences and add an "Adjust Your Tor Network Settings" action button which opens about:preferences#tor.
Replace the Tor Browser 8.5 "update" onboarding tour with a 9.0 one that includes the revised "Tor Network" page and a revised "Toolbar" page. The latter explains that Torbutton's toolbar item has been removed ("Goodbye Onion Button") and explains how to access the New Identity feature using the hamburger menu and new toolbar item.
BugUX
Add What's New Onboarding ItemBug 34321 - Add Learn More onboarding item Author: Kathy Brade, 2018-08-08 11:34:40 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:20 +0000
|
|
|
2f27d847
|
|
1 |
|
Bring back old Firefox onboarding
Revert "RESOLVED FIXED(Fx64), Blocks: 1457565, 1449052, 1453969, 1477630, 1494282, 1496721
Delete onboarding system add-onBug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson"
This reverts commit f7ffd78b62541d44d0102f8051d2f4080bdbc432.
Revert "RESOLVED FIXED(Fx64), Blocks: 1462415
Actually remove the old onboarding add-on's prefsBug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs"
This reverts commit 057fe36fc6f3e93e265505c7dcc703a0941778e2.
BugBugSmashFund
re-implement desktop onboarding for ESR 68Bug 28822: Convert onboarding to webextension
Partially revert 1564367 (controlCenter in UITour.jsm) Author: Alex Catarineu, 2019-05-29 20:04:37 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:19 +0000
|
|
|
7034e1a3
|
|
1 |
|
FeatureNew IdentityUX
Add New identity button to toolbarBug 27511: Add new identity button to toolbar
Also added 'New circuit for this site' button to CustomizableUI, but not visible by default. Author: Alex Catarineu, 2019-10-04 19:08:33 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:19 +0000
|
|
|
72506b01
|
|
1 |
|
Bug
Firefox is phoning home during start-up in Tor Browser based on ESR 68Bug 31575: Replace Firefox Home (newtab) with about:tor
Avoid loading AboutNewTab in BrowserGlue.jsm in order to avoid several network requests that we do not need. Besides, about:newtab will now point to about:blank or about:tor (depending on browser.newtabpage.enabled) and about:home will point to about:tor. Author: Alex Catarineu, 2019-09-09 13:04:34 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:18 +0000
|
|
|
f98405d1
|
|
1 |
|
BugBugSmashFund
Disable tracking protection UI in FF67-esrBug 26345: Hide tracking protection UI
Author: Alex Catarineu, 2019-09-10 16:29:31 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:18 +0000
|
|
|
fb76d3c2
|
|
1 |
|
Bug
Urlbar search icons disappear after browser restartBug 31563: force reloading search extensions if extensions.enabledScopes has changed
Author: Alex Catarineu, 2019-08-31 16:23:20 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:17 +0000
|
|
|
3b0641f3
|
|
1 |
|
ProjectUX
Communicating security expectations for .onion: what to say about different padlock states for .onion servicesBug 23247: Communicating security expectations for .onion
Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine.
Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services:
- HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure
- HTTP Onion Service pages would be marked as unencrypted in the Page Info screen
- Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content
This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.
Strings for Onion Service Page Info page are pulled from Torbutton's localization strings. Author: Richard Pospesel, 2018-06-08 13:38:40 -0700
Committer: Matthew Finkel, 2021-03-17 23:41:16 +0000
|
|
|
75f1f0bb
|
|
1 |
|
BugProxy Bypass
remove pingsender from Tor BrowserBug 28369: Stop shipping pingsender executable
Author: Alex Catarineu, 2019-04-10 17:52:51 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:16 +0000
|
|
|
a3808d6f
|
|
1 |
|
ProjectRoadmap::FutureUX
Improve user understanding and user control by clarifying Tor Browser's security featuresBug 25658: Replace security slider with security level UI
This patch adds a new 'securitylevel' component to Tor Browser intended to replace the torbutton 'Security Slider'.
This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.
Strings used by this patch are pulled from the torbutton extension, but en-US defaults are provided if there is an error loading from the extension. With this patch applied, the usual work-flow of "./mach build && ./mach run" work as expected, even if the torbutton extension is disabled. Author: Richard Pospesel, 2019-03-04 16:09:51 -0800
Committer: Matthew Finkel, 2021-03-17 23:41:15 +0000
|
- RESOLVED WONTFIX, Blocks: 1329996, [tor 23104][tor 23701][tor 29563][fingerprinting][fp-triaged]
CSS line-height reveals platformBug 1397994
|
|
79d67e03
|
|
1 |
|
BugBugSmashFundFingerprinting
CSS line-height reveals the platform Tor Browser is running onBug 23104: Add a default line height compensation
Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS.
The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height only and only if the frame is outside the chrome. Author: Igor Oliveira, 2017-12-10 18:16:59 -0200
Committer: Matthew Finkel, 2021-03-17 23:41:14 +0000
|
|
|
31977049
|
|
1 |
|
Task
Clean-up system extensions shipped in Firefox 52Bug 21431: Clean-up system extensions shipped in Firefox
Only ship the pdfjs extension. Author: Kathy Brade, 2017-05-23 17:05:29 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:13 +0000
|
|
|
cc193f94
|
|
1 |
|
All PlatformsApps::Impact::HighApps::Type::AuditLinkabilityRoadmap::FutureTaskesr-115
Make sure EME is no tracking risk in Tor BrowserBug 16285: Exclude ClearKey system for now
In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's RESOLVED FIXED(Fx52), Blocks: 1299627, 1299694, 1528884
Remove MOZ_EME build option and make EME disabled by preferences.bug 1300654). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past. Author: Georg Koppen, 2017-05-22 12:44:40 +0000
Committer: Matthew Finkel, 2021-03-17 23:41:13 +0000
|
|
|
cbc8e30e
|
|
1 |
|
Bug
Tor Browser nightly (based on ESR52) is not running on CentOS 6Bug 21907: Fix runtime error on CentOS 6
In Mozilla RESOLVED FIXED(Fx53), Blocks: 1313097
Build of Firefox Aurora 52.0b2 fails on CentOS 6 with '--enable-default-toolkit=cairo-gtk2'bug 1324780, support for building with glib 2.28 (the version available in CentOS 6) was added. However we are building on Debian Wheezy which has glib 2.32. We fix that by backing out all glib > 2.28 code paths. Author: Nicolas Vigier, 2017-04-10 16:07:23 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:12 +0000
|
|
|
89da7e84
|
|
1 |
|
Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed.
Also: FeatureUX
Use duckduckgo hidden service instead of clearnet oneBug 16322: Update DuckDuckGo search engine
We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to VERIFIED FIXED(Fx36), Blocks: 1073292
Add DuckDuckGo to default search engine listbug 1061736 where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well.
Also: This fixes FeatureUX
Use non-/html search engine URL for DuckDuckGo search pluginsbug 20809: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly.
Also fixes Bug
build1 for Tor Browser 8.5a9 is broken in mobile packaging stepbug 29798 by making sure we only specify the Google search engine we actually ship an .xml file for.
Also regression tests. Author: Mike Perry, 2017-05-05 03:41:57 -0700
Committer: Matthew Finkel, 2021-03-17 23:41:12 +0000
|
|
|
e1d80016
|
|
1 |
|
Feature
Implement loading (only) local change notes after a Tor Browser updateBug 16940: After update, load local change notes.
Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release).
Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts.
Also fix TaskUXUpdater
Update about:tor when Tor Browser is updatedbug 29440. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor. Author: Kathy Brade, 2015-11-25 11:36:20 -0500
Committer: Matthew Finkel, 2021-03-17 23:41:10 +0000
|
|
|
31f0fad8
|
|
1 |
|
BugSecurity
Sign our MAR filesBug 13379: Sign our MAR files.
Configure with --enable-verify-mar (when updating, require a valid signature on the MAR file before it is applied). Use the Tor Browser version instead of the Firefox version inside the MAR file info block (necessary to prevent downgrade attacks). Use NSS on all platforms for checking MAR signatures (instead of using OS-native APIs, which Mozilla does on Mac OS and Windows). So that the NSS and NSPR libraries the updater depends on can be found at runtime, we add the firefox directory to the shared library search path on macOS. On Linux, rpath is used by Mozilla to solve that problem, but that approach won't work on macOS because the updater executable is copied during the update process to a location that is under TorBrowser-Data, and the location of TorBrowser-Data varies.
Also includes the fix for Bug
TB 6.0a5: updater doesn't work on Linux (cannot find libraries)bug 18900. Author: Kathy Brade, 2014-12-17 16:37:11 -0500
Committer: Matthew Finkel, 2021-03-17 23:41:10 +0000
|
- RESOLVED FIXED, [tor 4234]
Add -q option to MAR generation scriptsBug 1641329
|
|
d6d93aa9
|
|
1 |
|
SecurityTaskUX
Deploy experimental builds using the Firefox update processBug 4234: Use the Firefox Update Process for Tor Browser.
The following files are never updated: TorBrowser/Data/Browser/profiles.ini TorBrowser/Data/Browser/profile.default/bookmarks.html TorBrowser/Data/Tor/torrc Mac OS: Store update metadata under TorBrowser/UpdateInfo. Removed the %OS_VERSION% component from the update URL (13047) and added support for minSupportedOSVersion, an attribute of the <update> element that may be used to trigger Firefox's "unsupported platform" behavior. Hide the "What's new" links (set app.releaseNotesURL value to about:blank). Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.
Also fix Bug
consider reducing the delay before the update prompt is displayed (ESR60)Bug 26049: reduce the delay before the update prompt is displayed. Instead of Firefox's 2 days, we use 1 hour (after which time the update doorhanger will be displayed).
Also fix Bug
Tor Browser 8.0a10 wants to update to 8.0a10bug 27221: purge the startup cache if the Tor Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Tor Browser update.
Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.
Bug
potentially confusing "restart to update" message in ESR60Bug 26048: potentially confusing "restart to update" message
Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.
BugBugSmashFundUXUpdater
notify users that update is downloadingBug 28885: notify users that update is downloading
Add a "Downloading Tor Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress.
As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process.
Removed #28885 parts of this patch which have been uplifted to Firefox.
Use a localized string from Torbutton for the app menu's "Downloading update" message. This is a temporary fix that can be removed once Tor Browser is based on Firefox 79 or newer (at which point the localized string will be included in the Firefox language packs). Author: Kathy Brade, 2017-01-13 11:40:24 -0500
Committer: Matthew Finkel, 2021-03-17 23:41:09 +0000
|
|
|
745a72bf
|
|
1 |
|
Bug
reinstate the update.xml hash checkBug 19121: reinstate the update.xml hash check
Revert most changes from Mozilla RESOLVED FIXED(Fx56)
Remove hashFunction and hashValue attributes from nsIUpdatePatch and code related to these valuesBug 1373267 "Remove hashFunction and hashValue attributes from nsIUpdatePatch and code related to these attributes." Changes to the tests were not reverted; the tests have been changed significantly and we do not run automated updater tests for Tor Browser at this time.
Also partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122.
Revert the nsUpdateService.js changes from Mozilla RESOLVED FIXED(Fx43)
main thread I/O in update serviceBug 862173 "don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)."
Changes to the tests were not reverted; the tests have been changed significantly and we do not run automated updater tests for Tor Browser at this time.
We kept the addition to the AppConstants API in case other JS code references it in the future. Author: Kathy Brade, 2018-04-23 15:22:57 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:09 +0000
|
|
|
acabef02
|
|
1 |
|
Bug
Distinguish between Tor Browser and Firefox when macOS opens documentsBug 21724: Make Firefox and Tor Browser distinct macOS apps
When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser. Author: teor, 2017-03-13 23:06:23 +1100
Committer: Matthew Finkel, 2021-03-17 23:41:09 +0000
|
|
|
f029e064
|
|
1 |
|
MikePerry201405Rcomponent::applications/tor bundles/installationowner::mcsparent::4234priority::mediumresolution::fixedstatus::closedtype::defect
change TBB directory structure to be more like Firefox'sBug 11641: change TBB directory structure to be more like Firefox's
Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior. Author: Kathy Brade, 2014-04-29 13:08:24 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:08 +0000
|
|
|
3a74d3cc
|
|
1 |
|
TaskUX
Write C++ patch to replace external applications helper dialog workaroundBug 19273: Avoid JavaScript patching of the external app helper dialog.
When handling an external URI or downloading a file, invoke Torbutton's external app blocker component (which will present a download warning dialog unless the user has checked the "Automatically download files from now on" box).
For e10s compatibility, avoid using a modal dialog and instead use a callback interface (nsIHelperAppWarningLauncher) to allow Torbutton to indicate the user's desire to cancel or continue each request.
Other bugs fixed: Bug
Tor Browser based on ESR52 with e10s enabled crashed while trying to download a fileBug 21766: Crash with e10s enabled while trying to download a file BugUX
Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s offBug 21886: Download is stalled in non-e10s mode Bug
Downloading pdf files with the download button in the pdf viewer is stallingBug 22471: Downloading files via the PDF viewer download button is broken Bug
Handle downloads via FTP better when external helper app dialog is shownBug 22472: Fix FTP downloads when external helper app dialog is shown Bug
Tor Browser 7 crashes when cancelling downloads on the external helper app warningBug 22610: Avoid crashes when canceling external helper app downloads Bug
Downloading pdf file via file:/// is stalling if the external helper dialog is enabledBug 22618: Downloading pdf file via file:/// is stalling Author: Kathy Brade, 2016-06-28 15:13:05 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:08 +0000
|
- RESOLVED FIXED(Fx97), Blocks: 1433504, [tor 18821]
Introduce a build flag to disable libmdnsBug 1432983
|
f |
3523a980
|
|
1 |
|
Proxy BypassTask
Make sure libmdns is Android only and disabled for OrfoxBug 18821: Disable libmdns for Android and Desktop
There should be no need to remove the OS X support introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=1225726 as enabling this is governed by a preference (which is actually set to false ). However, we remove it at build time as well (defense in depth).
This is basically a backout of the relevant passages of https://hg.mozilla.org/mozilla-central/rev/6bfb430de85d, https://hg.mozilla.org/mozilla-central/rev/609b337bf7ab and https://hg.mozilla.org/mozilla-central/rev/8e092ec5fbbd.
Fixed Bug
Make sure new mDNS code is disabled in ESR 52-based Tor Browsersbug 21861 (Disable additional mDNS code to avoid proxy bypasses) as well. Author: Georg Koppen, 2016-04-20 14:34:50 +0000
Committer: Matthew Finkel, 2021-03-17 23:41:07 +0000
|
- RESOLVED DUPLICATE, Blocks: 1260929, 1433504, [tor 18800]
Add pref to prevent localhost DNS lookup in nsProfileLock.cppBug 1432905
|
|
b3e5f2ac
|
|
1 |
|
BugProxy Bypass
Remove localhost DNS lookup in nsProfileLock.cppBug 18800: Remove localhost DNS lookup in nsProfileLock.cpp
Instead of using the local computer's IP address within symlink-based profile lock signatures, always use 127.0.0.1. Author: Kathy Brade, 2016-04-21 10:40:26 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:07 +0000
|
|
f |
9f3dc448
|
|
1 |
|
BugBugSmashFund
Transform window.name handling into Firefox patchBug 16620: Clear window.name when no referrer sent
Convert JS implementation (within Torbutton) to a C++ browser patch. Author: Kathy Brade, 2015-10-30 14:28:13 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:06 +0000
|
|
|
e0d679da
|
|
1 |
|
Bountycomponent::applications/tor bundles/installationowner::erinnpriority::highresolution::invalidseverity::blockerstatus::closedtbb-brandingtbb-no-uplifttype::defect
Branding of TBBBug 2176: Rebrand Firefox to TorBrowser
See also Bugs #5194, #7187, #8115, #8219.
This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons.
Also fix BugUX
many occurrences of "Firefox" in about:preferencesbug 27905.
BugUX
Activity 1.1 Update Tor Browser icon to follow design guidelines.Bug 25702: Update Tor Browser icon to follow design guidelines
- Updated all of the branding in /browser/branding/official with new 'stable' icon series.
- Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory
- Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654)
- Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory
- Updated content/identity-icons-brand.svg with Tor Browser icon (fixes #28111)
- Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico)
- Added default256.png and default512.png icons
- Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon
- Use the Tor Browser icon within devtools/client/themes/images/.
BugUX
Blurry Tor Browser icon on macOS app switcherBug 30631: Blurry Tor Browser icon on macOS app switcher
It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil.
Bug
about:preferences#general is not properly translated anymore starting with Tor Browser 8.5a4Bug 28196: preparations for using torbutton tor-browser-brand.ftl
A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser.
BugUX
branding for about:debugging needs logo SVGBug 31803: Replaced about:debugging logo with flat version Author: Mike Perry, 2013-09-10 16:21:47 -0700
Committer: Matthew Finkel, 2021-03-17 23:41:06 +0000
|
|
|
1d9c2710
|
|
1 |
|
BugBugSmashFund
Tor Browser on OS X should not store data into the application bundleBug 13252: Do not store data in the app bundle
When --enable-tor-browser-data-outside-app-dir is enabled, all user data is stored in a directory named TorBrowser-Data which is located next to the application directory.
Display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error.
On Mac OS, add support for the --invisible command line option which is used by the meek-http-helper to avoid showing an icon for the helper browser on the dock. Author: Kathy Brade, 2016-03-18 14:20:02 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:05 +0000
|
|
|
9e39d063
|
|
1 |
|
BugBugSmashFundUX
Users that try to run from DMG files run into "Another copy of Firefox is running"Bug 14631: Improve profile access error messages.
Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system".
To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts. Author: Kathy Brade, 2015-02-24 13:50:23 -0500
Committer: Matthew Finkel, 2021-03-17 23:41:05 +0000
|
|
|
669dc41f
|
|
1 |
|
MikePerry201311Rcomponent::firefox patch issuesowner::mcspriority::very highresolution::fixedstatus::closedtbb-3.0-backporttbb-no-uplifttbb-usabilitytype::defect
Relocate RelativeLink functionality to Firefox patchBug 9173: Change the default Firefox profile directory to be TBB-relative.
This should eliminate our need to rely on a wrapper script that sets /Users/arthur and launches Firefox with -profile. Author: Kathy Brade, 2013-10-18 15:20:06 -0400
Committer: Matthew Finkel, 2021-03-17 23:41:04 +0000
|
- RESOLVED WONTFIX, Blocks: 1433504, [tor 13028][psm-backlog]
potential proxy bypasses in networking codeBug 1433509
|
|
93ec120c
|
|
1 |
|
BugProxy Bypass
Prevent potential proxy bypass cases.Bug 13028: Prevent potential proxy bypass cases.
It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident. Author: Mike Perry, 2014-09-29 14:30:19 -0700
Committer: Matthew Finkel, 2021-03-17 23:41:04 +0000
|
- RESOLVED FIXED(Fx42), [reporter-external][post-critsmash-triage][adv-main42+][tor 12974]
Information disclosure vulnerability in Firefox via NTLM based HTTP authentication featureBug 1046421
|
|
abbe2def
|
|
1 |
|
BugFingerprintingLinkability
Disable NTLM and Negotiate HTTP AuthBug 12974: Disable NTLM and Negotiate HTTP Auth
This is technically an embargoed Mozilla bug, so I probably shouldn't provide too many details.
Suffice to say that NTLM and Negotiate auth are bad for Tor users, and I doubt very many (or any of them) actually need it.
The Mozilla bug is https://bugzilla.mozilla.org/show_bug.cgi?id=1046421 Author: Mike Perry, 2014-08-27 15:19:10 -0700
Committer: Matthew Finkel, 2021-03-17 23:41:03 +0000
|
|
|
18cfbdff
|
|
1 |
|
MikePerryIteration20110911actualpoints::3backport-to-mozillacomponent::firefox patch issuesmilestone::TorBrowserBundle 2.2.x-stableowner::mikeperryparent::2871points::2priority::highresolution::fixedstatus::closedtbb-2.2.32-4type::defect
Disable all plugins but flashBug 3547: Block all plugins.
We cannot use the @mozilla.org/extensions/blocklist;1 service, because we actually want to stop plugins from ever entering the browser's process space and/or executing code (for example, AV plugins that collect statistics/analyse urls, magical toolbars that phone home or "help" the user, skype buttons that ruin our day, and censorship filters). Hence we rolled our own.
See https://trac.torproject.org/projects/tor/ticket/3547#comment:6 for musings on a better way. Until then, it is delta-darwinism for us. Author: Mike Perry, 2012-12-04 16:03:13 -0800
Committer: Matthew Finkel, 2021-03-17 23:41:02 +0000
|
|
|
09275870
|
|
1 |
|
Add TorStrings module for localization
Author: Alex Catarineu, 2020-07-24 21:15:20 +0200
Committer: Matthew Finkel, 2021-03-17 23:41:01 +0000
|
|
|
36fc6bde
|
|
1 |
|
AffectsTailsTorBrowserTeam201905Rcomponent::applications/tor launcherowner::bradepriority::highresolution::fixedseverity::normalstatus::closedtbb-no-uplifttype::defectux-team
Integrate Tor Launcher into tor-browserBug 28044: Integrate Tor Launcher into tor-browser
Build and package Tor Launcher as part of the browser (similar to how pdfjs is handled).
If a Tor Launcher extension is present in the user's profile, it is removed. Author: Kathy Brade, 2019-02-26 10:07:17 -0500
Committer: Matthew Finkel, 2021-03-17 23:38:12 +0000
|
|
|
c06ec455
|
|
1 |
|
Task
Rebase TBB patches to Firefox 31 and add unit testsBug 12620: TorBrowser regression tests
Regression tests for MikePerryIteration20110515actualpoints::3component::firefox patch issuesowner::mikeperryparent::2877points::2priority::mediumresolution::fixedseverity::normalstatus::closedtype::defect
Make Permissions-Manager memory-only in TorBrowserBug #2950: Make Permissions Manager memory-only
Regression tests for component::mixminion-clientowner::nickmpriority::lowresolution::fixedseverity::blockerstatus::closedtype::defectversion::0.0.4
Incorrect node routing with mboxTB4: Tor Browser's Firefox preference overrides.
Note: many more functional tests could be made here
Regression tests for #2874: Block Components.interfaces from content
Feature
Add a script in tor-browser.git to run all of our TBB-specific regression testsBug 18923: Add a script to run all Tor Browser specific tests
Regression tests for BugBugSmashFundSecurityUX
8-month-old Tor Browser offers to "Reset Tor Browser", removes extensionsBug #16441: Suppress "Reset Tor Browser" prompt. Author: Arthur Edelstein, 2014-08-27 16:25:00 -0700
Committer: Matthew Finkel, 2021-03-17 23:38:11 +0000
|
|
|
d6863a33
|
|
1 |
|
component::mixminion-clientowner::nickmpriority::lowresolution::fixedseverity::blockerstatus::closedtype::defectversion::0.0.4
Incorrect node routing with mboxTB4: Tor Browser's Firefox preference overrides.
This hack directly includes our preference changes in omni.ja.
Apps::Impact::NoneApps::Type::BugBugDesktopRoadmap::FutureUpdaterWindows
staged updates fail on WindowsBug 18292: Staged updates fail on Windows
Temporarily disable staged updates on Windows.
BugFingerprinting
Tor browser uses Chinese-style glyphs to display JapaneseBug 18297: Use separate Noto JP,KR,SC,TC fonts
BugFingerprinting
Noto Sans Buginese missing from macOS font whitelistBug 23404: Add Noto Sans Buginese to the macOS whitelist
Bug
Tab crashes when using Tor Browser to access Google DriveBug 23745: Set dom.indexedDB.enabled = true
BugFingerprintingFirst Contribution
Disable randomised Firefox HTTP cache decay user test groupsBug 13575: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)
FeatureLinkabilityPerformance
Confirm TLS session resumption/ID are isolated to the URL bar domain, and re-enable themBug 17252: Enable session identifiers with FPI
Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".
The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)
LinkabilityPerformanceTaskUX
Audit HTTP/2 and SPDY if neededBug 14952: Enable http/2 and AltSvc
In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".
Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.
(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)
However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.
"network.http.spdy.enabled.http2draft" was removed in RESOLVED FIXED(Fx41), [spdy]
remove h2-draft support starting in gecko-40Bug 1132357. "network.http.sped.enabled.v2" was removed in VERIFIED FIXED(Fx27)
remove spdy/2 supportBug 912550. "network.http.sped.enabled.v3" was removed in RESOLVED FIXED(Fx36), spdy
kill spdy/3Bug 1097944. "network.http.sped.enabled.v3-1" was removed in RESOLVED FIXED(Fx51), Blocks: 912549, [necko-active]
remove spdy/3.1 supportBug 1248197.
FingerprintingTask
Adapt to upstreamed AddonManager changesBug 26114: addons.mozilla.org is not special
- Don't expose navigator.mozAddonManager on any site
- Don't block NoScript from modifying addons.mozilla.org or other sites
Enable ReaderView mode again (#27281).
BugProxy Bypass
Group Policies for Firefox can bypass Tor Browser's proxy settingsBug 29916: Make sure enterprise policies are disabled
MikePerry201408RMikePerryIterationFires20110529actualpoints::1backport-to-mozillacomponent::firefox patch issuesowner::mikeperrypoints::4priority::mediumresolution::fixedseverity::blockerstatus::closedtbb-no-uplift-60type::enhancement
Block access to Components.interfaces from content scriptBug 2874: Block Components.interfaces from content
BugBugSmashFundFingerprinting
Setting general.useragent.override does not spoof the platform part anymore in ESR 60 which is confusingBug 26146: Spoof HTTP User-Agent header for desktop platforms
In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.
BugUX
Windows Jump Lists fail for Tor BrowserBug 12885: Windows Jump Lists fail for Tor Browser
Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations
and has a name in the form [a-f0-9]+.customDestinations-ms
The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.
However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.
The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.
Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See Apps::Impact::MinimalApps::Type::BugBugDisk LeakRoadmap::FutureWindows
Tor Browser on Windows creates a file in %APPDATA%\Microsoft\Windows\Recent\CustomDestinations containing the Tor Browser install locationbug 28996.
Bug
Communication with noscript for security settings not working in nightliesBug 31396: Disable indexedDB WebExtension storage backend.
Bug
Make sure default Firefox themes are enabled on ESR68Bug 30845: Make sure default themes and other internal extensions are enabled
Task
Make sure our bundled WebExtensions are running in Private Browsing ModeBug 28896: Enable extensions in private browsing by default
BugBugSmashFund
Set network.proxy.allow_hijacking_localhost to trueBug 31065: Explicitly allow proxying localhost
Bug
Properly enable letterboxing (again)Bug 31598: Enable letterboxing
Disable Presentation API everywhere
BugSmashFundTask
Investigate wasm for linkability/fingerprintability/disk avoidance issuesBug 21549 - Use Firefox's WASM default pref. It is disabled at safer security levels.
BugLinkability
https://mitmdetection.services.mozilla.com/ is contacted over catch-all circuitBug 32321: Disable Mozilla's MitM pings
Bug
Tor Browser warning: "Your Firefox is out of date."Bug 19890: Disable installation of system addons
By setting the URL to "" we make sure that already installed system addons get deleted as well.
BugFingerprinting
Firefox downgrades VP9 videos to VP8 when measured performance is not enoughBug 22548: Firefox downgrades VP9 videos to VP8.
On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8.
This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available".
AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Add mobile-override of 000-tor-browser prefs
BugBugSmashFundSecurityUX
8-month-old Tor Browser offers to "Reset Tor Browser", removes extensionsBug 16441: Suppress "Reset Tor Browser" prompt.
BugDisk LeakUX
Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayableBug 29120: Use the in-memory media cache and increase its maximum size.
BugNext
Investigate new Search Engine configurationBug 33697: use old search config based on list.json
Bug
Don't use site's icon as window icon in Windows when in private browsing modeBug 33855: Ensure that site-specific browser mode is disabled.
Feature
Adapt Intermediate Preloading for Tor BrowserBug 30682: Disable Intermediate CA Preloading.
Fingerprinting
ensure that Windows default browser agent is omittedBug 40061: Omit the Windows default browser agent from the build
User Feedback
YouTube videos stop working after TB 10 updateBug 40140: Videos stop working with Tor Browser 10.0 on Windows Author: Mike Perry, 2013-09-10 18:20:43 -0700
Committer: Matthew Finkel, 2021-03-17 23:38:11 +0000
|
|
|
7e244125
|
|
1 |
|
component::mixminion-serverowner::nickmpriority::lowresolution::fixedstatus::closedtype::defectversion::0.0.4rc2
changing PublicKeyLifetime to smaller values isn't goodTB3: Tor Browser's official .mozconfigs.
Also: MikePerry201312Rcomponent::applications/tor bundles/installationff24-esrowner::erinnparent::10103priority::mediumresolution::fixedstatus::closedtbb-3.0type::defect
Firefox ESR 24 does need a newer compiler than gcc 4.2Bug #9829.1: new .mozconfig file for the new cross-compiler and ESR24 Changes needed to build Mac in 64bit component::applications/tor bundles/installationowner::erinnparent::12460priority::mediumresolution::fixedstatus::closedtbb-3.5tbb-usabilitytype::defect
Cross-Compiling WebGL with mingw-w64 is brokenBug 10715: Enable Webgl for mingw-w64 again. Disable ICU when cross-compiling; clean-up. Bug
Enable ICU for OS X Tor Browser buildsBug 15773: Enable ICU on OS X Task
Get Windows cross-compilation working with Fx38 in GitianBug 15990: Don't build the sandbox with mingw-w64 Task
Switch to OS X 10.7 SDK in our Tor Browser Mac buildsBug 12761: Switch to ESR 38 for OS X Updating .mozconfig-asan FeatureSecurity
Compile Tor Browser with -fwrapv/-fno-strict-overflowBug 12516: Compile hardenend Tor Browser with -fwrapv Task
Update OS X toolchain to work with ESR 45Bug 18331: Switch to Mozilla's toolchain for building Tor Browser for OS X BugSecurity
Creating incremental MAR files for the hardened builds is brokenBug 17858: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan. Task
Fix cross-compiling ICU with mingw-w64 for Windows buildsBug 13419: Add back ICU for Windows Bug
Adapt Linux Firefox descriptor for ESR 52Bug 21239: Use GTK2 for ESR52 Linux builds Bug
Flags to increase hardening on macOSBug 23025: Add hardening flags for macOS Bug
Enable tests and debug assertions in our ASan buildsBug 24478: Enable debug assertions and tests in our ASan builds --enable-proxy-bypass-protection Bug
ASan build option in tor-browser-build is brokenBug 27597: ASan build option in tor-browser-build is broken
Bug
wrong default pref values in Tor Browser 8.0Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds
This fixes a problem where some preferences had the wrong default value. Also see AndroidFeature
TBA: Add export MOZILLA_OFFICIALbug 27472 where we made a similar fix for Android.
BugSmashFundTask
Make sure telemetry reporting is disabled in Tor Browser 9Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING
BugBugSmashFund
Still use GCC for 64bit Linux debug builds after switch to 68 ESRBug 31450: Set proper BINDGEN_CFLAGS for ASan builds
Add an --enable-tor-browser-data-outside-app-dir configure option
Add --with-tor-browser-version configure option
Bug
Create a rebased patch for #18885Bug 21849: Don't allow SSL key logging.
BugBugSmashFund
disable per-installation profilesBug 31457: disable per-installation profiles
The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data.
Bug
TB9.0a7 is asking for a new profileBug 31935: Disable profile downgrade protection.
Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected.
Task
Consider adding MOZ_SERVICES_HEALTHREPORT to mozconfigBug 32493: Disable MOZ_SERVICES_HEALTHREPORT
AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Disable features at compile-time
MOZ_NATIVE_DEVICES for casting and the media player MOZ_TELEMETRY_REPORTING for telemetry MOZ_DATA_REPORTING for all data reporting preferences (crashreport, telemetry, geo)
AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-centralBug 25741 - TBA: Add default configure options in dedicated file
Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION
AndroidBug
Playing videos on Twitter is not working and freezing the mobile browserBug 29859: Disable HLS support for now
Add --disable-tor-launcher build option
Add --enable-tor-browser-update build option
Bug
Consider setting MOZ_NORMANDY=FalseBug 33734: Set MOZ_NORMANDY to False
Bug
Patch out Parental Controls detection and loggingBug 33851: Omit Parental Controls.
Fingerprinting
ensure that Windows default browser agent is omittedBug 40061: Omit the Windows default browser agent from the build
Adapt .mozconfig-asan for ESR 78Bug 40107: Adapt .mozconfig-asan for ESR 78 Author: Mike Perry, 2013-05-06 15:51:06 -0700
Committer: Matthew Finkel, 2021-03-17 23:38:10 +0000
|
|
c |
f11d3c99
|
|
1 |
|
RESOLVED FIXED(Fx80), [tor 31915]
Android cpu-features.c included twice when building GeckoView with --disable-webrtcBug 1585470 - Remove duplicate cpu-features.c definition when building GV without webrtc r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D82120 Author: Matthew Finkel, 2020-07-09 19:10:34 +0000
Committer: Matthew Finkel, 2021-03-17 23:38:10 +0000
|
|
c |
8497b59f
|
|
1 |
|
RESOLVED FIXED(Fx79), [tor 28885]
Update prompts should not depend on whether an update was initiated manuallyBug 1642754 - Update prompts should not depend on how update was initiated r=bytesized
Show update badge and doorhanger when entering the "pending" state for foreground updates.
Differential Revision: https://phabricator.services.mozilla.com/D79903 Author: Mark Smith, 2020-06-17 19:24:09 +0000
Committer: Matthew Finkel, 2021-03-17 23:38:09 +0000
|
|
c |
d97e95d4
|
|
1 |
|
RESOLVED FIXED(Fx79), [tor 28885]
add an option to show that an update is being downloadedBug 1642404 - add an option to show that an update is being downloaded r=bytesized,fluent-reviewers,flod
Add support for a hidden preference named app.update.notifyDuringDownload that, when set to true, causes a "Downloading update" message to appear in the app menu during a MAR download. Clicking the message opens the about box so the user can see detailed progress information.
Differential Revision: https://phabricator.services.mozilla.com/D77688 Author: Mark Smith, 2020-06-22 20:24:46 +0000
Committer: Matthew Finkel, 2021-03-17 23:38:09 +0000
|