102.10.0-13.0-1

Base commit: 0c4c3778

Branches:
Uplift Bug Tags Commit build Description
B T M
  • NEW, Blocks: 1299996, 1958496, [tor 40171] [geckoview:2023?]
    Make WebRequest and GeckoWebExecutor First-Party aware
    Bug 1676104
u P1 e513c5c2 n
AndroidApps::Priority::HighBugLinkabilityProject 131Roadmap::Future
Make WebRequest and GeckoWebExecutor First-Party aware
Bug 40171
: Make WebRequest and GeckoWebExecutor First-Party aware
Author: Alex Catarineu, 2020-11-04 15:58:22 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:38 +0200
  • ASSIGNED(Gijs), [tor 41454]
    No focus is set after opening preferences and scrolling with openPreferences
    Bug 1799153
u P3 fe263b2e n
AccessibilityApps::Impact::MediumApps::Priority::LowApps::Type::BugBugDesktopRoadmap::FutureUXUpstream
No focus is set after opening preferences and scrolling with openPreferences
Bug 41454
: Move focus after calling openPreferences for a sub-category.

Temporary fix until mozilla ASSIGNED(Gijs), [tor 41454]
No focus is set after opening preferences and scrolling with openPreferences
bug 1799153
gets a patch upstream.

Author: Henry Wilkes, 2022-11-15 11:48:04 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:12:34 +0200
u 1716b70d n
BackportBugDesktopFingerprintingNextProject 131Q1UXUplift
Stop inner letterbox jiggling as border is dragged
Bug 32308
: use direct browser sizing for letterboxing.
Author: hackademix, 2022-12-11 13:28:57 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:30 +0200
  • RESOLVED FIXED(Fx136), [tor 31064][tor 32411]
    Do not apply letterboxing to moz-extension:// pages
    Bug 1555815
f 43b855b9 n
BacklogProject 131TaskUXUplift
Consider adding about:tor and others to the list of pages that do not need letterboxing
Bug 32411
: Letterboxing, exempt view-source: URIs.
Author: hackademix, 2022-11-11 22:24:35 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:30 +0200
  • RESOLVED FIXED(Fx136), [tor 31064][tor 32411]
    Do not apply letterboxing to moz-extension:// pages
    Bug 1555815
f 971255f2 n
BacklogFingerprintingProject 131TaskUXUplift
Letterboxing is enabled in priviledged contexts too
Bug 31064
: Letterboxing, exempt browser extensions.
Author: hackademix, 2022-11-10 23:02:47 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:30 +0200
u b2a64169 n
BacklogFingerprintingProject 131TaskUXUplift
Letterboxing bypass through secondary tab (popup/popunder...)
Bug 41434
: Letterboxing, improve logging.
Author: hackademix, 2022-11-10 22:59:17 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:29 +0200
a00f1e14 n
BacklogFingerprintingProject 131TaskUXUplift
Letterboxing bypass through secondary tab (popup/popunder...)
Bug 41434
: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.
Author: hackademix, 2022-11-10 22:25:51 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:29 +0200
  • NEW, [tor 40432]
    Scheme flooding technique for reliable cross-browser fingerprinting
    Bug 1711084
u e007176f n
BackportFingerprinting
protocol flooding attack (scheme flood)
Bug 40432
: Prevent probing installed applications

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084

Author: Matthew Finkel, 2021-05-17 18:09:09 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:28 +0200
u 9291cdd2 n
FingerprintingNextUplift
Avoid using regional OS locales
Bug 40309
: Avoid using regional OS locales

Avoid regional OS locales if the pref intl.regional_prefs.use_os_locales is false but RFP is enabled.

Author: Pier Angelo Vendrame, 2022-05-18 19:22:37 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:28 +0200
  • NEW, Blocks: 1674565, [tor 27604]
    After restoring profile to a different location, paths in extensions.json are incorrect
    Bug 1429838
u b3d8a441 n
Bug
Relocating the Tor Browser directory is broken with Tor Browser 8
Bug 27604
: Fix addon issues when moving the profile directory

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838

Author: Alex Catarineu, 2019-10-30 10:44:48 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:27 +0200
u 1eb3d4c7 n
All PlatformsBugDisk LeakProject 131Q1Roadmap::FutureUplift
Gate Telemetry Tasks behind AppConstants.MOZ_TELEMETRY_REPORTING
Bug 41565
: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING
Author: cypherpunks1, 2023-01-11 08:37:43 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:32 +0200
  • UNCONFIRMED, Blocks: 1958496, [fingerprinting] [gfx-noted] [fp-triaged] [tor 30541]
    Apply Resist Fingerprinting Protection to WebGL's readPixels method
    Bug 1428034
u c7d7d1a4 n
BugFingerprinting
webgl readPixels FP entropy
Bug 30541
: Disable WebGL readPixel() for web content

Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034

Author: Georg Koppen, 2019-05-29 12:29:19 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:31 +0200
u 14e2d8e7 n
BugLinkability
First request after copying and pasting an URL in URL bar seems to go over the catch-all circuit
Bug 26353
: Prevent speculative connect that violated FPI.

Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term.

Author: Arthur Edelstein, 2018-07-14 08:50:55 -0700
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:28 +0200
u 2e29c765 n
BugDoingProject 131Q1UpliftWindows
WebRTC fails to build under mingw
Bug 41459
: WebRTC fails to build under mingw (Part 6)
  • fixes required to build dom/media/systemservices
Author: Marco Simonelli, 2023-03-10 12:11:22 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:48 +0200
a63f2046 n
BugDoingProject 131Q1UpliftWindows
WebRTC fails to build under mingw
Bug 41459
: WebRTC fails to build under mingw (Part 5)
  • fixes required to build dom/media/webrtc
Author: Marco Simonelli, 2023-03-10 12:09:57 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:48 +0200
b703e8f5 n
BugDoingProject 131Q1UpliftWindows
WebRTC fails to build under mingw
Bug 41459
: WebRTC fails to build under mingw (Part 4)
  • fixes requried to build netwerk/sctp
Author: Marco Simonelli, 2023-03-10 11:59:37 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:47 +0200
f7336951 n
fixup! BugDoingProject 131Q1UpliftWindows
WebRTC fails to build under mingw
Bug 41459
: WebRTC fails to build under mingw (Part 3)

Fix build error

Author: Pier Angelo Vendrame, 2023-03-14 17:34:26 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:47 +0200
21d84125 n
fixup! BugDoingProject 131Q1UpliftWindows
WebRTC fails to build under mingw
Bug 41459
: WebRTC fails to build under mingw (Part 3)
Author: Richard Pospesel, 2023-03-13 11:53:15 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:46 +0200
afc62d14 n
BugDoingProject 131Q1UpliftWindows
WebRTC fails to build under mingw
Bug 41459
: WebRTC fails to build under mingw (Part 3)
  • fixes required to build third_party/sipcc
Author: Marco Simonelli, 2023-03-10 11:51:15 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:46 +0200
fe48d4a5 n
fixup! BugDoingProject 131Q1UpliftWindows
WebRTC fails to build under mingw
Bug 41459
: WebRTC fails to build under mingw (Part 2)
Author: Richard Pospesel, 2023-03-13 11:51:10 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:45 +0200
3daeb2e9 n
BugDoingProject 131Q1UpliftWindows
WebRTC fails to build under mingw
Bug 41459
: WebRTC fails to build under mingw (Part 2)
  • fixes required to build third_party/libwebrtc
Author: Marco Simonelli, 2023-03-10 11:50:33 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:45 +0200
046d4fc2 n
BugDoingProject 131Q1UpliftWindows
WebRTC fails to build under mingw
Bug 41459
: WebRTC fails to build under mingw (Part 1)
  • properly define NOMINMAX for just MSVC builds
Author: Marco Simonelli, 2023-03-10 11:55:36 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:37 +0200
u badf4b57 n
13.5 stableAll PlatformsFeatureFingerprintingFontsProject 131UpliftUpstream
Review Mozilla 1226042: add support for the new 'system-ui' generic font family
Bug 41116
: Normalize system fonts.

System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks.

Author: Pier Angelo Vendrame, 2022-09-19 12:57:40 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:12:36 +0200
u bc39624e n
BacklogBugDesktopProject 131
Tor Browser says Firefox timed out, confusing users
Bug 41483
: Remove the firefox override for appstrings.properties

Remove this patch after upstream bugzilla NEW, Blocks: 306369, 336029, 1581212, 1722896, 1872711, [tor 41483]
Migrate appstrings.properties to Fluent & format its messages from aboutNetError.mjs
bug 1790187

Author: Henry Wilkes, 2022-12-06 11:10:08 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:12:35 +0200
d1f3b52e n
fixup! BugBugSmashFundPlatform ParityUX
Integrate TorButton to TorBrowser core to prevent users from disabling it
Bug 10760
: Integrate TorButton to TorBrowser core

12.5 stableDesktopNeeds DesignQ2Sponsor 30 - FINISHEDTaskUX
Update "New Circuit" icon
Bug 41607
- New icon for new circuit toolbar button

Author: Henry Wilkes, 2023-03-28 16:13:33 +0100
Committer: Pier Angelo Vendrame, 2023-05-04 08:43:14 +0000
95ab5a71 n
fixup! BugBugSmashFundPlatform ParityUX
Integrate TorButton to TorBrowser core to prevent users from disabling it
Bug 10760
: Integrate TorButton to TorBrowser core

12.5 stableDesktopFeatureNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Improve security warning when downloading a file
Bug 40701
: Remove old download popup

Author: Dan Ballard, 2023-04-03 11:21:11 -0500
Committer: Richard Pospesel, 2023-04-13 16:17:39 +0000
f335b937 n
fixup! BugBugSmashFundPlatform ParityUX
Integrate TorButton to TorBrowser core to prevent users from disabling it
Bug 10760
: Integrate TorButton to TorBrowser core

12.5 stableBugCircuit DisplayDesktopDoingNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Some users have difficulty finding the circuit display
Bug 41600
- Add API to domain-isolator to get the stored SOCKS username and password for a given domain and user context ID.

Also get rid of unused newCircuitForUserContextId.

Also remove the return statement from tor-control-port's watchEvent since addNotificationCallback does not return a value.

Author: Henry Wilkes, 2023-03-10 11:44:45 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 19:46:09 +0200
f142bbf3 n
fixup! BugBugSmashFundPlatform ParityUX
Integrate TorButton to TorBrowser core to prevent users from disabling it
Bug 10760
: Integrate TorButton to TorBrowser core

12.5 stableBugCircuit DisplayDesktopDoingNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Some users have difficulty finding the circuit display
Bug 41600
- Remove old circuit display.

Author: Henry Wilkes, 2023-03-07 14:13:29 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 19:46:08 +0200
9d79898b n
fixup! BugBugSmashFundPlatform ParityUX
Integrate TorButton to TorBrowser core to prevent users from disabling it
Bug 10760
: Integrate TorButton to TorBrowser core
Author: hackademix, 2023-03-28 23:30:47 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 19:46:08 +0200
3f92800f n
fixup! BugBugSmashFundPlatform ParityUX
Integrate TorButton to TorBrowser core to prevent users from disabling it
Bug 10760
: Integrate TorButton to TorBrowser core

BugDesktop
High CPU load after tor exits unexpectedly
Bug 40501
: High CPU load after tor exits unexpectedly

When a peers (tor) disconnects, Firefox seems to keep the stream open, and return 0 on available, rather than throwing. So, as a matter of fact, we had a while trying to read 0 bytes without any pause in _readLine, hence the 100% CPU usage.

Author: Pier Angelo Vendrame, 2023-03-31 17:42:59 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 19:46:07 +0200
8b0fc790 n
BugBugSmashFundPlatform ParityUX
Integrate TorButton to TorBrowser core to prevent users from disabling it
Bug 10760
: Integrate TorButton to TorBrowser core

Because of the non-restartless nature of Torbutton, it required a two-stage installation process. On mobile, it was a problem, because it was not loading when the user opened the browser for the first time.

Moving it to tor-browser and making it a system extension allows it to load when the user opens the browser for first time.

Additionally, this patch also fixes AndroidBug
Restart Gecko after first-run
Bug 27611
.

Feature
Circuit display - Let's remove link from the Tor Button
Bug 26321
: New Circuit and New Identity menu items

BugUX
about:tor should behave more like about:newtab
Bug 14392
: Make about:tor behave like other initial pages.

AndroidBug
Move TorButton code to the tor browser repository
Bug 25013
: Add torbutton as a tor-browser submodule

Bug
Firefox is phoning home during start-up in Tor Browser based on ESR 68
Bug 31575
: Replace Firefox Home (newtab) with about:tor

Author: Alex Catarineu, 2020-02-19 23:05:08 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 19:46:07 +0200
0db7a4bd n
fixup! Build System
Create rebase and security backport gitlab issue templates
Bug 41649
: Create rebase and security backport gitlab issue templates
Author: Richard Pospesel, 2023-04-10 18:58:08 +0000
Committer: Richard Pospesel, 2023-04-23 11:51:30 +0000
ae868687 n
Build System
Create rebase and security backport gitlab issue templates
Bug 41649
: Create rebase and security backport gitlab issue templates
Author: Richard Pospesel, 2023-02-22 15:56:11 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 15:32:00 +0200
9b35dbeb n
All PlatformsSponsor 30 - FINISHED
Pin bridges.torproject.org domains to Let's Encrypt's root cert public key
Bug 41728
: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key
Author: hackademix, 2023-04-18 22:50:11 +0200
Committer: Richard Pospesel, 2023-04-20 20:11:22 +0000
96796fa5 n
fixup! Needs Review
Reorganize patchset
Bug 40562
: Added Tor Browser preferences to 000-tor-browser.js

DesktopDoingTask
Customize the default CustomizableUI toolbar using CustomizableUI.jsm
Bug 41736
- Stop setting the browser.uiCustomization.state preference.

Author: Henry Wilkes, 2023-04-19 15:08:23 +0100
Committer: Richard Pospesel, 2023-04-20 20:03:08 +0000
0169c7ee n
fixup! Needs Review
Reorganize patchset
Bug 40562
: Added Tor Browser preferences to 000-tor-browser.js

12.5 stableDesktopFeatureNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Improve security warning when downloading a file
Bug 40701
: Improve security warning when downloading a file Remove existing popup warnings and add pref for new one

12.5 stableDesktopFeatureNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Improve security warning when downloading a file
Bug 40701
: update pref names

Author: Dan Ballard, 2023-03-31 12:14:56 -0500
Committer: Richard Pospesel, 2023-04-13 16:17:40 +0000
2c4a4562 n
fixup! Needs Review
Reorganize patchset
Bug 40562
: Added Tor Browser preferences to 000-tor-browser.js

12.5 stableBugCircuit DisplayDesktopDoingNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Some users have difficulty finding the circuit display
Bug 41600
- Remove extensions.torbutton.display_circuit since it will no longer be used.

It also could not work as intended before because after disabling and re-enabling, all the circuits and browser credentials that were established whilst it was switched off would have been lost and were not recovered.

Author: Henry Wilkes, 2023-03-07 14:58:44 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 16:15:03 +0200
fa55fc33 n
fixup! Needs Review
Reorganize patchset
Bug 40562
: Added Tor Browser preferences to 000-tor-browser.js
Author: hackademix, 2023-03-28 23:33:12 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 16:15:02 +0200
22758305 n
Needs Review
Reorganize patchset
Bug 40562
: Added Tor Browser preferences to 000-tor-browser.js

Before reordering patches, we used to keep the Tor-related patches (torbutton and tor-launcher) at the beginning. After that issue, we decided to move them towards the end.

In addition to that, we have decided to move Tor Browser-only preferences there, too, to make Base Browser-only fixups easier to apply.

Author: Pier Angelo Vendrame, 2022-01-18 19:18:48 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 16:15:02 +0200
352acb10 n
DesktopDoingTask
Customize the default CustomizableUI toolbar using CustomizableUI.jsm
Bug 41736
- Customize toolbar for tor-browser.
Author: Henry Wilkes, 2023-04-19 14:34:32 +0100
Committer: Richard Pospesel, 2023-04-20 20:03:08 +0000
1ce930e3 n
DesktopDoingTask
Customize the default CustomizableUI toolbar using CustomizableUI.jsm
Bug 41736
- Customize toolbar for base-browser.
Author: Henry Wilkes, 2023-04-19 14:22:18 +0100
Committer: Richard Pospesel, 2023-04-20 20:03:08 +0000
491718d1 n
fixup! Firefox preference overrides.

DesktopDoingTask
Customize the default CustomizableUI toolbar using CustomizableUI.jsm
Bug 41736
- Stop setting the browser.uiCustomization.state preference.

Author: Henry Wilkes, 2023-04-19 14:53:12 +0100
Committer: Richard Pospesel, 2023-04-20 20:03:08 +0000
4ae88530 n
fixup! Firefox preference overrides.

Replace the patch to disable live reload with its preferenceBug 41738: Drop the patch to disable live reload and use the pref

Author: Pier Angelo Vendrame, 2023-04-19 17:25:25 +0200
Committer: Pier Angelo Vendrame, 2023-04-20 20:16:02 +0200
c24cc05f n
fixup! Firefox preference overrides.

BugFontsLinuxProject 131Q2Roadmap::FutureUpstreamesr-115
Many bundled fonts are blocked in Ubuntu/Fedora because of RFP
Bug 41163
: Many bundled fonts are blocked in Ubuntu/Fedora because of RFP

Removed the workaround now that we have the upstream fix.

Author: Pier Angelo Vendrame, 2023-04-17 19:02:29 +0200
Committer: Pier Angelo Vendrame, 2023-04-17 19:02:29 +0200
b9584233 n
fixup! Firefox preference overrides.

BugDesktop
Reporting an extension does not work
Bug 41701
: Reporting an extension does not work

Author: Richard Pospesel, 2023-03-29 11:14:21 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:36 +0200
79f97899 n
fixup! Firefox preference overrides.

All Platforms
Remove startup.homepage_override_url from Base Browser
Bug 41689
: Do not customize startup.homepage_override_url in Base Browser.

(cherry picked from commit eff20896dedc966b4162bfa098a6dc065faf30eb)

Author: Pier Angelo Vendrame, 2023-03-22 15:40:02 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:36 +0200
b8f4b410 n
fixup! Firefox preference overrides.

Windows
Disable the network process on Windows
Bug 41683
: Disable the network process on Windows

Author: Pier Angelo Vendrame, 2023-03-20 18:58:51 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:36 +0200
aba403e3 n
fixup! Firefox preference overrides.

DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Port some updater patches to Base Browser

Do not change app.update.auto in firefox.js, but add it to 001.

Author: Pier Angelo Vendrame, 2023-03-09 11:03:06 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:35 +0200
f4fdbba5 n
fixup! Firefox preference overrides. Author: hackademix, 2023-03-10 12:10:19 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:35 +0200
5346b6f8 n
fixup! Firefox preference overrides.

All PlatformsTask
Turn --enable-base-browser in --with-base-browser-version
Bug 41647
: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros

Changed TOR_BROWSER_VERSION with BASE_BROWSER_VERSION.

Author: Pier Angelo Vendrame, 2023-03-02 17:33:01 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:34 +0200
bc56c3cb n
Firefox preference overrides.

This hack directly includes our preference changes in omni.ja.

Apps::Impact::NoneApps::Type::BugBugDesktopRoadmap::FutureUpdaterWindows
staged updates fail on Windows
Bug 18292
: Staged updates fail on Windows

Temporarily disable staged updates on Windows.

BugFingerprinting
Tor browser uses Chinese-style glyphs to display Japanese
Bug 18297
: Use separate Noto JP,KR,SC,TC fonts

BugFingerprinting
Noto Sans Buginese missing from macOS font whitelist
Bug 23404
: Add Noto Sans Buginese to the macOS whitelist

Bug
Tab crashes when using Tor Browser to access Google Drive
Bug 23745
: Set dom.indexedDB.enabled = true

BugFingerprintingFirst Contribution
Disable randomised Firefox HTTP cache decay user test groups
Bug 13575
: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)

FeatureLinkabilityPerformance
Confirm TLS session resumption/ID are isolated to the URL bar domain, and re-enable them
Bug 17252
: Enable session identifiers with FPI

Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".

The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)

LinkabilityPerformanceTaskUX
Audit HTTP/2 and SPDY if needed
Bug 14952
: Enable http/2 and AltSvc

In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".

Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.

(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)

However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.

"network.http.spdy.enabled.http2draft" was removed in RESOLVED FIXED(Fx41), [spdy]
remove h2-draft support starting in gecko-40
Bug 1132357
. "network.http.sped.enabled.v2" was removed in VERIFIED FIXED(Fx27)
remove spdy/2 support
Bug 912550
. "network.http.sped.enabled.v3" was removed in RESOLVED FIXED(Fx36), spdy
kill spdy/3
Bug 1097944
. "network.http.sped.enabled.v3-1" was removed in RESOLVED FIXED(Fx51), Blocks: 912549, [necko-active]
remove spdy/3.1 support
Bug 1248197
.

FingerprintingTask
Adapt to upstreamed AddonManager changes
Bug 26114
: addons.mozilla.org is not special

  • Don't expose navigator.mozAddonManager on any site
  • Don't block NoScript from modifying addons.mozilla.org or other sites

Enable ReaderView mode again (#27281).

BugProxy Bypass
Group Policies for Firefox can bypass Tor Browser's proxy settings
Bug 29916
: Make sure enterprise policies are disabled

MikePerry201408RMikePerryIterationFires20110529actualpoints::1backport-to-mozillacomponent::firefox patch issuesowner::mikeperrypoints::4priority::mediumresolution::fixedseverity::blockerstatus::closedtbb-no-uplift-60type::enhancement
Block access to Components.interfaces from content script
Bug 2874
: Block Components.interfaces from content

BugBugSmashFundFingerprinting
Setting general.useragent.override does not spoof the platform part anymore in ESR 60 which is confusing
Bug 26146
: Spoof HTTP User-Agent header for desktop platforms

In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.

BugUX
Windows Jump Lists fail for Tor Browser
Bug 12885
: Windows Jump Lists fail for Tor Browser

Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations
and has a name in the form [a-f0-9]+.customDestinations-ms

The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.

However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.

The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.

Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See Apps::Impact::MinimalApps::Type::BugBugDisk LeakRoadmap::FutureWindows
Tor Browser on Windows creates a file in %APPDATA%\Microsoft\Windows\Recent\CustomDestinations containing the Tor Browser install location
bug 28996
.

Bug
Make sure default Firefox themes are enabled on ESR68
Bug 30845
: Make sure default themes and other internal extensions are enabled

Task
Make sure our bundled WebExtensions are running in Private Browsing Mode
Bug 28896
: Enable extensions in private browsing by default

BugBugSmashFund
Set network.proxy.allow_hijacking_localhost to true
Bug 31065
: Explicitly allow proxying localhost

Bug
Properly enable letterboxing (again)
Bug 31598
: Enable letterboxing

Disable Presentation API everywhere

BugSmashFundTask
Investigate wasm for linkability/fingerprintability/disk avoidance issues
Bug 21549
- Use Firefox's WASM default pref. It is disabled at safer security levels.

BugLinkability
https://mitmdetection.services.mozilla.com/ is contacted over catch-all circuit
Bug 32321
: Disable Mozilla's MitM pings

Bug
Tor Browser warning: "Your Firefox is out of date."
Bug 19890
: Disable installation of system addons

By setting the URL to "" we make sure that already installed system addons get deleted as well.

BugFingerprinting
Firefox downgrades VP9 videos to VP8 when measured performance is not enough
Bug 22548
: Firefox downgrades VP9 videos to VP8.

On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8.

This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available".

AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-central
Bug 25741
- TBA: Add mobile-override of 000-tor-browser prefs

BugBugSmashFundSecurityUX
8-month-old Tor Browser offers to "Reset Tor Browser", removes extensions
Bug 16441
: Suppress "Reset Tor Browser" prompt.

BugDisk LeakUX
Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable
Bug 29120
: Use the in-memory media cache and increase its maximum size.

BugNext
Investigate new Search Engine configuration
Bug 33697
: use old search config based on list.json

Bug
Don't use site's icon as window icon in Windows when in private browsing mode
Bug 33855
: Ensure that site-specific browser mode is disabled.

Feature
Adapt Intermediate Preloading for Tor Browser
Bug 30682
: Disable Intermediate CA Preloading.

Fingerprinting
ensure that Windows default browser agent is omitted
Bug 40061
: Omit the Windows default browser agent from the build

Backport
Consider disabling network.connectivity-service.enabled
Bug 40322
: Consider disabling network.connectivity-service.enabled

Set svg.context-properties.content.allowed-domains as emptyBug 40408: Disallow SVG Context Paint in all web content

Doing
Set privacy.partition.network_state = false until we evaluate dFPI
Bug 40308
: Disable network partitioning until we evaluate dFPI

Backport
Consider disabling network.connectivity-service.enabled
Bug 40322
: Consider disabling network.connectivity-service.enabled

Disable dom.enable_event_timingBug 40383: Disable dom.enable_event_timing

Flip network.http.http3.enabledBug 40423: Disable http/3

Doing
Clean up obsolete preferences in our 000-tor-browser.js
Bug 40177
: Update prefs for Fx91esr

User Feedback
Switch Firefox recommendations off by default
Bug 40700
: Disable addons and features recommendations

Doing
Set network.proxy.allow_bypass to false
Bug 40682
: Disable network.proxy.allow_bypass

DoingFingerprintingLinkability
3rd-party cookies are not disabled anymore in Tor Browser 11
Bug 40736
: Disable third-party cookies in PBM

FeatureFor Network Health TeamNeeds DesignSecurityUX
Disable Plaintext HTTP Clearnet Connections
Bug 19850
: Enabled HTTPS-Only by default

NextQ2UXUser Feedback
Hide screenshots menu since we don't support it
Bug 40912
: Hide the screenshot menu

DoingProject 131Q3UX
moreFromMozilla pane in about:preferences in 12.0a2
Bug 41292
: Disable moreFromMozilla in preferences page

All PlatformsApps::Impact::HighApps::Type::InvestigationFingerprintingProject 131Roadmap::FutureTask
ensure that CSS4 system colors are not a fingerprinting vector
Bug 40057
: Ensure the CSS4 system colors are not a fingerprinting vector

DoingFeatureFingerprintingLinkabilityProject 131Q4esr-102
In Tor Browser context, should network.http.tailing.enabled be set to false?
Bug 24686
: Set network.http.tailing.enabled to true

Project 131Taskesr-102
Consider disabling TLS ciphersuites containing SHA-1
Bug 40183
: Disable TLS ciphersuites using SHA-1

Project 131Q4Taskesr-102
Review 000-tor-browser.js and 001-base-profile.js for 102
Bug 40783
: Review 000-tor-browser.js and 001-base-profile.js for 102

We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them.

Author: Mike Perry, 2013-09-10 18:20:43 -0700
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:34 +0200
adacb2c3 n
fixup! All PlatformsApps::Impact::HighApps::Type::MetaNoScriptProject 131Roadmap::Future
Improve NoScript and Browser integration
Bug 40925
: Implemented the Security Level component

DesktopDoingTask
Customize the default CustomizableUI toolbar using CustomizableUI.jsm
Bug 41736
- Stop setting the browser.uiCustomization.state preference.

Author: Henry Wilkes, 2023-04-19 14:49:42 +0100
Committer: Richard Pospesel, 2023-04-20 20:03:08 +0000
0c345330 n
fixup! All PlatformsApps::Impact::HighApps::Type::MetaNoScriptProject 131Roadmap::Future
Improve NoScript and Browser integration
Bug 40925
: Implemented the Security Level component

Add cui-widget-panel class to the panel, which gives it the correct font.

Author: Henry Wilkes, 2023-03-31 17:17:19 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 15:31:59 +0200
3caac79e n
All PlatformsApps::Impact::HighApps::Type::MetaNoScriptProject 131Roadmap::Future
Improve NoScript and Browser integration
Bug 40925
: Implemented the Security Level component

This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.

Geckoview: Expose security level interfaceBug 40125: Expose Security Level pref in GeckoView

Author: Pier Angelo Vendrame, 2022-07-08 16:19:41 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:42 +0200
d354800c n
fixup! Project 131Roadmap::Future
Migrate New Identity feature from torbutton to firefox
Bug 40926
: Implemented the New Identity feature

DesktopDoingTask
Customize the default CustomizableUI toolbar using CustomizableUI.jsm
Bug 41736
- Stop setting the browser.uiCustomization.state preference.

Author: Henry Wilkes, 2023-04-19 14:45:44 +0100
Committer: Richard Pospesel, 2023-04-20 20:03:08 +0000
b53567eb n
fixup! Project 131Roadmap::Future
Migrate New Identity feature from torbutton to firefox
Bug 40926
: Implemented the New Identity feature

BugDesktop
Race condition when opening a new window in New Identity
Bug 41711
: Wait for the new window when doing new identity

Author: Pier Angelo Vendrame, 2023-03-31 15:51:44 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 15:32:00 +0200
622db29f n
Project 131Roadmap::Future
Migrate New Identity feature from torbutton to firefox
Bug 40926
: Implemented the New Identity feature
Author: Pier Angelo Vendrame, 2022-07-25 10:40:35 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 15:31:59 +0200
7cf4e447 n
fixup! LocalizationProject 131Q1UX
Prompt users to restart after changing language
Bug 41417
: Always prompt users to restart after changing language

Replace the patch to disable live reload with its preferenceBug 41738: Drop the patch to disable live reload

Revert "LocalizationProject 131Q1UX
Prompt users to restart after changing language
Bug 41417
: Always prompt users to restart after changing language"

This reverts commit bad85a459ea24b34f3c09924c6d2b9f0bc750d88.

Author: Pier Angelo Vendrame, 2023-04-19 17:18:54 +0200
Committer: Pier Angelo Vendrame, 2023-04-20 20:16:02 +0200
bad85a45 n
LocalizationProject 131Q1UX
Prompt users to restart after changing language
Bug 41417
: Always prompt users to restart after changing language

This is a temporary patch that we need until we switch our strings to Fluent. The reason is that we currently set strings when we populate our XUL content. We could rework the whole mechanism, but it is not worth it because we want to switch to Fluent, which will handle everything automatically.

Author: Pier Angelo Vendrame, 2022-11-04 14:10:49 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:33 +0200
337dcb91 n
fixup! Add TorStrings module for localization

DesktopDoingFeatureQ2Sponsor 30 - FINISHEDUX
“Show Fewer Bridges” button missing from refactored remove all bridges UI
Bug 41714
- Add settings.bridgeShowFewer string.

Author: Henry Wilkes, 2023-04-19 16:36:58 +0100
Committer: Pier Angelo Vendrame, 2023-04-20 09:21:20 +0000
64ea04a6 n
fixup! Add TorStrings module for localization

12.5 stableDesktopDoingFeatureQ1Sponsor 30 - FINISHEDUX
Improve the UX of the built-in bridges dialog
Bug 41617
- Tidy up:

  • Use new string ids for the new strings. Mark the old ones for removal.
  • Use "website" rather than "web site".
Author: Henry Wilkes, 2023-04-17 15:13:21 +0100
Committer: Henry Wilkes, 2023-04-17 15:23:13 +0100
84b47639 n
fixup! Add TorStrings module for localization

12.5 stableDesktopDoingFeatureQ1Sponsor 30 - FINISHEDUX
Improve the UX of the built-in bridges dialog
Bug 41617
: Improve the UX of the built-in bridges dialog

Author: Dan Ballard, 2023-04-12 18:18:25 -0500
Committer: Richard Pospesel, 2023-04-14 20:35:41 +0000
f518efb1 n
fixup! Add TorStrings module for localization

DesktopDoingFeatureQ2Sponsor 30 - FINISHEDUX
“Show Fewer Bridges” button missing from refactored remove all bridges UI
Bug 41714
: 'Show Fewer Bridges' button missing from refactored remove all bridges UI

Author: Dan Ballard, 2023-04-11 11:14:35 -0500
Committer: Richard Pospesel, 2023-04-14 20:01:32 +0000
87ddea9a n
fixup! Add TorStrings module for localization

12.5 stableDesktopFeatureNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Improve security warning when downloading a file
Bug 40701
: Improve security warning when downloading a file Add strings for new pane, flag deprecated strings

12.5 stableDesktopFeatureNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Improve security warning when downloading a file
Bug 40701
: fix capitalization of 'internet'

Author: Dan Ballard, 2023-03-31 12:14:17 -0500
Committer: Richard Pospesel, 2023-04-13 16:17:40 +0000
4491a2de n
fixup! Add TorStrings module for localization

DesktopQ1Task
Improve localization notes
Bug 41521
: Improve localization notes

Author: Pier Angelo Vendrame, 2023-03-30 08:59:04 +0200
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:45 +0200
6ace50bf n
fixup! Add TorStrings module for localization Author: Henry Wilkes, 2023-04-05 15:42:42 +0100
Committer: Pier Angelo Vendrame, 2023-04-05 17:29:27 +0200
04ddfd20 n
fixup! Add TorStrings module for localization

12.5 stableBugCircuit DisplayDesktopDoingNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Some users have difficulty finding the circuit display
Bug 41600
- Add new strings for the circuit display.

Author: Henry Wilkes, 2023-03-24 17:54:15 +0000
Committer: Pier Angelo Vendrame, 2023-04-05 17:29:27 +0200
6818ecc5 n
fixup! Add TorStrings module for localization

Restore the letterbox warning for 12.0

Author: Pier Angelo Vendrame, 2023-03-29 17:47:40 +0200
Committer: Pier Angelo Vendrame, 2023-04-05 17:29:26 +0200
6a429e12 n
Add TorStrings module for localization Author: Alex Catarineu, 2020-07-24 21:15:20 +0200
Committer: Pier Angelo Vendrame, 2023-04-05 17:29:26 +0200
83901ef7 n
fixup! DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Tweaks to the Base Browser updater for Tor Browser

LinuxTaskWindows
UpdateInfo jumped into Data
Bug 41654
: Fix the UpdateInfo directory path

Author: Pier Angelo Vendrame, 2023-04-05 19:15:16 +0200
Committer: Pier Angelo Vendrame, 2023-04-20 08:58:35 +0200
aef119cb n
DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Tweaks to the Base Browser updater for Tor Browser

This commit was once part of "SecurityTaskUX
Deploy experimental builds using the Firefox update process
Bug 4234
: Use the Firefox Update Process for Tor Browser.". However, some parts of it were not needed for Base Browser and some derivative browsers. Therefore, we extracted from that commit the parts for Tor Browser legacy, and we add them back to the patch set with this commit.

Author: Pier Angelo Vendrame, 2023-03-13 11:16:32 +0100
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:56 +0200
  • RESOLVED FIXED, [tor 4234]
    Add -q option to MAR generation scripts
    Bug 1641329
07d2f3f1 n
fixup! SecurityTaskUX
Deploy experimental builds using the Firefox update process
Bug 4234
: Use the Firefox Update Process for Base Browser.

LinuxTaskWindows
UpdateInfo jumped into Data
Bug 41654
: Move UpdateInfo into Data again

Author: Pier Angelo Vendrame, 2023-04-05 09:56:57 +0200
Committer: Pier Angelo Vendrame, 2023-04-20 08:58:20 +0200
cfc9319e n
fixup! SecurityTaskUX
Deploy experimental builds using the Firefox update process
Bug 4234
: Use the Firefox Update Process for Base Browser.

DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Port some updater patches to Base Browser

Fix a build error on Windows.

Author: Pier Angelo Vendrame, 2023-03-23 14:11:40 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:39 +0200
32b0c6ed n
fixup! SecurityTaskUX
Deploy experimental builds using the Firefox update process
Bug 4234
: Use the Firefox Update Process for Base Browser.

DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Port some updater patches to Base Browser

Remove Tor Browser-only additions to make the updater patches usable with Base Browser. This commit should be reverted, and become a commit on its own, to further adapt the updater to Tor Browser needs.

Author: Pier Angelo Vendrame, 2023-03-13 11:11:19 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:39 +0200
a6ab4b56 n
fixup! SecurityTaskUX
Deploy experimental builds using the Firefox update process
Bug 4234
: Use the Firefox Update Process for Base Browser.

DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Port some updater patches to Base Browser

Changes that will need to remain when actually cherry-picking to base-browser, because they contain name fixes, for example. Or, for UpdateService.jsm, they need to stay because they make the patch more understandable.

Author: Pier Angelo Vendrame, 2023-03-10 18:36:05 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:39 +0200
f325a6bc n
fixup! SecurityTaskUX
Deploy experimental builds using the Firefox update process
Bug 4234
: Use the Firefox Update Process for Base Browser.

DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Port some updater patches to Base Browser

Rename TOR_BROWSER_UPDATE to BASE_BROWSER_UPDATE. Also, do not change app.update.auto in firefox.js, but add it to 001.

Author: Pier Angelo Vendrame, 2023-03-09 10:58:40 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:38 +0200
27e74537 n
fixup! SecurityTaskUX
Deploy experimental builds using the Firefox update process
Bug 4234
: Use the Firefox Update Process for Base Browser.

DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Port some updater patches to Base Browser

Move the check on the update package version to this other commit.

Author: Pier Angelo Vendrame, 2023-03-08 18:17:08 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:38 +0200
1a2f12fb n
fixup! SecurityTaskUX
Deploy experimental builds using the Firefox update process
Bug 4234
: Use the Firefox Update Process for Base Browser.

All PlatformsTask
Turn --enable-base-browser in --with-base-browser-version
Bug 41647
: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros

Changed TOR_BROWSER_VERSION with BASE_BROWSER_VERSION.

Author: Pier Angelo Vendrame, 2023-03-02 15:43:27 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:37 +0200
136387cd n
SecurityTaskUX
Deploy experimental builds using the Firefox update process
Bug 4234
: Use the Firefox Update Process for Base Browser.

Windows: disable "runas" code path in updater (15201). Windows: avoid writing to the registry (16236). Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406, 16014, 16909, 24476, and 25909.

Also fix Bug
Tor Browser 8.0a10 wants to update to 8.0a10
bug 27221
: purge the startup cache if the Base Browser version changed (even if the Firefox version and build ID did not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug
potentially confusing "restart to update" message in ESR60
Bug 26048
: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions that windows will be restored after an update is applied, and replace the "Restart and Restore" button label with an existing "Restart to update Tor Browser" string.

BugBugSmashFundUXUpdater
notify users that update is downloading
Bug 28885
: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the hamburger (app) menu while the update service is downloading a MAR file. Before this change, the browser did not indicate to the user that an update was in progress, which is especially confusing in Tor Browser because downloads often take some time. If the user clicks on the new menu item, the about dialog is opened to allow the user to see download progress.

As part of this fix, the update service was changed to always show update-related messages in the hamburger menu, even if the update was started in the foreground via the about dialog or via the "Check for Tor Browser Update" toolbar menu item. This change is consistent with the Tor Browser goal of making sure users are informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

Author: Kathy Brade, 2017-01-13 11:40:24 -0500
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:37 +0200
c a0b015c4 n
RESOLVED FIXED(Fx114)
Wrong visibility for bundled fonts with font-list.shared true on Linux
Bug 1792157
- Ensure correct font-visibility for bundled fonts on Linux when they 'shadow' system-installed families. r=gfx-reviewers,lsalzman

Differential Revision: https://phabricator.services.mozilla.com/D175350

Author: Jonathan Kew, 2023-04-14 21:48:18 +0000
Committer: Pier Angelo Vendrame, 2023-04-17 19:00:43 +0200
d2c3dcac n
fixup! BugSmashFundTaskUX
Include bridge configuration into about:preferences
Bug 31286
: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

12.5 stableDesktopDoingFeatureQ1Sponsor 30 - FINISHEDUX
Improve the UX of the built-in bridges dialog
Bug 41617
- Tidy up:

  • Lint builtinBridgeDialog.jsm and connectionPane.js.
  • Use TorConnect.canBeginBootstrap.
  • Always start Bootstrapping with the built in bridges, regardless of a previous errors.
  • Wait until settings have been applied before starting bootstrap.
  • Use new string ids for the new strings. Mark the old ones for removal.
  • Clean up unused properties.
Author: Henry Wilkes, 2023-04-17 11:13:09 +0100
Committer: Henry Wilkes, 2023-04-17 15:10:44 +0100
f0df6486 n
fixup! BugSmashFundTaskUX
Include bridge configuration into about:preferences
Bug 31286
: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

12.5 stableDesktopDoingFeatureQ1Sponsor 30 - FINISHEDUX
Improve the UX of the built-in bridges dialog
Bug 41617
: Improve the UX of the built-in bridges dialog

Author: Dan Ballard, 2023-04-12 18:21:24 -0500
Committer: Richard Pospesel, 2023-04-14 21:02:03 +0000
314794b1 n
fixup! BugSmashFundTaskUX
Include bridge configuration into about:preferences
Bug 31286
: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

DesktopDoingFeatureQ2Sponsor 30 - FINISHEDUX
“Show Fewer Bridges” button missing from refactored remove all bridges UI
Bug 41714
: 'Show Fewer Bridges' button missing from refactored remove all bridges UI. 12.5 stableBugDesktopDoingQ2Sponsor 30 - FINISHEDUX
“Remove All Bridges” button only appears after hitting “Show All Bridges"
Bug 41713
: 'Remove All Bridges' button only appears after hitting 'Show All Bridges'

Author: Dan Ballard, 2023-04-11 12:39:43 -0500
Committer: Richard Pospesel, 2023-04-14 20:01:32 +0000
203f9488 n
fixup! BugSmashFundTaskUX
Include bridge configuration into about:preferences
Bug 31286
: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

12.5 stableDesktopDoingFeatureQ1UX
Improve the UX of the location bar's connection status
Bug 41608
- Use TorConnect.canBeginBootstrap and TorConnect.canBeginAutoBootstrap and use bootstrapping options in openAboutTor.

Selecting a location in the preferences now also opens "about:torconnect".

Author: Henry Wilkes, 2023-04-06 10:58:26 +0100
Committer: Richard Pospesel, 2023-04-13 19:07:41 +0000
60d18fa7 n
fixup! BugSmashFundTaskUX
Include bridge configuration into about:preferences
Bug 31286
: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

12.5 stableDesktopDoingFeatureQ1UX
Improve the UX of the location bar's connection status
Bug 41608
- Tidy up the TorConnect API for broad error states that the different UI components can share.

No longer import TorMonitorService, and just use TorConnect instead.

  • Use TorConnect.enabled to determine whether to show the settings.
  • Use TorConnect.hasEverFailed state rather than TorMonitorService.bootstrapErrorOccurred to determine whether to show "Try Again".
  • Use TorConnect.potentiallyBlocked to determine whether to show the location selector. E.g. we don't want to show this if we just failed an internet connection test.
Author: Henry Wilkes, 2023-04-05 17:31:50 +0100
Committer: Richard Pospesel, 2023-04-13 19:07:39 +0000
5c63c357 n
fixup! BugSmashFundTaskUX
Include bridge configuration into about:preferences
Bug 31286
: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

BugDesktop
Stray connectionPane.xhtml patch
Bug 41725
- Changes to connectionPane.xhtml have been moved from:

  • BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
    Remove gap between Tor Launcher window and main browser window
    Bug 27476
    : Implement about:torconnect captive portal within Tor Browser
Author: Henry Wilkes, 2023-04-11 09:42:57 +0100
Committer: Richard Pospesel, 2023-04-13 17:18:45 +0000
2e59d64a n
fixup! BugSmashFundTaskUX
Include bridge configuration into about:preferences
Bug 31286
: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

12.5 stableBugCircuit DisplayDesktopDoingNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Some users have difficulty finding the circuit display
Bug 41600
- Update the SVG fetch update script for fetching bridge emojis and annotations, which we will also use for the flag emojis in the tor circuit display.

We also:

  • Placed the bridgemoji files in a sub-directory.
  • Added a generation note to the generated files/directory.
  • Split the bridge emoji list into an external file, which we fetch in connectionPane.js so that the generating file is less fragile to a change in the javascript.
  • Store the locale emoji annotations using the string hex value as the key, rather than the emoji string sequence. This keeps it in line with the SVG file names, and removes ambiguity about whether the emoji character sequence includes the emoji variant selector U+FE0F or not.
Author: Henry Wilkes, 2023-04-03 13:29:35 +0100
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:53 +0200
803622ff n
BugSmashFundTaskUX
Include bridge configuration into about:preferences
Bug 31286
: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

This patch adds a new about:preferences#connection page which allows modifying bridge, proxy, and firewall settings from within Tor Browser. All of the functionality present in tor-launcher's Network Configuration panel is present:

  • Setting built-in bridges
  • Requesting bridges from BridgeDB via moat
  • Using user-provided bridges
  • Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
  • Setting firewall ports
  • Viewing and Copying Tor's logs
  • The Networking Settings in General preferences has been removed

DoingQ2Sponsor 30 - FINISHEDUX
Update about:preferences page to match new UI designs
Bug 40774
: Update about:preferences page to match new UI designs

Author: Richard Pospesel, 2019-09-16 15:25:39 -0700
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:53 +0200
adfc97d5 n
fixup! Backport
Add tor-browser build scripts + Makefile to tor-browser
Bug 41089
: Add tor-browser build scripts + Makefile to tor-browser

Build SystemDesktopDoing
Bridge lines in tools/torbrowser/bridges.js out of date
Bug 41730
: Bridge lines in tools/torbrowser/bridges.js out of date

Author: Richard Pospesel, 2023-04-14 19:47:31 +0000
Committer: Richard Pospesel, 2023-04-14 19:47:31 +0000
0fb7d24e n
fixup! Backport
Add tor-browser build scripts + Makefile to tor-browser
Bug 41089
: Add tor-browser build scripts + Makefile to tor-browser

AndroidBuild System
Android improvements for local dev builds
Bug 41684
: Fix Android mozconfigs for local dev builds

The shell script matched x86 with x86_64. I do not know how to match an entire token in shell scripts, so I switched to a Python script, instead.

Author: Pier Angelo Vendrame, 2023-03-21 11:05:37 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 15:32:01 +0200
bf2a9526 n
Backport
Add tor-browser build scripts + Makefile to tor-browser
Bug 41089
: Add tor-browser build scripts + Makefile to tor-browser
Author: Richard Pospesel, 2022-08-01 17:56:45 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 15:32:00 +0200
e109bbd2 n
fixup! BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
Remove gap between Tor Launcher window and main browser window
Bug 27476
: Implement about:torconnect captive portal within Tor Browser

12.5 stableDesktopDoingFeatureQ1UX
Improve the UX of the location bar's connection status
Bug 41608
- Remove the FatalError state since it is not defined in TorConnect.

Author: Henry Wilkes, 2023-03-30 15:53:07 +0100
Committer: Richard Pospesel, 2023-04-13 19:07:42 +0000
b652316e n
fixup! BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
Remove gap between Tor Launcher window and main browser window
Bug 27476
: Implement about:torconnect captive portal within Tor Browser

12.5 stableDesktopDoingFeatureQ1UX
Improve the UX of the location bar's connection status
Bug 41608
- Tidy up the TorConnect API for broad error states that the different UI components can share.

Just use the HasEverFailed state to determine whether to show "Try Again" or to show breadcrumbs.

Author: Henry Wilkes, 2023-04-05 17:23:08 +0100
Committer: Richard Pospesel, 2023-04-13 19:07:39 +0000
2f760c56 n
dropme! BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
Remove gap between Tor Launcher window and main browser window
Bug 27476
: Implement about:torconnect captive portal within Tor Browser

BugDesktop
Stray connectionPane.xhtml patch
Bug 41725
- Changes to connectionPane.xhtml have been moved to:

  • BugSmashFundTaskUX
    Include bridge configuration into about:preferences
    Bug 31286
    : Implementation of bridge, proxy, and firewall settings in about:preferences#connection
Author: Henry Wilkes, 2023-04-11 09:41:55 +0100
Committer: Richard Pospesel, 2023-04-13 17:18:45 +0000
15320bca n
fixup! BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
Remove gap between Tor Launcher window and main browser window
Bug 27476
: Implement about:torconnect captive portal within Tor Browser
Author: hackademix, 2023-03-29 12:33:11 +0200
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:55 +0200
3451137b n
fixup! BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
Remove gap between Tor Launcher window and main browser window
Bug 27476
: Implement about:torconnect captive portal within Tor Browser

DesktopDoingProject 96 - FINISHEDQ1UX
"Cancel" button when establishing a connection should be grey
bug 41526
: make tor connection cancel button grey

Author: Dan Ballard, 2023-03-15 13:36:18 -0500
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:54 +0200
433dd49e n
BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
Remove gap between Tor Launcher window and main browser window
Bug 27476
: Implement about:torconnect captive portal within Tor Browser
  • implements new about:torconnect page as tor-launcher replacement
  • adds tor connection status to url bar and tweaks UX when not online
  • adds new torconnect component to browser
  • tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
  • adds warning/error box to about:preferences#tor when not connected to tor
  • explicitly allows about:torconnect URIs to ignore Resist Fingerprinting (RFP)
  • various tweaks to info-pages.inc.css for about:torconnect (also affects other firefox info pages)

DoingProject 96 - FINISHEDQ2UX
Update the about:torconnect frontend page to match additional UI flows
Bug 40773
: Update the about:torconnect frontend page to match additional UI flows

Author: Richard Pospesel, 2021-04-28 23:09:34 -0500
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:54 +0200
2a8e78df n
fixup! DoingSponsor 30 - FINISHED
Create TorSettings module to handle modifying all tor daemon settings
Bug 40597
: Implement TorSettings module

12.5 stableDesktopDoingFeatureQ1UX
Improve the UX of the location bar's connection status
Bug 41608
- Add the canBeginBootstrap and canBeginAutoBootstrap properties to determine whether it is possible to enter the corresponding TorConnectState from the current state.

Add options to openTorConnect to begin bootstrapping or auto-bootstrapping once opened.

Author: Henry Wilkes, 2023-04-06 10:57:37 +0100
Committer: Richard Pospesel, 2023-04-13 19:07:41 +0000
d6c9dd4f n
fixup! DoingSponsor 30 - FINISHED
Create TorSettings module to handle modifying all tor daemon settings
Bug 40597
: Implement TorSettings module

12.5 stableDesktopDoingFeatureQ1UX
Improve the UX of the location bar's connection status
Bug 41608
- Remove unused TorMonitorService.bootstrapErrorOccurred

Author: Henry Wilkes, 2023-04-05 18:03:26 +0100
Committer: Richard Pospesel, 2023-04-13 19:07:40 +0000
1222e90d n
fixup! DoingSponsor 30 - FINISHED
Create TorSettings module to handle modifying all tor daemon settings
Bug 40597
: Implement TorSettings module

12.5 stableDesktopDoingFeatureQ1UX
Improve the UX of the location bar's connection status
Bug 41608
- Tidy up the TorConnect API for broad error states that the different UI components can share.

Rename the hasBootstrapEverFailed to potentiallyBlocked as a specific failure state.

Add the hasEverFailed boolean property as a catch-all failure state.

Add an enabled boolean property, which just maps to whether we own the tor process.

Author: Henry Wilkes, 2023-04-05 17:23:08 +0100
Committer: Richard Pospesel, 2023-04-13 19:07:38 +0000
3ff3442d n
DoingSponsor 30 - FINISHED
Create TorSettings module to handle modifying all tor daemon settings
Bug 40597
: Implement TorSettings module
  • migrated in-page settings read/write implementation from about:preferences#tor to the TorSettings module
  • TorSettings initially loads settings from the tor daemon, and saves them to firefox prefs
  • TorSettings notifies observers when a setting has changed; currently only QuickStart notification is implemented for parity with previous preference notify logic in about:torconnect and about:preferences#tor
  • about:preferences#tor, and about:torconnect now read and write settings thorugh the TorSettings module
  • all tor settings live in the torbrowser.settings.* preference branch
  • removed unused pref modify permission for about:torconnect content page from AsyncPrefs.jsm

Needs ReviewProject 96 - FINISHED
Implement new Moat apis in Moat.jsm module
Bug 40645
: Migrate Moat APIs to Moat.jsm module

Author: Richard Pospesel, 2021-08-06 16:39:03 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 19:46:07 +0200
9fe1259d n
fixup! Project 131
Migrate remaining tor-launcher functionality to tor-browser
Bug 40933
: Add tor-launcher functionality

12.5 stableDesktopDoingFeatureQ1UX
Improve the UX of the location bar's connection status
Bug 41608
- Remove unused TorMonitorService.bootstrapErrorOccurred

Author: Henry Wilkes, 2023-04-05 18:02:41 +0100
Committer: Richard Pospesel, 2023-04-13 19:07:40 +0000
530b2162 n
fixup! Project 131
Migrate remaining tor-launcher functionality to tor-browser
Bug 40933
: Add tor-launcher functionality

BugDesktop
sendCommand should not try to send a command forever
Bug 41709
: Reimplement the failure logic for TorProtocolService.sendCommand

sendCommand tries to send a command forever every 250ms in case of failure. That is bad because some async code branch might be stuck in it forever.

We should have a number of maximum attempts and increase the delay after which we try again.

Author: Pier Angelo Vendrame, 2023-03-31 16:40:03 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 19:45:50 +0200
eb71bc29 n
Project 131
Migrate remaining tor-launcher functionality to tor-browser
Bug 40933
: Add tor-launcher functionality
Author: Pier Angelo Vendrame, 2022-10-10 15:13:04 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 16:15:03 +0200
9d585beb n
fixup! DesktopFingerprintingProject 131
Port warning on maximized windows without letterboxing from torbutton
Bug 41695
: Warn on window maximization without letterboxing in RFPHelper module
Author: hackademix, 2023-04-11 09:06:28 +0200
Committer: Richard Pospesel, 2023-04-13 18:55:46 +0000
c9cdba48 n
DesktopFingerprintingProject 131
Port warning on maximized windows without letterboxing from torbutton
Bug 41695
: Warn on window maximization without letterboxing in RFPHelper module
Author: hackademix, 2023-03-24 19:40:19 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:41 +0200
7c7f1d72 n
12.5 stableDesktopFeatureNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Improve security warning when downloading a file
Bug 40701
: Add in pane security warning when downloading a file
Author: Dan Ballard, 2023-03-31 12:35:17 -0500
Committer: Richard Pospesel, 2023-04-13 16:17:41 +0000
627eab30 n
Revert "TaskUX
Write C++ patch to replace external applications helper dialog workaround
Bug 19273
: Avoid JavaScript patching of the external app helper dialog."

12.5 stableDesktopFeatureNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Improve security warning when downloading a file
Bug 40701
: Improve security warning when downloading a file This reverts commit 5d003f7c5e0910c8e0c6f4e55a0ca7aa002faad1.

Author: Dan Ballard, 2023-04-03 11:19:41 -0500
Committer: Richard Pospesel, 2023-04-13 16:15:53 +0000
ac746744 n
TaskUX
Write C++ patch to replace external applications helper dialog workaround
Bug 19273
: Avoid JavaScript patching of the external app helper dialog.

When handling an external URI or downloading a file, invoke Torbutton's external app blocker component (which will present a download warning dialog unless the user has checked the "Automatically download files from now on" box).

For e10s compatibility, avoid using a modal dialog and instead use a callback interface (nsIHelperAppWarningLauncher) to allow Torbutton to indicate the user's desire to cancel or continue each request.

Other bugs fixed: Bug
Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file
Bug 21766
: Crash with e10s enabled while trying to download a file BugUX
Downloading of binary files stalls at 0/0 bytes in Tor Browser based on ESR52 with e10s off
Bug 21886
: Download is stalled in non-e10s mode Bug
Downloading pdf files with the download button in the pdf viewer is stalling
Bug 22471
: Downloading files via the PDF viewer download button is broken Bug
Handle downloads via FTP better when external helper app dialog is shown
Bug 22472
: Fix FTP downloads when external helper app dialog is shown Bug
Tor Browser 7 crashes when cancelling downloads on the external helper app warning
Bug 22610
: Avoid crashes when canceling external helper app downloads Bug
Downloading pdf file via file:/// is stalling if the external helper dialog is enabled
Bug 22618
: Downloading pdf file via file:/// is stalling

Author: Kathy Brade, 2016-06-28 15:13:05 -0400
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:52 +0200
c 4d0bea87 n
RESOLVED FIXED(Fx112), Blocks: 1729514, 1758541, [post-critsmash-triage][adv-main112+]
js::gc::detail::CellHasStoreBuffer (cell=0xe5e5e5e5e5e5e5e5)
Bug 1816158
- Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink

To prevent any other instances of this problme we can update the getDebuggers() methods on the global and the realm to require no GC.

Depends on D169701

Differential Revision: https://phabricator.services.mozilla.com/D169702

Author: Jon Coppeard, 2023-02-14 10:32:47 +0000
Committer: Richard Pospesel, 2023-04-12 16:35:06 +0000
64b502e0 n
RESOLVED FIXED(Fx112), Blocks: 1729514, 1758541, [post-critsmash-triage][adv-main112+]
js::gc::detail::CellHasStoreBuffer (cell=0xe5e5e5e5e5e5e5e5)
Bug 1816158
- Part 1: Disallow GC while iterating global's debugger vector r=sfink

GC can mutate this vector so don't allow that while we are iterating. I think it would be safe to use index-based iteration but it's safer to just ban it entirely.

This fixes the crash produced by the testcase.

Differential Revision: https://phabricator.services.mozilla.com/D169701

Author: Jon Coppeard, 2023-02-14 10:32:47 +0000
Committer: Richard Pospesel, 2023-04-12 16:35:05 +0000
c 6957f008 n
VERIFIED FIXED(Fx112), Blocks: 1339970, [reporter-external] [client-bounty-form] [verif?][post-critsmash-triage][adv-main112+]
allow-top-navigation-to-custom-protocols iframe sandbox bypass using sourceMappingUrls
Bug 1790542
- [devtools] Convert browser_source_map-reload.js test from using .sjs files to createTestHTTPServer r=ochameau,devtools-reviewers

.sjs files depend on redirects to load static files. In D168648 we block redirects on sourceMappingUrl, so this browser_source_map-reload.js fails because we use .sjs to serve the content.

This patch refactors to no longer use .sjs files

Differential Revision: https://phabricator.services.mozilla.com/D169739

Author: Hubert Boma Manilla, 2023-03-07 16:26:41 +0000
Committer: Richard Pospesel, 2023-04-12 16:35:05 +0000
1ef8ee04 n
VERIFIED FIXED(Fx112), Blocks: 1339970, [reporter-external] [client-bounty-form] [verif?][post-critsmash-triage][adv-main112+]
allow-top-navigation-to-custom-protocols iframe sandbox bypass using sourceMappingUrls
Bug 1790542
- [devtools] Do not allow redirects on the 'sourceMappingUrl' r=jdescottes,devtools-reviewers
  • Block redirects on sourceMappingUrl
  • Add debugger test

Differential Revision: https://phabricator.services.mozilla.com/D168648

Author: Hubert Boma Manilla, 2023-03-07 16:26:41 +0000
Committer: Richard Pospesel, 2023-04-12 16:35:05 +0000
c 5d5d2455 n
RESOLVED FIXED(Fx112), [necko-triaged][necko-priority-queue][post-critsmash-triage][adv-main112+]
onLoadRequest contains translated jar:file:/// URI instead of moz-extension:///
Bug 1685403
- Use NS_GetFinalChannelURI at some places, r=necko-reviewers,valentin

Differential Revision: https://phabricator.services.mozilla.com/D164656

Author: Kershaw Chang, 2023-02-13 16:01:41 +0000
Committer: Richard Pospesel, 2023-04-12 16:35:04 +0000
307d5a84 n
DesktopLocalizationProject 131Taskesr-102
Should we remove previously installed langpacks?
Bug 41435
: Add a Tor Browser migration function

For now this function only deletes old language packs for which we are already packaging the strings with the application.

Author: Pier Angelo Vendrame, 2022-12-02 11:55:13 +0100
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:58 +0200
75a1ab1b n
For Anticensorship TeamMerge ReadyNeeds DesignProject 96 - FINISHEDQ2UX
Incorporate Tor Browser Manual pages into Tor Browser
Bug 11698
: Incorporate Tor Browser Manual pages into Tor Browser

This patch associates the about:manual page to a translated page that must be injected to browser/omni.ja after the build. The content must be placed in chrome/browser/content/browser/manual/, so that is then available at chrome://browser/content/manual/. We preferred giving absolute freedom to the web team, rather than having to change the patch in case of changes on the documentation.

Author: Pier Angelo Vendrame, 2022-05-05 20:15:01 +0200
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:57 +0200
8202b79d n
fixup! DoingQ2UX
Implement about:rulesets https-everywhere replacement
Bug 40458
: Implement .tor.onion aliases
Author: Henry Wilkes, 2023-03-28 11:57:18 +0100
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:57 +0200
06151bdd n
DoingQ2UX
Implement about:rulesets https-everywhere replacement
Bug 40458
: Implement .tor.onion aliases

We have enabled HTTPS-Only mode, therefore we do not need HTTPS-Everywhere anymore. However, we want to keep supporting .tor.onion aliases (especially for securedrop). Therefore, in this patch we implemented the parsing of HTTPS-Everywhere rulesets, and the redirect of .tor.onion domains. Actually, Tor Browser believes they are actual domains. We change them on the fly on the SOCKS proxy requests to resolve the domain, and on the code that verifies HTTPS certificates.

Author: Pier Angelo Vendrame, 2022-02-21 15:39:11 +0100
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:56 +0200
091b61a6 n
ProjectUX
Onion-location: increasing the use of onion services through automatic redirects and aliasing
Bug 21952
: Implement Onion-Location

Whenever a valid Onion-Location HTTP header (or corresponding HTML <meta> http-equiv attribute) is found in a document load, we either redirect to it (if the user opted-in via preference) or notify the presence of an onionsite alternative with a badge in the urlbar.

Author: Alex Catarineu, 2020-03-05 22:16:39 +0100
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:55 +0200
f7e09a92 n
Feature
Tor Browser: Improve TBB UI of hidden service client authorization
Bug 30237
: Add v3 onion services client authentication prompt

When Tor informs the browser that client authentication is needed, temporarily load about:blank instead of about:neterror and prompt for the user's key.

If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD control port command to add the key (via Torbutton's control port module) and reload the page.

If the user cancels the prompt, display the standard about:neterror "Unable to connect" page. This requires a small change to browser/actors/NetErrorChild.jsm to account for the fact that the docShell no longer has the failedChannel information. The failedChannel is used to extract TLS-related error info, which is not applicable in the case of a canceled .onion authentication prompt.

Add a leaveOpen option to PopupNotifications.show so we can display error messages within the popup notification doorhanger without closing the prompt.

Add support for onion services strings to the TorStrings module.

Add support for Tor extended SOCKS errors (Tor proposal 304) to the socket transport and SOCKS layers. Improved display of all of these errors will be implemented as part of ProjectUX
Objective 2, Activity 4: Better client-side errors
bug 30025
.

Also fixes BugBugSmashFundUX
Make a menu to add onion and auth-cookie to TB
bug 19757
: Add a "Remember this key" checkbox to the client auth prompt.

Add an "Onion Services Authentication" section within the about:preferences "Privacy & Security section" to allow viewing and removal of v3 onion client auth keys that have been stored on disk.

Also fixes FeatureUX
TorBrowser might want to have an error page specific to when .onion links fail
bug 19251
: use enhanced error pages for onion service errors.

Author: Kathy Brade, 2019-11-12 16:11:05 -0500
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:54 +0200
a85ccd69 n
fixup! ProjectUX
Communicating security expectations for .onion: what to say about different padlock states for .onion services
Bug 23247
: Communicating security expectations for .onion

BugDesktopOnion ServicesQ2esr-115
Page Info window for view-source:http://...onion addresses says Connection Not Encrypted
Bug 41533
: Fix onion detection on the page info window

Author: cypherpunks1, 2023-03-31 00:03:36 -0800
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:48 +0200
2a10ce02 n
ProjectUX
Communicating security expectations for .onion: what to say about different padlock states for .onion services
Bug 23247
: Communicating security expectations for .onion

Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine.

Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services:

  • HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure
  • HTTP Onion Service pages would be marked as unencrypted in the Page Info screen
  • Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content

This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.

Strings for Onion Service Page Info page are pulled from Torbutton's localization strings.

Author: Richard Pospesel, 2018-06-08 13:38:40 -0700
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:44 +0200
e8f3d8cc n
Doing
Consider disabling remote Public Suffix List fetching
Bug 40073
: Disable remote Public Suffix List fetching

In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want.

Author: Alex Catarineu, 2020-08-13 11:05:03 +0200
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:43 +0200
bbb721fe n
Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing

eBay and Amazon don't treat Tor users very well. Accounts often get locked and payments reversed.

Also: FeatureUX
Use duckduckgo hidden service instead of clearnet one
Bug 16322
: Update DuckDuckGo search engine

We are replacing the clearnet URL with an onion service one (thanks to a patch by a cypherpunk) and are removing the duplicated DDG search engine. Duplicating DDG happend due to VERIFIED FIXED(Fx36), Blocks: 1073292
Add DuckDuckGo to default search engine list
bug 1061736
where Mozilla included DDG itself into Firefox. Interestingly, this caused breaking the DDG search if JavaScript is disabled as the Mozilla engine, which gets loaded earlier, does not use the html version of the search page. Moreover, the Mozilla engine tracked where the users were searching from by adding a respective parameter to the search query. We got rid of that feature as well.

Also: This fixes FeatureUX
Use non-/html search engine URL for DuckDuckGo search plugins
bug 20809
: the DuckDuckGo team has changed its server-side code in a way that lets users with JavaScript enabled use the default landing page while those without JavaScript available get redirected directly to the non-JS page. We adapt the search engine URLs accordingly.

Also fixes Bug
build1 for Tor Browser 8.5a9 is broken in mobile packaging step
bug 29798
by making sure we only specify the Google search engine we actually ship an .xml file for.

Also regression tests.

squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing

First ContributionNextProject 131Q4esr-102
Update Startpage search provider
Bug 40494
: Update Startpage search provider

squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing

Backlog
Add Blockchair as a search engine
Bug 40438
: Add Blockchair as a search engine

Bug
Disconnect search addon causes error at startup
Bug 33342
: Avoid disconnect search addon error after removal.

We removed the addon in #32767, but it was still being loaded from addonStartup.json.lz4 and throwing an error on startup because its resource: location is not available anymore.

Author: Mike Perry, 2017-05-05 03:41:57 -0700
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:43 +0200
e70b349c n
BugSigning
Create new MAR signing key for Tor Browser
Bug 32658
: Create a new MAR signing key

It's time for our rotation again: Move the backup key in the front position and add a new backup key.

DoingSigningTaskUpdater
Generate a second mar signing key for nightly
Bug 33803
: Move our primary nightly MAR signing key to tor-browser

DoingSigningTaskUpdater
Generate a second mar signing key for nightly
Bug 33803
: Add a secondary nightly MAR signing key

Author: Georg Koppen, 2020-01-17 12:54:31 +0000
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:42 +0200
5f5ad377 n
fixup! Feature
Implement loading (only) local change notes after a Tor Browser update
Bug 16940
: After update, load local change notes.

DesktopQ1Task
Improve localization notes
Bug 41521
: Improve localization notes

Author: Pier Angelo Vendrame, 2023-04-06 10:24:37 +0200
Committer: Pier Angelo Vendrame, 2023-04-06 10:24:37 +0200
e2700887 n
Feature
Implement loading (only) local change notes after a Tor Browser update
Bug 16940
: After update, load local change notes.

Add an about:tbupdate page that displays the first section from TorBrowser/Docs/ChangeLog.txt and includes a link to the remote post-update page (typically our blog entry for the release).

Always load about:tbupdate in a content process, but implement the code that reads the file system (changelog) in the chrome process for compatibility with future sandboxing efforts.

Also fix TaskUXUpdater
Update about:tor when Tor Browser is updated
bug 29440
. Now about:tbupdate is styled as a fairly simple changelog page that is designed to be displayed via a link that is on about:tor.

Author: Kathy Brade, 2015-11-25 11:36:20 -0500
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:58 +0200
f229b892 n
Bug
reinstate the update.xml hash check
Bug 19121
: reinstate the update.xml hash check

This is a partial revert of commit f1241db6986e4b54473a1ed870f7584c75d51122.

Revert most changes from Mozilla RESOLVED FIXED(Fx43)
main thread I/O in update service
Bug 862173
"don't verify mar file hash when using mar signing to verify the mar file (lessens main thread I/O)."

We kept the addition to the AppConstants API in case other JS code references it in the future.

Author: Kathy Brade, 2016-05-20 11:08:51 -0400
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:57 +0200
1c0cc72e n
Bug
updater needs to support use of symlinks
Bug 12647
: Support symlinks in the updater.
Author: Kathy Brade, 2014-08-14 11:39:09 -0400
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:56 +0200
9b5887c6 n
Task
Rebase TBB patches to Firefox 31 and add unit tests
Bug 12620
: TorBrowser regression tests

Regression tests for MikePerryIteration20110515actualpoints::3component::firefox patch issuesowner::mikeperryparent::2877points::2priority::mediumresolution::fixedseverity::normalstatus::closedtype::defect
Make Permissions-Manager memory-only in TorBrowser
Bug #2950
: Make Permissions Manager memory-only

Regression tests for component::mixminion-clientowner::nickmpriority::lowresolution::fixedseverity::blockerstatus::closedtype::defectversion::0.0.4
Incorrect node routing with mbox
TB4
: Tor Browser's Firefox preference overrides.

Note: many more functional tests could be made here

Regression tests for #2874: Block Components.interfaces from content

Feature
Add a script in tor-browser.git to run all of our TBB-specific regression tests
Bug 18923
: Add a script to run all Tor Browser specific tests

Regression tests for BugBugSmashFundSecurityUX
8-month-old Tor Browser offers to "Reset Tor Browser", removes extensions
Bug #16441
: Suppress "Reset Tor Browser" prompt.

Author: Arthur Edelstein, 2014-08-27 16:25:00 -0700
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:56 +0200
e0d3a0ae n
fixup! fixup! BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
Remove gap between Tor Launcher window and main browser window
Bug 27476
: Implement about:torconnect captive portal within Tor Browser

DesktopDoingProject 96 - FINISHEDQ1UX
"Cancel" button when establishing a connection should be grey
Bug 41526
: revert removal of focus to cancle button + add prevention from keyboard input to trigger multiple buttons as focus switches

Author: Dan Ballard, 2023-03-31 15:28:32 -0500
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:55 +0200
49f44d37 n
Add a library for QR CodesBug 40807: Added QRCode.js to toolkit/modules Author: Pier Angelo Vendrame, 2022-02-17 12:17:25 +0100
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:53 +0200
bd6e41f4 n
BugBugSmashFundUX
Users that try to run from DMG files run into "Another copy of Firefox is running"
Bug 14631
: Improve profile access error messages.

Instead of always reporting that the profile is locked, display specific messages for "access denied" and "read-only file system".

To allow for localization, get profile-related error strings from Torbutton. Use app display name ("Tor Browser") in profile-related error alerts.

Author: Kathy Brade, 2015-02-24 13:50:23 -0500
Committer: Pier Angelo Vendrame, 2023-04-06 10:23:52 +0200
c01e2d5e n
AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-central
Bug 25741
: TBA: Disable GeckoNetworkManager

The browser should not need information related to the network interface or network state, tor should take care of that.

Author: Matthew Finkel, 2018-04-26 22:22:51 +0000
Committer: Pier Angelo Vendrame, 2023-04-05 17:29:26 +0200
d6147627 n
Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources.

See RESOLVED FIXED(Fx55), Blocks: 1357994, [tor-mobile]
Replace url.openConnection with ProxySelector.openConnectionWithProxy
Bug 1357997
for partial uplift.

Also: AndroidFeature
Build Orbot into TBA
Bug 28051
- Use our Orbot for proxying our connections

Proxy BypassTask
ESR68 Network Code Review
Bug 31144
- ESR68 Network Code Review

Author: Amogh Pradeep, 2015-06-12 02:07:45 -0400
Committer: Pier Angelo Vendrame, 2023-04-05 17:29:25 +0200
5c77f2c6 n
fixup! 12.5 stableBugCircuit DisplayDesktopDoingNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Some users have difficulty finding the circuit display
Bug 41600
- Add a tor circuit display panel.
Author: Henry Wilkes, 2023-04-05 15:45:04 +0100
Committer: Pier Angelo Vendrame, 2023-04-05 17:29:17 +0200
4046a658 n
12.5 stableBugCircuit DisplayDesktopDoingNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Some users have difficulty finding the circuit display
Bug 41600
: Add a tor circuit display panel.
Author: Henry Wilkes, 2023-03-08 14:37:38 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 19:46:09 +0200
b16f52f3 n
MikePerry201303actualpoints::6component::torbrowserbuttonowner::mikeperrypriority::very highresolution::fixedstatus::closedtbb-rebase-regressiontype::defect
Tor Browser 2.3.25-4 crashes with Drag and Drop on Windows
Bug 8324
: Prevent DNS proxy bypasses caused by Drag&Drop DesktopDoingFeatureLinkabilityProject 131Q1UX
Skip Drag & Drop filtering for DNS-safe URLs (no hostname, e.g. RFC3966 tel:)
Bug 41613
: Skip Drang & Drop filtering for DNS-safe URLs
Author: hackademix, 2022-12-12 21:09:15 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 19:46:09 +0200
61aa6e49 n
BugBugSmashFund
Tor Browser on OS X should not store data into the application bundle
Bug 13252
: Customize profile management on macOS

On macOS we allow both portable mode and system installation. However, in the latter case, we customize Firefox's directories to match the hierarchy we use for the portable mode.

Also, display an informative error message if the TorBrowser-Data directory cannot be created due to an "access denied" or a "read only volume" error.

Author: Pier Angelo Vendrame, 2023-01-31 11:59:21 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 16:15:03 +0200
1c21c713 n
Opt in to some of the NIGHTLY_BUILD featuresBug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds

DoingLocalizationProject 131Q4esr-102
Enable fluent warnings on nightly and dev builds
tor-browser#41285
: Enable fluent warnings.

Author: Henry Wilkes, 2022-09-30 15:04:37 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 16:15:01 +0200
33f8b246 n
component::mixminion-serverowner::nickmpriority::lowresolution::fixedstatus::closedtype::defectversion::0.0.4rc2
changing PublicKeyLifetime to smaller values isn't good
TB3
: Tor Browser's official .mozconfigs.

Also: Add an --enable-tor-browser-data-outside-app-dir configure option

Add --with-tor-browser-version configure option

BugBugSmashFund
disable per-installation profiles
Bug 31457
: disable per-installation profiles

The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data.

Bug
TB9.0a7 is asking for a new profile
Bug 31935
: Disable profile downgrade protection.

Since Tor Browser does not support more than one profile, disable the prompt and associated code that offers to create one when a version downgrade situation is detected.

Add --enable-tor-browser-update build option

Move our configure options from old-configure.in to moz.configureBug 40793: moved Tor configuration options from old-configure.in to moz.configure

All PlatformsProject 131Task
Move some configuration options to base-browser level
Bug 41584
: Move some configuration options to base-browser level

Author: Mike Perry, 2013-05-06 15:51:06 -0700
Committer: Pier Angelo Vendrame, 2023-04-04 16:15:01 +0200
288586cb n
UX
Warn the user when they copy a cryptocurrency address from a HTTP Website
Bug 40209
: Implement Basic Crypto Safety

Adds a CryptoSafety actor which detects when you've copied a crypto address from a HTTP webpage and shows a warning.

Closes #40209.

Correct minor Cryptocurrency warning string typoBug 40428: Fix string attribute names

Author: sanketh, 2021-02-08 20:12:44 -0500
Committer: Pier Angelo Vendrame, 2023-04-04 16:15:01 +0200
77cdb8c7 n
fixup! Bug
implement new user onboarding
Bug 26961
: New user onboarding.

12.5 stableBugCircuit DisplayDesktopDoingNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Some users have difficulty finding the circuit display
Bug 41600
- Change circuit display tour to use new button and panel.

This also fixes the "See My Path" button, which was broken before.

Author: Henry Wilkes, 2023-03-23 15:57:40 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 16:15:00 +0200
28f78753 n
Bug
implement new user onboarding
Bug 26961
: New user onboarding.

Reuse the Firefox onboarding mechanism with minimal changes. Localizable strings are pulled in from Torbutton (if Torbutton is not installed, we lack about:tor and no tour will be shown). Replace SVG images with PNGs (see BackportBug
always allow SVGs on about:* pages
bug 27002
), For defense in depth, omit include OnboardingTelemetry.jsm entirely. Added support for the following UITour page event: torBrowserOpenSecuritySettings

Also fix Bug
The onboarding bubble does not show up in the release candidate for Tor Browser
bug 27403
: the onboarding bubble is not always displayed.

Arthur suggested to make the onboarding bubble visible on displays with less than 960px width available, so we choose 200px instead.

Also fix BugUX
Introduce New Security Settings to users
bug 28628
: Change onboarding Security panel to open new Security Level panel.

Also fix BugUX
Onboarding: unintuitive not-navigation buttons, starting with "Circuit Display" / "See My Path"
bug 27484
: Improve navigation within onboarding.

Bug
enable a limited UITour
Bug 27082
: enable a limited UITour

Disallow access to UITour functionality from all pages other than about:home, about:newtab, and about:tor. Implement a whitelist mechanism for page actions.

Bug
implement new features onboarding
Bug 26962
- implement new features onboarding (part 1).

Add an "Explore" button to the "Circuit Display" panel within new user onboarding which opens the DuckDuckGo .onion and then guides users through a short circuit display tutorial.

Allow a few additional UITour actions while limiting as much as possible how it can be used.

Tweak the UITour styles to match the Tor Browser branding.

All user interface strings are retrieved from Torbutton's browserOnboarding.properties file.

BugUX
Onboarding: "Visit an Onion" creates an "about:blank" loading page
Bug 27486
Avoid about:blank tabs when opening onboarding pages.

Instead of using a simple <a href>, programmatically open onboarding web pages by using tabBrowser.addTab(). The same technique is now used for "See My Path", "See FAQs", and "Visit an Onion".

Bug
Introduce new features to users in Tor Browser
Bug 29768
: Introduce new features to users

Add an "update" tour for the Tor Browser 8.5 release that contains two panels: Toolbar and Security (with appropriate description text and images).

Display an attention-grabbing dot on the onboarding text bubble when the update tour is active. The animation lasts for 14 seconds.

BugUX
Introduce Tor network settings and other updates in TB9 onboarding
Bug 31768
: Introduce toolbar and network settings changes in onboarding

Update the "Tor Network" onboarding page to include a note that settings can now be accessed via the application preferences and add an "Adjust Your Tor Network Settings" action button which opens about:preferences#tor.

Replace the Tor Browser 8.5 "update" onboarding tour with a 9.0 one that includes the revised "Tor Network" page and a revised "Toolbar" page. The latter explains that Torbutton's toolbar item has been removed ("Goodbye Onion Button") and explains how to access the New Identity feature using the hamburger menu and new toolbar item.

BugUX
Add What's New Onboarding Item
Bug 34321
- Add Learn More onboarding item

DoingUX
Update Onboarding for 10.5
Bug 40429
: Update Onboarding for 10.5

Author: Kathy Brade, 2018-08-08 11:34:40 -0400
Committer: Pier Angelo Vendrame, 2023-04-04 16:14:34 +0200
689345d4 n
fixup! Bring back old Firefox onboarding

12.5 stableBugCircuit DisplayDesktopDoingNeeds DesignQ1Sponsor 30 - FINISHEDUXUser Feedback
Some users have difficulty finding the circuit display
Bug 41600
- We remove the additions for "controlCenter", i.e. the site identity panel, since the tor circuit display no longer lies within it, so our tour no longer uses it.

Author: Henry Wilkes, 2023-03-10 10:59:28 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 15:33:55 +0200
bb584c63 n
Bring back old Firefox onboarding

Revert "RESOLVED FIXED(Fx64), Blocks: 1457565, 1449052, 1453969, 1477630, 1494282, 1496721
Delete onboarding system add-on
Bug 1462415
- Delete onboarding system add-on r=Standard8,k88hudson"

This reverts commit f7ffd78b62541d44d0102f8051d2f4080bdbc432.

Revert "RESOLVED FIXED(Fx64), Blocks: 1462415
Actually remove the old onboarding add-on's prefs
Bug 1498378
- Actually remove the old onboarding add-on's prefs r=Gijs"

This reverts commit 057fe36fc6f3e93e265505c7dcc703a0941778e2.

BugBugSmashFund
re-implement desktop onboarding for ESR 68
Bug 28822
: Convert onboarding to webextension

Partially revert 1564367 (controlCenter in UITour.jsm)

Author: Alex Catarineu, 2019-05-29 20:04:37 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 15:32:03 +0200
e73a37bc n
fixup! Bountycomponent::applications/tor bundles/installationowner::erinnpriority::highresolution::invalidseverity::blockerstatus::closedtbb-brandingtbb-no-uplifttype::defect
Branding of TBB
Bug 2176
: Rebrand Firefox to TorBrowser

All Platforms
Remove startup.homepage_override_url from Base Browser
Bug 41689
: Move the generic updated URL to the right place

Author: Pier Angelo Vendrame, 2023-03-22 15:42:49 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 15:32:02 +0200
5c899d82 n
Bountycomponent::applications/tor bundles/installationowner::erinnpriority::highresolution::invalidseverity::blockerstatus::closedtbb-brandingtbb-no-uplifttype::defect
Branding of TBB
Bug 2176
: Rebrand Firefox to TorBrowser

See also Bugs #5194, #7187, #8115, #8219.

This patch does some basic renaming of Firefox to TorBrowser. The rest of the branding is done by images and icons.

Also fix BugUX
many occurrences of "Firefox" in about:preferences
bug 27905
.

BugUX
Activity 1.1 Update Tor Browser icon to follow design guidelines.
Bug 25702
: Update Tor Browser icon to follow design guidelines

  • Updated all of the branding in /browser/branding/official with new 'stable' icon series.
  • Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and add the source svg in the same directory
  • Copied /browser/branding/official over /browser/branding/nightly and the new /browser/branding/alpha directories. Replaced content with 'nightly' and 'alpha' icon series. Updated VisualElements_70.png and VisualElements_150.png with updated icons in each branding directory (fixes #22654)
  • Updated firefox.VisualElementsManfiest.xml with updated colors in each branding directory
  • Added firefox.svg to each branding directory from which all the other icons are derived (apart from document.icns and document.ico)
  • Added default256.png and default512.png icons
  • Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed original icon
  • Use the Tor Browser icon within devtools/client/themes/images/.

BugUX
Blurry Tor Browser icon on macOS app switcher
Bug 30631
: Blurry Tor Browser icon on macOS app switcher

It would seem the png2icns tool does not generate correct icns files and so on macOS the larger icons were missing resulting in blurry icons in the OS chrome. Regenerated the padded icons in a macOS VM using iconutil.

Bug
about:preferences#general is not properly translated anymore starting with Tor Browser 8.5a4
Bug 28196
: preparations for using torbutton tor-browser-brand.ftl

A small change to Fluent FileSource class is required so that we can register a new source without its supported locales being counted as available locales for the browser.

BugUX
branding for about:debugging needs logo SVG
Bug 31803
: Replaced about:debugging logo with flat version

Bug
Distinguish between Tor Browser and Firefox when macOS opens documents
Bug 21724
: Make Firefox and Tor Browser distinct macOS apps

When macOS opens a document or selects a default browser, it sometimes uses the CFBundleSignature. Changing from the Firefox MOZB signature to a different signature TORB allows macOS to distinguish between Firefox and Tor Browser.

BugUX
Tor Browser Support should link to our support portal
Bug 32092
: Fix Tor Browser Support link in preferences

For Needs Review
Reorganize patchset
bug 40562
, we moved onionPattern* from BugNeeds ReviewPerformanceSponsor 30 - FINISHEDUX
Remove gap between Tor Launcher window and main browser window
bug 27476
to here, as about:tor needs these files but it is included earlier.

Needs DesignNeeds ReviewProject 131Q1TaskUXWindows
Create PDF icons for both browsers
Bug 41278
: Create Tor Browser styled pdf logo similar to the vanilla Firefox one

Author: Mike Perry, 2013-09-10 16:21:47 -0700
Committer: Pier Angelo Vendrame, 2023-04-04 15:32:02 +0200
19b20c6a n
MikePerry201405Rcomponent::applications/tor bundles/installationowner::mcsparent::4234priority::mediumresolution::fixedstatus::closedtype::defect
change TBB directory structure to be more like Firefox's
Bug 11641
: Disable remoting by default.

Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior.

Author: Kathy Brade, 2014-04-29 13:08:24 -0400
Committer: Pier Angelo Vendrame, 2023-04-04 15:32:01 +0200
d3becbdf n
All PlatformsBrowserDoingFeatureProject 131Q1SecurityUX
Prevent NoScript from being removed / disabled until core functionality has been migrated to Tor Browser
Bug 41598
: Prevent NoScript from being removed/disabled. Backlog
extensions.allowPrivateBrowsingByDefault will be removed
Bug 40253
: Explicitly allow NoScript in Private Browsing mode.
Author: Matthew Finkel, 2021-09-03 14:58:28 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:42 +0200
a63de36d n
Add helpers for message passing with extensionsBug 40069: Add helpers for message passing with extensions Author: Alex Catarineu, 2020-08-02 19:12:25 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:41 +0200
  • RESOLVED FIXED(Fx139), Blocks: 1958496, [addons-jira][tor 41698]
    Badge descriptions should not use brand-product-name, but hardcode Mozilla
    Bug 1825033
f b1c229b7 n
DesktopProject 131TaskUXUpstream
Reword the recommendation badges in about:addons
Bug 41698
: Reword the recommendation badges in about:addons

Firefox strings use { -brand-product-name }. As a result, it seems that the fork is recommending extensions, whereas AMO curators are doing that. So, we replace the strings with custom ones that clarify that Mozilla is recommending them.

We assign the strings with JS because our translation backend does not support Fluent attributes, yet, but once it does, we should switch to them, instead.

Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033

Author: Pier Angelo Vendrame, 2023-03-29 09:18:11 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:41 +0200
48d6f9be n
Base Browser strings

This commit adds all the strings needed by following Base Browser patches.

Author: Pier Angelo Vendrame, 2023-03-29 09:14:54 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:40 +0200
4b5c0a27 n
Build SystemDesktopDoingSigning
Add base-browser nightly mar signing key
Bug 41682
: Add base-browser nightly mar signing key
Author: Nicolas Vigier, 2023-03-20 11:26:37 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:40 +0200
30ba3988 n
fixup! BugSecurity
Sign our MAR files
Bug 13379
: Allow using NSS to sign and verify MAR signatures

DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Port some updater patches to Base Browser

Avoid using -rpath on macOS.

Author: Pier Angelo Vendrame, 2023-03-10 16:25:54 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:37 +0200
16f42e30 n
fixup! BugSecurity
Sign our MAR files
Bug 13379
: Allow using NSS to sign and verify MAR signatures

DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Port some updater patches to Base Browser

Use a configure-time flag to force using NSS for MARs signatures.

Author: Pier Angelo Vendrame, 2023-03-08 19:08:21 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:36 +0200
eb16c8cc n
BugSecurity
Sign our MAR files
Bug 13379
: Allow using NSS to sign and verify MAR signatures

Allow using NSS on all platforms for checking MAR signatures (instead of using OS-native APIs, the default on Mac OS and Windows). So that the NSS and NSPR libraries the updater depends on can be found at runtime, we add the firefox directory to the shared library search path on macOS. On Linux, rpath is used to solve that problem, but that approach won't work on macOS because the updater executable is copied during the update process to a location that can vary.

Author: Kathy Brade, 2014-12-17 16:37:11 -0500
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:36 +0200
9218fb5e n
fixup! All PlatformsBackportDesktopFeatureProject 131Q1UX
Disable the creation of a default profile
Bug 41542
: Disable the creation of a default profile

All PlatformsTask
Turn --enable-base-browser in --with-base-browser-version
Bug 41647
: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros

Changed TOR_BROWSER_VERSION with BASE_BROWSER_VERSION.

Author: Pier Angelo Vendrame, 2023-03-02 17:47:03 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:35 +0200
7bdb54b9 n
All PlatformsBackportDesktopFeatureProject 131Q1UX
Disable the creation of a default profile
Bug 41542
: Disable the creation of a default profile

Firefox creates a profile as a fallback for old versions. However, we do not need this, so we want to prevent Firefox from creating the related directories.

We comment out the code, but should Mozilla be interested in a compile-time flag, we could rewrite the patch to add one.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1770174.

Author: Pier Angelo Vendrame, 2023-01-20 18:26:28 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:35 +0200
174ebe86 n
fixup! Bug
Firefox is phoning home during start-up in Tor Browser based on ESR 68
Bug 31575
: Disable Firefox Home (Activity Stream)

All PlatformsTask
Turn --enable-base-browser in --with-base-browser-version
Bug 41647
: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros

Changed BASE_BROWSER with BASE_BROWSER_VERSION.

Author: Pier Angelo Vendrame, 2023-03-02 15:55:38 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:35 +0200
4aa1f346 n
Bug
Firefox is phoning home during start-up in Tor Browser based on ESR 68
Bug 31575
: Disable Firefox Home (Activity Stream)

Treat about:blank as the default home page and new tab page.

Avoid loading AboutNewTab in BrowserGlue.jsm in order to avoid several network requests that we do not need.

Disable unused about: pagesBug 41624: Disable about:pocket-* pages and about:firefoxview.

BugDesktopFirst ContributionProject 131UX
about:privatebrowsing Firefox branding
Bug 40144
: Redirect about:privatebrowsing to the user's home

Author: Henry Wilkes, 2023-02-03 16:57:17 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:34 +0200
61e43055 n
All PlatformsBackportFeatureQ1
Customize the creation of MOZ_SOURCE_URL
Bug 41603
: Customize the creation of MOZ_SOURCE_URL

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as $MOZ_SOURCE_REPO&#x2F;rev&#x2F;$MOZ_SOURCE_CHANGESET. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/.

Author: Pier Angelo Vendrame, 2023-02-01 18:23:38 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:34 +0200
03ff0ff0 n
Bug
Remove unused menu items from Tor Browser help menu
Bug 18905
: Hide unwanted items from help menu

BugDesktopFirst ContributionRoadmap::FutureUXUpliftUpstream
Remove "New Private Window" option from Tor Browser or make it a separate session
Bug 25660
: Remove the "New Private Window" option

Author: Arthur Edelstein, 2016-04-26 15:59:36 -0700
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:33 +0200
78fa5fee n
AndroidBackportProject 131Roadmap::Future
Can't upload files with Tor browser on Android
Bug 40283
: Workaround for the file upload bug

(cherry picked from commit c23f2f397327ee46a1a4de57acf206fd83e8e170)

Author: p13dz, 2022-12-22 07:05:42 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:33 +0200
54a43376 n
BugDesktopLocalizationProject 131Roadmap::FutureUXesr-115
Fix position/size of multi-locale language menu selector
Bug 41371
: Temporary hack to fix language selector popup position
Author: Henry Wilkes, 2022-10-20 18:19:28 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:32 +0200
1b7d7bca n
fixup! LocalizationProject 131Q4UX
Consider a different list-order for locales in language menu
Bug 41369
: Improve Firefox language settings for multi-lingual packages

DesktopProject 131TaskUXUpstream
Reword the recommendation badges in about:addons
Bug 41698
: Reword the recommendation badges in about:addons

We need to add a new commit for all base browser strings

Author: Pier Angelo Vendrame, 2023-03-28 16:55:42 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:32 +0200
bff4680a n
LocalizationProject 131Q4UX
Consider a different list-order for locales in language menu
Bug 41369
: Improve Firefox language settings for multi-lingual packages

Change the language selector to be sorted by language code, rather than name, and to display the language code to the user.

LocalizationMacOSProject 131Q4UX
"Japanese" language menu item is localised in multi-locale testbuild (on mac OS)
Bug 41372
: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs.

LocalizationNeeds DesignProject 131Q4UX
Inform users when Tor Browser sets their language automatically
Bug 41378
: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once.

Author: Pier Angelo Vendrame, 2022-10-18 19:02:18 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:31 +0200
ea5fc1ec n
DesktopDoingFeatureFingerprintingProject 131Roadmap::Future
Prevent weird initial window dimensions caused by subpixel computations
Bug 41631
: Prevent weird initial window dimensions caused by subpixel computations
Author: hackademix, 2023-03-23 23:29:21 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:31 +0200
  • RESOLVED WONTFIX, Blocks: 1329996, [tor 23104][tor 23701][tor 29563][fingerprinting][fp-triaged]
    CSS line-height reveals platform
    Bug 1397994
6e861d14 n
BugBugSmashFundFingerprinting
CSS line-height reveals the platform Tor Browser is running on
Bug 23104
: Add a default line height compensation

Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS.

The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height only and only if the frame is outside the chrome.

Author: Igor Oliveira, 2017-12-10 18:16:59 -0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:28 +0200
  • RESOLVED WONTFIX, Blocks: 1433504, [tor 13028][psm-backlog]
    potential proxy bypasses in networking code
    Bug 1433509
e94d25af n
BugProxy Bypass
Prevent potential proxy bypass cases.
Bug 13028
: Prevent potential proxy bypass cases.

It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

Author: Mike Perry, 2014-09-29 14:30:19 -0700
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:27 +0200
  • RESOLVED DUPLICATE, Blocks: 1260929, 1433504, [tor 18800]
    Add pref to prevent localhost DNS lookup in nsProfileLock.cpp
    Bug 1432905
74e04deb n
BugProxy Bypass
Remove localhost DNS lookup in nsProfileLock.cpp
Bug 18800
: Remove localhost DNS lookup in nsProfileLock.cpp

Instead of using the local computer's IP address within symlink-based profile lock signatures, always use 127.0.0.1.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1769028

Author: Kathy Brade, 2016-04-21 10:40:26 -0400
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:26 +0200
68369f24 n
MikePerry201311Rcomponent::firefox patch issuesowner::mcspriority::very highresolution::fixedstatus::closedtbb-3.0-backporttbb-no-uplifttbb-usabilitytype::defect
Relocate RelativeLink functionality to Firefox patch
Bug 9173
: Change the default Firefox profile directory to be relative.

This commit makes Firefox look for the default profile directory in a directory relative to the binary path. The directory can be specified through the --with-relative-data-dir. This is relative to the same directory as the firefox main binary for Linux and Windows.

On macOS, we remove Contents/MacOS from it. Or, in other words, the directory is relative to the application bundle.

This behavior can be overriden at runtime, by placing a file called system-install adjacent to the firefox main binary (also on macOS).

Author: Pier Angelo Vendrame, 2023-01-27 17:33:29 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:49:14 +0200
168c6f83 n
BugBugSmashFund
Disable tracking protection UI in FF67-esr
Bug 26345
: Hide tracking protection UI
Author: Alex Catarineu, 2019-09-10 16:29:31 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:39 +0200
2da3bcd6 n
Needs Review
Avoid using system locale for intl.accept_languages in GeckoView
Bug 40199
: Avoid using system locale for intl.accept_languages in GeckoView
Author: Alex Catarineu, 2020-10-20 17:44:36 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:38 +0200
cac51024 n
AndroidBugNeeds ReviewPlatform ParityUX
accept-language header leaks browser localization
Bug 30605
: Honor privacy.spoof_english in Android

This checks privacy.spoof_english whenever setLocales is called from Fenix side and sets intl.accept_languages accordingly.

Needs Review
Expose privacy.spoof_english pref in GeckoView
Bug 40198
: Expose privacy.spoof_english pref in GeckoView

Author: Alex Catarineu, 2020-10-16 10:45:17 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:38 +0200
0b0bae79 n
FontsLinux
Investigate why STIX Two becomes the default font on Linux
Bug 41043
: Hardcode the UI font on Linux

The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese).

Author: Pier Angelo Vendrame, 2022-07-06 22:06:01 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:37 +0200
a36090e5 n
All PlatformsDoingTask
Add canonical color definitions to base-browser
Bug 41659
: Add canonical color definitions to base-browser
Author: Richard Pospesel, 2023-03-02 14:20:37 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:37 +0200
849c3398 n
fixup! All PlatformsBugProject 131Q2Upstream
about:networking#networkid should be normalized
Bug 41599
: Always return an empty string as network ID

All PlatformsTask
Turn --enable-base-browser in --with-base-browser-version
Bug 41647
: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros

Changed BASE_BROWSER with BASE_BROWSER_VERSION.

Author: Pier Angelo Vendrame, 2023-03-02 15:04:16 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:34 +0200
eff1249f n
All PlatformsBugProject 131Q2Upstream
about:networking#networkid should be normalized
Bug 41599
: Always return an empty string as network ID

Firefox computes an internal network ID used to detect network changes and act consequently (e.g., to improve WebSocket UX). However, there are a few ways to get this internal network ID, so we patch them out, to be sure any new code will not be able to use them and possibly link users.

We also sent a patch to Mozilla to seed the internal network ID, to prevent any accidental leak in the future. Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756

Author: Pier Angelo Vendrame, 2023-02-20 16:34:33 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:33 +0200
3ab3b57e n
BugDesktopProject 131Q1
Tor Browser 11.0.4-11.0.6 phoning home
Bug 40788
: Prevent nsIURLQueryStrippingListService from calling home when it is not enabled.

The URL query stripping service is enabled only in nightly builds, still it is initialized and remote settings are downloaded. This adds a condition that prevents the service from being initialized if disabled.

Upstream Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1812594 We should remove this patch if Mozilla decides that this is a problem also for them, or if they do not but we decide to use the feature.

Author: Pier Angelo Vendrame, 2023-01-26 16:05:38 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:33 +0200
d5a5ab89 n
BackportProject 131Roadmap::FutureUXWindows
UX: hide SSO
Bug 40717
: Hide Windows SSO in settings

(cherry picked from commit 1bacd26df8a8ffe481e11ec6b8323150fdf2011d)

Author: cypherpunks1, 2023-01-10 16:22:43 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:32 +0200
a4b67994 n
All PlatformsBacklogFeature
Disable LaterRun
Bug 41568
: Disable LaterRun
Author: cypherpunks1, 2023-01-11 10:46:04 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:32 +0200
6e1214e0 n
BugProxy Bypass
remove pingsender from Tor Browser
Bug 28369
: Stop shipping pingsender executable
Author: Alex Catarineu, 2019-04-10 17:52:51 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:31 +0200
f870a976 n
All PlatformsFeatureProject 131
Disable the Normandy component at compile time
Bug 41635
: Disable the Normandy component

Do not include Normandy at all whenever MOZ_NORMANDY is False.

Author: Pier Angelo Vendrame, 2023-02-16 16:59:41 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:30 +0200
49bbcf7b n
Revert "fixup! Bug
Review RemoteSettings usages in esr68
Bug 31740
: Remove some unnecessary RemoteSettings instances"

This reverts commit 34ed82f6c02a8dc5ed8390fa664e2f63aeadc303.

Author: Pier Angelo Vendrame, 2023-02-16 10:53:33 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:30 +0200
cde43cca n
fixup! Bug
Review RemoteSettings usages in esr68
Bug 31740
: Remove some unnecessary RemoteSettings instances

All PlatformsFeatureProject 131
Immediately return on remoteSettings.pollChanges
Bug 41704
: Immediately return on remoteSettings.pollChanges

Author: Pier Angelo Vendrame, 2023-03-29 12:56:36 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:30 +0200
c1ec12a3 n
fixup! Bug
Review RemoteSettings usages in esr68
Bug 31740
: Remove some unnecessary RemoteSettings instances

BugDesktopProject 131Q1
Tor Browser 11.0.4-11.0.6 phoning home
Bug 40788
: Tor Browser is phoning home

The hijack-list component is the only remaining one calling home. This is a temporary workaround, to use the remote settings.

We should do something like this commit at a more generic level, for all RemoteSettings users.

(cherry picked from commit 2a2e87c3dbc2a98a9ff6387dd278cb2643323b6d)

Author: Pier Angelo Vendrame, 2023-03-21 10:22:19 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:29 +0200
cbe0efbf n
fixup! Bug
Review RemoteSettings usages in esr68
Bug 31740
: Remove some unnecessary RemoteSettings instances

All PlatformsTask
Turn --enable-base-browser in --with-base-browser-version
Bug 41647
: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros

Changed BASE_BROWSER with BASE_BROWSER_VERSION.

Author: Pier Angelo Vendrame, 2023-03-02 15:56:00 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:29 +0200
a7228221 n
Bug
Review RemoteSettings usages in esr68
Bug 31740
: Remove some unnecessary RemoteSettings instances

More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

Author: Alex Catarineu, 2019-10-16 23:01:12 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:28 +0200
29c25a0f n
Consider disabling about:pioneerBug 40002: Remove about:ion

Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser.

All Platforms
Disable about:sync-logs
Bug 41662
: Disable about:sync-logs

Even though we disable sync by default with identity.fxaccounts.enabled, this about: page is still avilable. We could throw an exception on the constructor of the related component, but it would result only in an error in the console, without a visible "this address does not look right" error page. If we fix the issues with MOZ_SERVICES_SYNC, we can restore the component.

Author: Kathy Brade, 2020-08-14 09:06:33 -0400
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:28 +0200
175494ae n
Remove more Mozilla permissionsBug 41457: Remove Mozilla permissions

Revert add-on install permissions introduced in Mozilla's 1560059Bug 40025: Remove Mozilla add-on install permissions

Author: Alex Catarineu, 2020-07-27 18:12:55 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:27 +0200
4a32ff98 n
Bug
Clean up about:logins (LockWise) to avoid mentioning sync, etc.
Bug 33852
: Clean up about:logins (LockWise) to avoid mentioning sync, etc.

Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

Author: Kathy Brade, 2020-07-14 11:15:07 -0400
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:27 +0200
677d326f n
Task
Clean-up system extensions shipped in Firefox 52
Bug 21431
: Clean-up system extensions shipped in Firefox

Only ship the pdfjs extension.

Author: Kathy Brade, 2017-05-23 17:05:29 -0400
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:26 +0200
e5125766 n
All PlatformsApps::Impact::HighApps::Type::AuditLinkabilityRoadmap::FutureTaskesr-115
Make sure EME is no tracking risk in Tor Browser
Bug 16285
: Exclude ClearKey system for now

In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's RESOLVED FIXED(Fx52), Blocks: 1299627, 1299694, 1528884
Remove MOZ_EME build option and make EME disabled by preferences.
bug 1300654
). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.

Author: Georg Koppen, 2017-05-22 12:44:40 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:26 +0200
  • RESOLVED WONTFIX, [tor 40166]
    Add a check to clear security.enterprise_roots.enabled when it was auto enabled and security.certerrors.mitm.auto_enable_enterprise_roots is false
    Bug 1768899
6f004c7d n
BackportDoing
Disable security.certerrors.mitm.auto_enable_enterprise_roots
Bug 40166
: Disable security.certerrors.mitm.auto_enable_enterprise_roots

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899

Author: Alex Catarineu, 2020-10-09 12:55:35 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:26 +0200
  • RESOLVED FIXED(Fx42), [reporter-external][post-critsmash-triage][adv-main42+][tor 12974]
    Information disclosure vulnerability in Firefox via NTLM based HTTP authentication feature
    Bug 1046421
badd81bd n
BugFingerprintingLinkability
Disable NTLM and Negotiate HTTP Auth
Bug 12974
: Disable NTLM and Negotiate HTTP Auth

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, Apps::Impact::MinimalApps::Type::BugBugIceboxUpstreamWindows
iis windows authentication prompt not showing up
tor-browser#27602

Author: Mike Perry, 2014-08-27 15:19:10 -0700
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:25 +0200
b8c342fc n
AndroidBugProxy Bypass
Don't let Android leak DNS queries
Bug 28125
: Prevent non-Necko network connections
Author: Matthew Finkel, 2018-10-25 19:17:09 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:25 +0200
190712b4 n
AndroidTask
Review all requested and required Android permissions
Bug 24796
: Comment out excess permissions from GeckoView

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.

Author: Matthew Finkel, 2018-04-11 17:52:59 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:24 +0200
c8546adc n
fixup! DoingProject 131Q4SecurityWindows
Review Mozilla 1762576: Firefox is not allowing Symantec DLP to inject DLL into the browser for Data Loss Prevention software
Bug 41149
: Re-enable DLL injection protection in all builds not just nightlies

All PlatformsTask
Turn --enable-base-browser in --with-base-browser-version
Bug 41647
: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros

Changed BASE_BROWSER with BASE_BROWSER_VERSION.

Author: Pier Angelo Vendrame, 2023-03-02 15:00:53 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:24 +0200
33eb7e22 n
DoingProject 131Q4SecurityWindows
Review Mozilla 1762576: Firefox is not allowing Symantec DLP to inject DLL into the browser for Data Loss Prevention software
Bug 41149
: Re-enable DLL injection protection in all builds not just nightlies
Author: Dan Ballard, 2022-10-21 11:39:58 -0700
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:24 +0200
377f8086 n
fixup! MacOSesr-102
Remove privileged macOS installation from 102
Bug 41108
: Remove privileged macOS installation from 102

All PlatformsTask
Turn --enable-base-browser in --with-base-browser-version
Bug 41647
: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros

Changed BASE_BROWSER with BASE_BROWSER_VERSION.

Author: Pier Angelo Vendrame, 2023-03-02 15:05:30 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:23 +0200
6fa3f206 n
MacOSesr-102
Remove privileged macOS installation from 102
Bug 41108
: Remove privileged macOS installation from 102
Author: Pier Angelo Vendrame, 2022-08-17 13:28:01 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:23 +0200
7b597d4c n
DoingLinkabilityMacOSProject 131Proxy BypassQ4UX
Review Mozilla 1512851: Add Share Menu to File Menu on macOS
Bug 41117
: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restore email link on mac
Author: Dan Ballard, 2022-10-12 12:54:59 -0700
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:10 +0200
aa4348d0 n
Tweaks to the build system

DoingQ2
Rebase geckoview patches to 99.0
Bug 40857
: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Prevent mach package-multi-locale from actually creating a packageBug 41458: Prevent mach package-multi-locale from actually creating a package

macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it.

Author: Pier Angelo Vendrame, 2022-04-06 22:34:02 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:09 +0200
b15e20cc n
fixup! Base Browser's .mozconfigs.

AndroidBuild System
Android improvements for local dev builds
Bug 41684
: Fix Android mozconfigs for local dev builds

Author: Pier Angelo Vendrame, 2023-03-21 11:04:07 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:09 +0200
69918201 n
fixup! Base Browser's .mozconfigs.

Android
Remove the --disable-tor-browser-update flag on Android
Bug 41677
: Fix updater settings for Android

Author: Pier Angelo Vendrame, 2023-03-13 08:32:39 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:08 +0200
b113a46d n
fixup! Base Browser's .mozconfigs.

DesktopFeatureProject 131
Move part of the updater patches to base browser
Bug 41668
: Port some updater patches to Base Browser

Author: Pier Angelo Vendrame, 2023-03-08 17:35:25 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:33:08 +0200
62e78d01 n
fixup! Base Browser's .mozconfigs.

All PlatformsTask
Turn --enable-base-browser in --with-base-browser-version
Bug 41647
: Clean up our {TOR,BASE}_BROWSER(_VERSION)? macros

Removed the --enable-base-browser flag and the BASE_BROWSER macro and added --with-base-browser-version to the -dev mozconfig.

Author: Pier Angelo Vendrame, 2023-03-02 15:09:49 +0100
Committer: Pier Angelo Vendrame, 2023-04-04 10:32:59 +0200
368f79a0 n
Base Browser's .mozconfigs.

BugSecurity
Creating incremental MAR files for the hardened builds is broken
Bug 17858
: Cannot create incremental MARs for hardened builds. Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff (which is part of mar-tools and is not distributed to end-users) with ASan.

Bug
Create a rebased patch for #18885
Bug 21849
: Don't allow SSL key logging.

AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-central
Bug 25741
- TBA: Disable features at compile-time

Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION

Bug
wrong default pref values in Tor Browser 8.0
Bug 27623
- Export MOZILLA_OFFICIAL during desktop builds

This fixes a problem where some preferences had the wrong default value. Also see AndroidFeature
TBA: Add export MOZILLA_OFFICIAL
bug 27472
where we made a similar fix for Android.

AndroidBug
Playing videos on Twitter is not working and freezing the mobile browser
Bug 29859
: Disable HLS support for now

BugSmashFundTask
Make sure telemetry reporting is disabled in Tor Browser 9
Bug 30463
: Explicitly disable MOZ_TELEMETRY_REPORTING

Task
Consider adding MOZ_SERVICES_HEALTHREPORT to mozconfig
Bug 32493
: Disable MOZ_SERVICES_HEALTHREPORT

Bug
Consider setting MOZ_NORMANDY=False
Bug 33734
: Set MOZ_NORMANDY to False

Bug
Patch out Parental Controls detection and logging
Bug 33851
: Omit Parental Controls.

Add --enable-rust-simd to our tor-browser mozconfig files.Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files

All PlatformsProject 131Task
Move some configuration options to base-browser level
Bug 41584
: Move some configuration options to base-browser level

Author: Pier Angelo Vendrame, 2022-05-23 17:01:24 +0200
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:49 +0200
440e5b75 n
Adding issue and merge request templates Author: Gaba, 2021-06-28 11:44:16 -0700
Committer: Pier Angelo Vendrame, 2023-04-04 10:31:48 +0200
6e89b068 n
Revert "RESOLVED FIXED(Fx93), fission-soft-blocker
a tab with an alert open and lots of pending microtasks may slow down other tabs using the same process
Bug 1724777
, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM"

This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f.

This fixes tor-browser#40721, tor-browser#40698, and Bug
Fix issue in https-e wasm
tor-browser#40706
. However, it is a temporary workaround, that we should revert once https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed.

Author: Georg Koppen, 2021-12-07 16:19:15 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:12:34 +0200
c 8d444ef4 n
RESOLVED FIXED(Fx112), Blocks: 1567627, [necko-triaged]
Consider adding a seed to the network ID
Bug 1817756
- Add a seed to the network ID. r=valentin,necko-reviewers

This helps to prevent linkability of users in the same network.

Differential Revision: https://phabricator.services.mozilla.com/D170373

Author: Pier Angelo Vendrame, 2023-02-21 14:10:39 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:12:33 +0200
c 30970659 n
RESOLVED FIXED(Fx112)
Use the app displayname in about:buildconfig
Bug 1814416
: Generalize the app name in about:buildconfig. r=ahochheiden

Now it displays app display name, instead of having Firefox hardcoded.

Differential Revision: https://phabricator.services.mozilla.com/D168562

Author: Pier Angelo Vendrame, 2023-02-15 09:25:05 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:12:33 +0200
c f441f43c n
RESOLVED FIXED(Fx111), [adv-main111+r]
Crash in [@ memcpy | mozilla::ProfileBufferEntryWriter::WriteBytes]
Bug 1803109
- Discard blocks of data that are too big for two chunks. r=canaltinova

Currently, ReserveAndPutRaw allocates a second span even if the data would be too big for the chunk. Here a second conditional is added to check if the block of data is too big in this scenario and silently discard the data if so.

Differential Revision: https://phabricator.services.mozilla.com/D167167

Author: Kash Shampur, 2023-01-27 17:25:37 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:12:33 +0200
c ff524e0f n
RESOLVED FIXED(Fx111), [addons-jira][adv-main111+]
After redirect to moz-extension:-URL in the parent process, the URL changes to the underlying jar/file-URL
Bug 1802385
- Use NS_GetFinalChannelURI in FetchDriver r=rpl,valentin

Depends on D164656

Differential Revision: https://phabricator.services.mozilla.com/D166108

Author: Rob Wu, 2023-01-16 16:58:06 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:12:32 +0200
c cd4fb43b n
RESOLVED FIXED(Fx106), Blocks: 1689981
Remove OSSpinLocks for good
Bug 1784018
- Remove deprecated OSSpinLocks r=glandium

On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space which degrades performance significantly. To obviate for this we spin in user-space like OSSpinLock does, for the same number of times and invoking x86-specific pause instructions in-between the locking attempts to avoid starving a thread that might be running on the same physical core.

Differential Revision: https://phabricator.services.mozilla.com/D154205

Author: Gabriele Svelto, 2022-08-24 09:18:57 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:10:48 +0200
c a4f37bbf n
RESOLVED FIXED(Fx104)
29.08 - 2.05% cross_origin_pageload / twinopen ext+twinopen:twinopen.html + 26 more (OSX) regression on Tue June 7 2022
Bug 1774458
- Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone

Differential Revision: https://phabricator.services.mozilla.com/D149599

Author: Gabriele Svelto, 2022-07-04 14:00:11 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:10:47 +0200
c 39e4cc51 n
RESOLVED FIXED(Fx103), Blocks: 1760382, 1784018, [mac:hang]
Replace deprecated OSSpinLock with os_unfair_lock
Bug 1670885
- Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium

Depends on D148287

Differential Revision: https://phabricator.services.mozilla.com/D99280

Author: Gabriele Svelto, 2022-06-07 07:37:20 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:10:47 +0200
dee0f57f n
RESOLVED FIXED(Fx103), Blocks: 1760382, 1784018, [mac:hang]
Replace deprecated OSSpinLock with os_unfair_lock
Bug 1670885
- Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium

macOS unfair locks enforce that a lock can only be released by the thread which locked it.

On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing.

Differential Revision: https://phabricator.services.mozilla.com/D148287

Author: Gabriele Svelto, 2022-06-07 07:37:20 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:10:47 +0200
c 29c9a87e n
RESOLVED FIXED(Fx107), Blocks: 1123480, [tor 21830]
nsTransferable disk-leaks when private browsing mode is enabled by default
Bug 1768907
- Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman

nsTransferable was modified to prevent disk leakings when copying data in private browsing mode with RESOLVED FIXED(Fx38)
Prevent disk caching data leak with nsTransferable selections in private browsing mode
Bug 1123480
. However, the context is nullptr when it is initialized, so it still leaks if PBM is enabled by default. Our solution is to check the browser.privatebrowsing.autostart in this condition.

Differential Revision: https://phabricator.services.mozilla.com/D157800

Author: Neill Miller, 2022-09-22 00:26:17 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:10:46 +0200
f05871e4 n
RESOLVED FIXED(Fx107), Blocks: 1123480, [tor 21830]
nsTransferable disk-leaks when private browsing mode is enabled by default
Bug 1768907
- Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D157843

Author: Pier Angelo Vendrame, 2022-09-22 00:26:17 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:10:46 +0200
c ff315642 n
RESOLVED FIXED(Fx105), Blocks: 1658818, 1667131, [adv-main105+r]
stack-buffer-overflow in [@ mozilla::widget::GfxInfo::EnsureInitialized] on startup
Bug 1784588
- Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond

Differential Revision: https://phabricator.services.mozilla.com/D154897

Author: Jamie Nicol, 2022-08-18 12:57:47 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:10:45 +0200
c ae81fad1 n
RESOLVED FIXED(Fx105), [tor 32418]
Add a configure flag to load policies only from the local policies.json file
Bug 1769030
: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium

Add a configuration flag to make Enterprise Policies mechanism only consult a policies.json file (avoiding the Windows Registry, macOS's file system attributes, and /etc/firefox/policies/policies.json on other OS).

Differential Revision: https://phabricator.services.mozilla.com/D146300

Author: Pier Angelo Vendrame, 2022-08-16 14:42:20 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:10:45 +0200
c be0f6ede n
RESOLVED FIXED(Fx105)
Bundled fonts are not picked up on macOS
Bug 1774413
: Bundled fonts are not picked up on macOS r=jfkthame

Bundled fonts were not picked up because also child processes need to register them. Also, they were assigned User visibility, instead of Base, which was not coherent with other platforms.

Differential Revision: https://phabricator.services.mozilla.com/D150400

Author: Pier Angelo Vendrame, 2022-08-02 10:30:35 +0000
Committer: Pier Angelo Vendrame, 2023-04-04 10:10:45 +0200
Generated at: 2025-04-28 08:32 UTC