102.8.0-12.0-2

Base commit: 3a3a96c9

Branches:
Uplift Bug Tags Commit build Description
B T M
  • NEW, Blocks: 1299996, 1958496, [tor 40171] [geckoview:2023?]
    Make WebRequest and GeckoWebExecutor First-Party aware
    Bug 1676104
u P1 e13dbb5b n
AndroidApps::Priority::HighBugLinkabilityProject 131Roadmap::Future
Make WebRequest and GeckoWebExecutor First-Party aware
Bug 40171
: Make WebRequest and GeckoWebExecutor First-Party aware
Author: Alex Catarineu, 2020-11-04 15:58:22 +0100
Committer: Richard Pospesel, 2023-02-09 14:09:18 +0000
  • ASSIGNED(Gijs), [tor 41454]
    No focus is set after opening preferences and scrolling with openPreferences
    Bug 1799153
u P3 6db4b54e n
AccessibilityApps::Impact::MediumApps::Priority::LowApps::Type::BugBugDesktopRoadmap::FutureUXUpstream
No focus is set after opening preferences and scrolling with openPreferences
Bug 41454
: Move focus after calling openPreferences for a sub-category.

Temporary fix until mozilla ASSIGNED(Gijs), [tor 41454]
No focus is set after opening preferences and scrolling with openPreferences
bug 1799153
gets a patch upstream.

Author: Henry Wilkes, 2022-11-15 11:48:04 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:40 +0000
u 876c8a35 n
All PlatformsBugDisk LeakProject 131Q1Roadmap::FutureUplift
Gate Telemetry Tasks behind AppConstants.MOZ_TELEMETRY_REPORTING
Bug 41565
: Gate Telemetry Tasks behind MOZ_TELEMETRY_REPORTING

(cherry picked from commit 47eb7d305746bd1a9e328b1fb7fef40d56769d5b)

Author: cypherpunks1, 2023-01-11 08:37:43 +0000
Committer: Richard Pospesel, 2023-02-09 16:16:34 +0000
  • NEW, Blocks: 1958496, 1407366, [tor 32220]
    Change the letterboxing background to match the theme, and reposition the content
    Bug 1594455
u c8a4fe01 n
BugUX
Change letterboxing color when dark theme is enabled
Bug 32220
: Improve the letterboxing experience

CSS and JS changes to alter the UX surrounding letterboxing. The browser element containing page content is now anchored to the bottom of the toolbar, and the remaining letterbox margin is the same color as the firefox chrome. The letterbox margin and outline are tied to the currently selected theme.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1594455

Author: Richard Pospesel, 2019-10-28 17:42:17 -0700
Committer: Richard Pospesel, 2023-02-09 14:09:23 +0000
  • RESOLVED FIXED(Fx136), [tor 31064][tor 32411]
    Do not apply letterboxing to moz-extension:// pages
    Bug 1555815
f c836fca2 n
BacklogProject 131TaskUXUplift
Consider adding about:tor and others to the list of pages that do not need letterboxing
Bug 32411
: Letterboxing, exempt view-source: URIs.
Author: hackademix, 2022-11-11 22:24:35 +0100
Committer: Richard Pospesel, 2023-02-09 14:09:23 +0000
  • RESOLVED FIXED(Fx136), [tor 31064][tor 32411]
    Do not apply letterboxing to moz-extension:// pages
    Bug 1555815
f 576947f1 n
BacklogFingerprintingProject 131TaskUXUplift
Letterboxing is enabled in priviledged contexts too
Bug 31064
: Letterboxing, exempt browser extensions.
Author: hackademix, 2022-11-10 23:02:47 +0100
Committer: Richard Pospesel, 2023-02-09 14:09:22 +0000
u d1de70f7 n
BacklogFingerprintingProject 131TaskUXUplift
Letterboxing bypass through secondary tab (popup/popunder...)
Bug 41434
: Letterboxing, improve logging.
Author: hackademix, 2022-11-10 22:59:17 +0100
Committer: Richard Pospesel, 2023-02-09 14:09:22 +0000
67d701c3 n
BacklogFingerprintingProject 131TaskUXUplift
Letterboxing bypass through secondary tab (popup/popunder...)
Bug 41434
: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.
Author: hackademix, 2022-11-10 22:25:51 +0100
Committer: Richard Pospesel, 2023-02-09 14:09:22 +0000
  • NEW, [tor 40432]
    Scheme flooding technique for reliable cross-browser fingerprinting
    Bug 1711084
u 2e6db28b n
BackportFingerprinting
protocol flooding attack (scheme flood)
Bug 40432
: Prevent probing installed applications

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084

Author: Matthew Finkel, 2021-05-17 18:09:09 +0000
Committer: Richard Pospesel, 2023-02-09 14:09:21 +0000
u 644e8179 n
FingerprintingNextUplift
Avoid using regional OS locales
Bug 40309
: Avoid using regional OS locales

Avoid regional OS locales if the pref intl.regional_prefs.use_os_locales is false but RFP is enabled.

Author: Pier Angelo Vendrame, 2022-05-18 19:22:37 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:21 +0000
  • NEW, Blocks: 1674565, [tor 27604]
    After restoring profile to a different location, paths in extensions.json are incorrect
    Bug 1429838
u 81e436a2 n
Bug
Relocating the Tor Browser directory is broken with Tor Browser 8
Bug 27604
: Fix addon issues when moving the profile directory

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838

Author: Alex Catarineu, 2019-10-30 10:44:48 +0100
Committer: Richard Pospesel, 2023-02-09 14:09:19 +0000
  • UNCONFIRMED, Blocks: 1958496, [fingerprinting] [gfx-noted] [fp-triaged] [tor 30541]
    Apply Resist Fingerprinting Protection to WebGL's readPixels method
    Bug 1428034
u d98f0954 n
BugFingerprinting
webgl readPixels FP entropy
Bug 30541
: Disable WebGL readPixel() for web content

Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034

Author: Georg Koppen, 2019-05-29 12:29:19 +0000
Committer: Richard Pospesel, 2023-02-09 14:09:16 +0000
u 17645ecf n
BugLinkability
First request after copying and pasting an URL in URL bar seems to go over the catch-all circuit
Bug 26353
: Prevent speculative connect that violated FPI.

Connections were observed in the catch-all circuit when the user entered an https or http URL in the URL bar, or typed a search term.

Author: Arthur Edelstein, 2018-07-14 08:50:55 -0700
Committer: Richard Pospesel, 2023-02-09 14:09:15 +0000
u 150b5171 n
13.5 stableAll PlatformsFeatureFingerprintingFontsProject 131UpliftUpstream
Review Mozilla 1226042: add support for the new 'system-ui' generic font family
Bug 41116
: Normalize system fonts.

System fonts are an enormous fingerprinting vector. Even with font allow lists and with our custom configuration on Linux, which counter metrics measurements, getComputedStyle leaks several details. This patch counters both these kinds of attacks.

Author: Pier Angelo Vendrame, 2022-09-19 12:57:40 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:10 +0000
605dc848 n
fixup! Firefox preference overrides. Author: hackademix, 2023-03-10 12:10:19 +0100
Committer: hackademix, 2023-03-10 12:43:29 +0100
02bb195d n
fixup! Firefox preference overrides.

All PlatformsDoingOnion ServicesProject 131Q1
Enable network.http.referer.hideOnionSource in base-browser
bug 41627
: Enable network.http.referer.hideOnionSource in base-browser

(cherry picked from commit 90df17dac724c43bbc533a0f449a72ba419d9d67)

Author: Richard Pospesel, 2023-02-15 13:37:32 +0000
Committer: Richard Pospesel, 2023-02-15 13:54:39 +0000
93005d94 n
fixup! Firefox preference overrides.

Document why we are locking toolkit.telemetry.enabled.

(cherry picked from commit 933d8c65af7f04677f7bc0ec672088f66ed0a9c9)

Author: Pier Angelo Vendrame, 2023-01-26 09:55:06 +0100
Committer: Richard Pospesel, 2023-02-10 13:16:45 +0000
b20e85a3 n
fixup! Firefox preference overrides.

Disable toolkit.telemetry.enabled on all builds, set webextensions.storage.sync.enabled to false

(cherry picked from commit ad5720b019191e0911e11e7ea26ff32a0de132de)

Author: cypherpunks1, 2023-01-14 05:24:54 +0000
Committer: Richard Pospesel, 2023-02-09 16:14:47 +0000
801263e6 n
fixup! Firefox preference overrides.

BackportNextQ1Windows
Disable and lock Windows SSO
Bug 41578
: Disable and lock Windows SSO

(cherry picked from commit 18dfe4652e9de6b9021802530f899d18a393df12)

Author: cypherpunks1, 2023-01-16 19:08:38 +0000
Committer: Richard Pospesel, 2023-02-09 16:03:28 +0000
8b1665cf n
Firefox preference overrides.

This hack directly includes our preference changes in omni.ja.

Apps::Impact::NoneApps::Type::BugBugDesktopRoadmap::FutureUpdaterWindows
staged updates fail on Windows
Bug 18292
: Staged updates fail on Windows

Temporarily disable staged updates on Windows.

BugFingerprinting
Tor browser uses Chinese-style glyphs to display Japanese
Bug 18297
: Use separate Noto JP,KR,SC,TC fonts

BugFingerprinting
Noto Sans Buginese missing from macOS font whitelist
Bug 23404
: Add Noto Sans Buginese to the macOS whitelist

Bug
Tab crashes when using Tor Browser to access Google Drive
Bug 23745
: Set dom.indexedDB.enabled = true

BugFingerprintingFirst Contribution
Disable randomised Firefox HTTP cache decay user test groups
Bug 13575
: Disable randomised Firefox HTTP cache decay user tests. (Fernando Fernandez Mancera <ffmancera@riseup.net>)

FeatureLinkabilityPerformance
Confirm TLS session resumption/ID are isolated to the URL bar domain, and re-enable them
Bug 17252
: Enable session identifiers with FPI

Session tickets and session identifiers were isolated by OriginAttributes, so we can re-enable them by allowing the default value (true) of "security.ssl.disable_session_identifiers".

The pref "security.enable_tls_session_tickets" is obsolete (removed in https://bugzilla.mozilla.org/917049)

LinkabilityPerformanceTaskUX
Audit HTTP/2 and SPDY if needed
Bug 14952
: Enable http/2 and AltSvc

In Firefox, SPDY/HTTP2 now uses Origin Attributes for isolation of connections, push streams, origin frames, etc. That means we get first-party isolation provided "privacy.firstparty.isolate" is true. So in this patch, we stop overriding "network.http.spdy.enabled" and "network.http.spdy.enabled.http2".

Alternate Services also use Origin Attributes for isolation. So we stop overriding "network.http.altsvc.enabled" and "network.http.altsvc.oe" as well.

(All 4 of the abovementioned "network.http.*" prefs adopt Firefox 60ESR's default value of true.)

However, we want to disable HTTP/2 push for now, so we set "network.http.spdy.allow-push" to false.

"network.http.spdy.enabled.http2draft" was removed in RESOLVED FIXED(Fx41), [spdy]
remove h2-draft support starting in gecko-40
Bug 1132357
. "network.http.sped.enabled.v2" was removed in VERIFIED FIXED(Fx27)
remove spdy/2 support
Bug 912550
. "network.http.sped.enabled.v3" was removed in RESOLVED FIXED(Fx36), spdy
kill spdy/3
Bug 1097944
. "network.http.sped.enabled.v3-1" was removed in RESOLVED FIXED(Fx51), Blocks: 912549, [necko-active]
remove spdy/3.1 support
Bug 1248197
.

FingerprintingTask
Adapt to upstreamed AddonManager changes
Bug 26114
: addons.mozilla.org is not special

  • Don't expose navigator.mozAddonManager on any site
  • Don't block NoScript from modifying addons.mozilla.org or other sites

Enable ReaderView mode again (#27281).

BugProxy Bypass
Group Policies for Firefox can bypass Tor Browser's proxy settings
Bug 29916
: Make sure enterprise policies are disabled

MikePerry201408RMikePerryIterationFires20110529actualpoints::1backport-to-mozillacomponent::firefox patch issuesowner::mikeperrypoints::4priority::mediumresolution::fixedseverity::blockerstatus::closedtbb-no-uplift-60type::enhancement
Block access to Components.interfaces from content script
Bug 2874
: Block Components.interfaces from content

BugBugSmashFundFingerprinting
Setting general.useragent.override does not spoof the platform part anymore in ESR 60 which is confusing
Bug 26146
: Spoof HTTP User-Agent header for desktop platforms

In Tor Browser 8.0, the OS was revealed in both the HTTP User-Agent header and to JavaScript code via navigator.userAgent. To avoid leaking the OS inside each HTTP request (which many web servers log), always use the Windows 7 OS value in the desktop User-Agent header. We continue to allow access to the actual OS via JavaScript, since doing so improves compatibility with web applications such as GitHub and Google Docs.

BugUX
Windows Jump Lists fail for Tor Browser
Bug 12885
: Windows Jump Lists fail for Tor Browser

Jumplist entries are stored in a binary file in: %APPDATA%\Microsoft\Windows\Recent\CustomDestinations
and has a name in the form [a-f0-9]+.customDestinations-ms

The hex at the front is unique per app, and is ultimately derived from something called the 'App User Model ID' (AUMID) via some unknown hashing method. The AUMID is provided as a key when programmatically creating, updating, and deleting a jumplist. The default behaviour in firefox is for the installer to define an AUMID for an app, and save it in the registry so that the jumplist data can be removed by the uninstaller.

However, the Tor Browser does not set this (or any other) regkey during installation, so this codepath fails and the app's AUMID is left undefined. As a result the app's AUMID ends up being defined by windows, but unknowable by Tor Browser. This unknown AUMID is used to create and modify the jumplist, but the delete API requires that we provide the app's AUMID explicitly. Since we don't know what the AUMID is (since the expected regkey where it is normally stored does not exist) jumplist deletion will fail and we will leave behind a mostly empty customDestinations-ms file. The name of the file is derived from the binary path, so an enterprising person could reverse engineer how that hex name is calculated, and generate the name for Tor Browser's default Desktop installation path to determine whether a person had used Tor Browser in the past.

The 'taskbar.grouping.useprofile' option that is enabled by this patch works around this AUMID problem by having firefox.exe create it's own AUMID based on the profile path (rather than looking for a regkey). This way, if a user goes in and enables and disables jumplist entries, the backing store is properly deleted.

Unfortunately, all windows users currently have this file lurking in the above mentioned directory and this patch will not remove it since it was created with an unknown AUMID. However, another patch could be written which goes to that directory and deletes any item containing the 'Tor Browser' string. See Apps::Impact::MinimalApps::Type::BugBugDisk LeakRoadmap::FutureWindows
Tor Browser on Windows creates a file in %APPDATA%\Microsoft\Windows\Recent\CustomDestinations containing the Tor Browser install location
bug 28996
.

Bug
Make sure default Firefox themes are enabled on ESR68
Bug 30845
: Make sure default themes and other internal extensions are enabled

Task
Make sure our bundled WebExtensions are running in Private Browsing Mode
Bug 28896
: Enable extensions in private browsing by default

BugBugSmashFund
Set network.proxy.allow_hijacking_localhost to true
Bug 31065
: Explicitly allow proxying localhost

Bug
Properly enable letterboxing (again)
Bug 31598
: Enable letterboxing

Disable Presentation API everywhere

BugSmashFundTask
Investigate wasm for linkability/fingerprintability/disk avoidance issues
Bug 21549
- Use Firefox's WASM default pref. It is disabled at safer security levels.

BugLinkability
https://mitmdetection.services.mozilla.com/ is contacted over catch-all circuit
Bug 32321
: Disable Mozilla's MitM pings

Bug
Tor Browser warning: "Your Firefox is out of date."
Bug 19890
: Disable installation of system addons

By setting the URL to "" we make sure that already installed system addons get deleted as well.

BugFingerprinting
Firefox downgrades VP9 videos to VP8 when measured performance is not enough
Bug 22548
: Firefox downgrades VP9 videos to VP8.

On systems where H.264 is not available or no HWA, VP9 is preferred. But in Tor Browser 7.0 all youtube videos are degraded to VP8.

This behaviour can be turned off by setting media.benchmark.vp9.threshold to 0. All clients will get better experience and lower traffic, beause TBB doesn't use "Use hardware acceleration when available".

AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-central
Bug 25741
- TBA: Add mobile-override of 000-tor-browser prefs

BugBugSmashFundSecurityUX
8-month-old Tor Browser offers to "Reset Tor Browser", removes extensions
Bug 16441
: Suppress "Reset Tor Browser" prompt.

BugDisk LeakUX
Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable
Bug 29120
: Use the in-memory media cache and increase its maximum size.

BugNext
Investigate new Search Engine configuration
Bug 33697
: use old search config based on list.json

Bug
Don't use site's icon as window icon in Windows when in private browsing mode
Bug 33855
: Ensure that site-specific browser mode is disabled.

Feature
Adapt Intermediate Preloading for Tor Browser
Bug 30682
: Disable Intermediate CA Preloading.

Fingerprinting
ensure that Windows default browser agent is omitted
Bug 40061
: Omit the Windows default browser agent from the build

Backport
Consider disabling network.connectivity-service.enabled
Bug 40322
: Consider disabling network.connectivity-service.enabled

Set svg.context-properties.content.allowed-domains as emptyBug 40408: Disallow SVG Context Paint in all web content

Doing
Set privacy.partition.network_state = false until we evaluate dFPI
Bug 40308
: Disable network partitioning until we evaluate dFPI

Backport
Consider disabling network.connectivity-service.enabled
Bug 40322
: Consider disabling network.connectivity-service.enabled

Disable dom.enable_event_timingBug 40383: Disable dom.enable_event_timing

Flip network.http.http3.enabledBug 40423: Disable http/3

Doing
Clean up obsolete preferences in our 000-tor-browser.js
Bug 40177
: Update prefs for Fx91esr

User Feedback
Switch Firefox recommendations off by default
Bug 40700
: Disable addons and features recommendations

Doing
Set network.proxy.allow_bypass to false
Bug 40682
: Disable network.proxy.allow_bypass

DoingFingerprintingLinkability
3rd-party cookies are not disabled anymore in Tor Browser 11
Bug 40736
: Disable third-party cookies in PBM

FeatureFor Network Health TeamNeeds DesignSecurityUX
Disable Plaintext HTTP Clearnet Connections
Bug 19850
: Enabled HTTPS-Only by default

NextQ2UXUser Feedback
Hide screenshots menu since we don't support it
Bug 40912
: Hide the screenshot menu

DoingProject 131Q3UX
moreFromMozilla pane in about:preferences in 12.0a2
Bug 41292
: Disable moreFromMozilla in preferences page

All PlatformsApps::Impact::HighApps::Type::InvestigationFingerprintingProject 131Roadmap::FutureTask
ensure that CSS4 system colors are not a fingerprinting vector
Bug 40057
: Ensure the CSS4 system colors are not a fingerprinting vector

DoingFeatureFingerprintingLinkabilityProject 131Q4esr-102
In Tor Browser context, should network.http.tailing.enabled be set to false?
Bug 24686
: Set network.http.tailing.enabled to true

Project 131Taskesr-102
Consider disabling TLS ciphersuites containing SHA-1
Bug 40183
: Disable TLS ciphersuites using SHA-1

Project 131Q4Taskesr-102
Review 000-tor-browser.js and 001-base-profile.js for 102
Bug 40783
: Review 000-tor-browser.js and 001-base-profile.js for 102

We reviewed all the preferences we set for 102, and remove a few old ones. See the description of that issue to see all the preferences we believed were still valid for 102, and some brief description for the reasons to keep them.

Author: Mike Perry, 2013-09-10 18:20:43 -0700
Committer: Richard Pospesel, 2023-02-09 14:09:17 +0000
129b9f62 n
All PlatformsDoingTask
Add canonical color definitions to base-browser
Bug 41659
: Add canonical color definitions to base-browser !!! 102.9.0esr REBASE NOTE: this commit should appear relatively early in the base-browser branch
Author: Richard Pospesel, 2023-03-02 14:20:37 +0000
Committer: Richard Pospesel, 2023-03-02 17:22:43 +0000
c 730e58e8 n
RESOLVED FIXED(Fx112)
Use the app displayname in about:buildconfig
Bug 1814416
: Generalize the app name in about:buildconfig. r=ahochheiden

Now it displays app display name, instead of having Firefox hardcoded.

Differential Revision: https://phabricator.services.mozilla.com/D168562

Author: Pier Angelo Vendrame, 2023-02-15 09:25:05 +0000
Committer: Pier Angelo Vendrame, 2023-02-17 08:30:09 +0100
95267ce7 n
All PlatformsBackportDesktopFeatureProject 131Q1UX
Disable the creation of a default profile
Bug 41542
: Disable the creation of a default profile

Firefox creates a profile as a fallback for old versions. However, we do not need this, so we want to prevent Firefox from creating the related directories.

We comment out the code, but should Mozilla be interested in a compile-time flag, we could rewrite the patch to add one.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1770174.

Author: Pier Angelo Vendrame, 2023-01-20 18:26:28 +0100
Committer: Pier Angelo Vendrame, 2023-02-16 08:34:57 +0100
002dd17a n
All PlatformsBackportFeatureQ1
Customize the creation of MOZ_SOURCE_URL
Bug 41603
: Customize the creation of MOZ_SOURCE_URL

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET. But the code takes for granted that it refers to a Hg instance, so it combines them as $MOZ_SOURCE_REPO&#x2F;rev&#x2F;$MOZ_SOURCE_CHANGESET. With this commit, we change this logic to combine them to create a URL that is valid for GitLab. $MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag. If that is needed, we could use /-/tree/, instead of /-/commit/.

Author: Pier Angelo Vendrame, 2023-02-01 18:23:38 +0100
Committer: Richard Pospesel, 2023-02-15 18:22:05 +0000
3c99d6af n
fixup! Backlog
extensions.allowPrivateBrowsingByDefault will be removed
Bug 40253
: Explicitly allow NoScript in Private Browsing mode.

All PlatformsBrowserDoingFeatureProject 131Q1SecurityUX
Prevent NoScript from being removed / disabled until core functionality has been migrated to Tor Browser
Bug 41598
: Prevent NoScript from being removed/disabled. Backlog
extensions.allowPrivateBrowsingByDefault will be removed
Bug 40253
: Explicitly allow NoScript in Private Browsing mode.

Author: hackademix, 2023-01-31 12:25:16 +0100
Committer: Richard Pospesel, 2023-02-15 18:06:33 +0000
8b5ef8db n
Backlog
extensions.allowPrivateBrowsingByDefault will be removed
Bug 40253
: Explicitly allow NoScript in Private Browsing mode.
Author: Matthew Finkel, 2021-09-03 14:58:28 +0000
Committer: Richard Pospesel, 2023-02-09 14:09:24 +0000
d11828b5 n
fixup! Consider disabling about:pioneerBug 40002: Remove about:ion

Remove this._monitorIonPref() and this._monitorIonStudies() from BrowserGlue

(cherry picked from commit fc08631d08d49082680b7133571b893242a21dd5)

Author: cypherpunks1, 2023-01-14 05:24:29 +0000
Committer: Richard Pospesel, 2023-02-09 16:14:31 +0000
ba4a31ec n
Consider disabling about:pioneerBug 40002: Remove about:ion

Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people volunteer to participate in studies that collect detailed, sensitive data about how they use their browser.

Author: Kathy Brade, 2020-08-14 09:06:33 -0400
Committer: Richard Pospesel, 2023-02-09 14:09:15 +0000
82de2705 n
fixup! Bug
Review RemoteSettings usages in esr68
Bug 31740
: Remove some unnecessary RemoteSettings instances

Disable activity stream

(cherry picked from commit 9514e0c69e51e308c7706266d07465e016617b5f)

Author: cypherpunks1, 2023-01-14 05:23:56 +0000
Committer: Richard Pospesel, 2023-02-09 16:14:17 +0000
f19824d5 n
Bug
Review RemoteSettings usages in esr68
Bug 31740
: Remove some unnecessary RemoteSettings instances

More concretely, SearchService.jsm 'hijack-blocklists' and url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for 'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For the ones in the 'main' bucket, this prevents them from being synced unnecessarily (the code in remote-settings does so for collections in the main bucket for which a dump or local data exists). For the collections in the other buckets, we just save some size by not shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

Author: Alex Catarineu, 2019-10-16 23:01:12 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:15 +0000
6532f0b2 n
BackportProject 131Roadmap::FutureUXWindows
UX: hide SSO
Bug 40717
: Hide Windows SSO in settings

(cherry picked from commit 1bacd26df8a8ffe481e11ec6b8323150fdf2011d)

Author: cypherpunks1, 2023-01-10 16:22:43 +0000
Committer: Richard Pospesel, 2023-02-09 16:00:11 +0000
f90d9640 n
Project 131Roadmap::Future
Migrate New Identity feature from torbutton to firefox
Bug 40926
: Implemented the New Identity feature
Author: Pier Angelo Vendrame, 2022-07-25 10:40:35 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:26 +0000
7ca8d9b9 n
All PlatformsApps::Impact::HighApps::Type::MetaNoScriptProject 131Roadmap::Future
Improve NoScript and Browser integration
Bug 40925
: Implemented the Security Level component

This component adds a new Security Level toolbar button which visually indicates the current global security level via icon (as defined by the extensions.torbutton.security_slider pref), a drop-down hanger with a short description of the current security level, and a new section in the about:preferences#privacy page where users can change their current security level. In addition, the hanger and the preferences page will show a visual warning when the user has modified prefs associated with the security level and provide a one-click 'Restore Defaults' button to get the user back on recommended settings.

Geckoview: Expose security level interfaceBug 40125: Expose Security Level pref in GeckoView

Author: Pier Angelo Vendrame, 2022-07-08 16:19:41 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:25 +0000
03cbdc38 n
LocalizationProject 131Q1UX
Prompt users to restart after changing language
Bug 41417
: Always prompt users to restart after changing language

This is a temporary patch that we need until we switch our strings to Fluent. The reason is that we currently set strings when we populate our XUL content. We could rework the whole mechanism, but it is not worth it because we want to switch to Fluent, which will handle everything automatically.

Author: Pier Angelo Vendrame, 2022-11-04 14:10:49 +0100
Committer: Richard Pospesel, 2023-02-09 14:09:25 +0000
d5624033 n
BugDesktopLocalizationProject 131Roadmap::FutureUXesr-115
Fix position/size of multi-locale language menu selector
Bug 41371
: Temporary hack to fix language selector popup position
Author: Henry Wilkes, 2022-10-20 18:19:28 +0100
Committer: Richard Pospesel, 2023-02-09 14:09:25 +0000
afabeab9 n
LocalizationProject 131Q4UX
Consider a different list-order for locales in language menu
Bug 41369
: Improve Firefox language settings for multi-lingual packages

Change the language selector to be sorted by language code, rather than name, and to display the language code to the user.

LocalizationMacOSProject 131Q4UX
"Japanese" language menu item is localised in multi-locale testbuild (on mac OS)
Bug 41372
: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the Japanese language tag could be confusing for users, and moreover the language name is not localized correctly like other langs.

LocalizationNeeds DesignProject 131Q4UX
Inform users when Tor Browser sets their language automatically
Bug 41378
: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system language, but some users might want to change it. So, we tell them that it is possible, but only once.

Author: Pier Angelo Vendrame, 2022-10-18 19:02:18 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:24 +0000
ddd4aff5 n
Add helpers for message passing with extensionsBug 40069: Add helpers for message passing with extensions Author: Alex Catarineu, 2020-08-02 19:12:25 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:24 +0000
  • RESOLVED WONTFIX, Blocks: 1329996, [tor 23104][tor 23701][tor 29563][fingerprinting][fp-triaged]
    CSS line-height reveals platform
    Bug 1397994
76b9ea1d n
BugBugSmashFundFingerprinting
CSS line-height reveals the platform Tor Browser is running on
Bug 23104
: Add a default line height compensation

Many fonts have issues with their vertical metrics. they are used to influence the height of ascenders and depth of descenders. Gecko uses it to calculate the line height (font height + ascender + descender), however because of that idiosyncratic behavior across multiple operating systems, it can be used to identify the user's OS.

The solution proposed in the patch uses a default factor to be multiplied with the font size, simulating the concept of ascender and descender. This way all operating systems will have the same line height only and only if the frame is outside the chrome.

Author: Igor Oliveira, 2017-12-10 18:16:59 -0200
Committer: Richard Pospesel, 2023-02-09 14:09:20 +0000
8b0252eb n
MikePerry201405Rcomponent::applications/tor bundles/installationowner::mcsparent::4234priority::mediumresolution::fixedstatus::closedtype::defect
change TBB directory structure to be more like Firefox's
Bug 11641
: Disable remoting by default.

Unless the -osint command line flag is used, the browser now defaults to the equivalent of -no-remote. There is a new -allow-remote flag that may be used to restore the original (Firefox-like) default behavior.

Author: Kathy Brade, 2014-04-29 13:08:24 -0400
Committer: Richard Pospesel, 2023-02-09 14:09:20 +0000
  • RESOLVED WONTFIX, Blocks: 1433504, [tor 13028][psm-backlog]
    potential proxy bypasses in networking code
    Bug 1433509
125278ea n
BugProxy Bypass
Prevent potential proxy bypass cases.
Bug 13028
: Prevent potential proxy bypass cases.

It looks like these cases should only be invoked in the NSS command line tools, and not the browser, but I decided to patch them anyway because there literally is a maze of network function pointers being passed around, and it's very hard to tell if some random code might not pass in the proper proxied versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

Author: Mike Perry, 2014-09-29 14:30:19 -0700
Committer: Richard Pospesel, 2023-02-09 14:09:20 +0000
  • RESOLVED DUPLICATE, Blocks: 1260929, 1433504, [tor 18800]
    Add pref to prevent localhost DNS lookup in nsProfileLock.cpp
    Bug 1432905
6af56335 n
BugProxy Bypass
Remove localhost DNS lookup in nsProfileLock.cpp
Bug 18800
: Remove localhost DNS lookup in nsProfileLock.cpp

Instead of using the local computer's IP address within symlink-based profile lock signatures, always use 127.0.0.1.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1769028

Author: Kathy Brade, 2016-04-21 10:40:26 -0400
Committer: Richard Pospesel, 2023-02-09 14:09:19 +0000
1eb58fd6 n
MikePerry201311Rcomponent::firefox patch issuesowner::mcspriority::very highresolution::fixedstatus::closedtbb-3.0-backporttbb-no-uplifttbb-usabilitytype::defect
Relocate RelativeLink functionality to Firefox patch
Bug 9173
: Change the default Firefox profile directory to be relative.

This should eliminate our need to rely on a wrapper script that sets /Users/arthur and launches Firefox with -profile.

Author: Kathy Brade, 2013-10-18 15:20:06 -0400
Committer: Richard Pospesel, 2023-02-09 14:09:19 +0000
c4e9ed0e n
BugBugSmashFund
Disable tracking protection UI in FF67-esr
Bug 26345
: Hide tracking protection UI
Author: Alex Catarineu, 2019-09-10 16:29:31 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:18 +0000
4a11f33d n
Needs Review
Avoid using system locale for intl.accept_languages in GeckoView
Bug 40199
: Avoid using system locale for intl.accept_languages in GeckoView
Author: Alex Catarineu, 2020-10-20 17:44:36 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:18 +0000
0795a034 n
AndroidBugNeeds ReviewPlatform ParityUX
accept-language header leaks browser localization
Bug 30605
: Honor privacy.spoof_english in Android

This checks privacy.spoof_english whenever setLocales is called from Fenix side and sets intl.accept_languages accordingly.

Needs Review
Expose privacy.spoof_english pref in GeckoView
Bug 40198
: Expose privacy.spoof_english pref in GeckoView

Author: Alex Catarineu, 2020-10-16 10:45:17 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:17 +0000
0a1eb4eb n
FontsLinux
Investigate why STIX Two becomes the default font on Linux
Bug 41043
: Hardcode the UI font on Linux

The mechanism to choose the UI font does not play well with our fontconfig configuration. As a result, the final criterion to choose the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use it also for the UI. FontConfig will fall back to some other font for scripts Arimo does not cover as expected (we tested with Japanese).

Author: Pier Angelo Vendrame, 2022-07-06 22:06:01 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:17 +0000
ae61963b n
Doing
Consider disabling remote Public Suffix List fetching
Bug 40073
: Disable remote Public Suffix List fetching

In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented fetching the Public Suffix List via RemoteSettings and replacing the default one at runtime, which we do not want.

Author: Alex Catarineu, 2020-08-13 11:05:03 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:16 +0000
c215f756 n
BugProxy Bypass
remove pingsender from Tor Browser
Bug 28369
: Stop shipping pingsender executable
Author: Alex Catarineu, 2019-04-10 17:52:51 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:16 +0000
d87d59a3 n
Remove more Mozilla permissionsBug 41457: Remove Mozilla permissions

Revert add-on install permissions introduced in Mozilla's 1560059Bug 40025: Remove Mozilla add-on install permissions

Author: Alex Catarineu, 2020-07-27 18:12:55 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:15 +0000
18813801 n
Bug
Clean up about:logins (LockWise) to avoid mentioning sync, etc.
Bug 33852
: Clean up about:logins (LockWise) to avoid mentioning sync, etc.

Hide elements on about:logins that mention sync, "Firefox LockWise", and Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

Author: Kathy Brade, 2020-07-14 11:15:07 -0400
Committer: Richard Pospesel, 2023-02-09 14:09:14 +0000
741f6c8b n
Task
Clean-up system extensions shipped in Firefox 52
Bug 21431
: Clean-up system extensions shipped in Firefox

Only ship the pdfjs extension.

Author: Kathy Brade, 2017-05-23 17:05:29 -0400
Committer: Richard Pospesel, 2023-02-09 14:09:14 +0000
ef5e63c9 n
All PlatformsApps::Impact::HighApps::Type::AuditLinkabilityRoadmap::FutureTaskesr-115
Make sure EME is no tracking risk in Tor Browser
Bug 16285
: Exclude ClearKey system for now

In the past the ClearKey system had not been compiled when specifying --disable-eme. But that changed and it is even bundled nowadays (see: Mozilla's RESOLVED FIXED(Fx52), Blocks: 1299627, 1299694, 1528884
Remove MOZ_EME build option and make EME disabled by preferences.
bug 1300654
). We don't want to ship it right now as the use case for it is not really visible while the code had security vulnerabilities in the past.

Author: Georg Koppen, 2017-05-22 12:44:40 +0000
Committer: Richard Pospesel, 2023-02-09 14:09:14 +0000
  • RESOLVED WONTFIX, [tor 40166]
    Add a check to clear security.enterprise_roots.enabled when it was auto enabled and security.certerrors.mitm.auto_enable_enterprise_roots is false
    Bug 1768899
5cfb5257 n
BackportDoing
Disable security.certerrors.mitm.auto_enable_enterprise_roots
Bug 40166
: Disable security.certerrors.mitm.auto_enable_enterprise_roots

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1768899

Author: Alex Catarineu, 2020-10-09 12:55:35 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:13 +0000
  • RESOLVED FIXED(Fx42), [reporter-external][post-critsmash-triage][adv-main42+][tor 12974]
    Information disclosure vulnerability in Firefox via NTLM based HTTP authentication feature
    Bug 1046421
3bf84f4c n
BugFingerprintingLinkability
Disable NTLM and Negotiate HTTP Auth
Bug 12974
: Disable NTLM and Negotiate HTTP Auth

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421, https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, Apps::Impact::MinimalApps::Type::BugBugIceboxUpstreamWindows
iis windows authentication prompt not showing up
tor-browser#27602

Author: Mike Perry, 2014-08-27 15:19:10 -0700
Committer: Richard Pospesel, 2023-02-09 14:09:13 +0000
75543a65 n
AndroidBugProxy Bypass
Don't let Android leak DNS queries
Bug 28125
: Prevent non-Necko network connections
Author: Matthew Finkel, 2018-10-25 19:17:09 +0000
Committer: Richard Pospesel, 2023-02-09 14:09:13 +0000
aa280445 n
AndroidBugBugSmashFund
Create tor-browser for mobile branch based on mozilla-central
Bug 25741
: TBA: Disable GeckoNetworkManager

The browser should not need information related to the network interface or network state, tor should take care of that.

Author: Matthew Finkel, 2018-04-26 22:22:51 +0000
Committer: Richard Pospesel, 2023-02-09 14:09:12 +0000
ada9b1e3 n
AndroidTask
Review all requested and required Android permissions
Bug 24796
: Comment out excess permissions from GeckoView

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's manifest, so we can't use the ifdef preprocessor guards around the permissions we do not want. Commenting the permissions is the next-best-thing.

Author: Matthew Finkel, 2018-04-11 17:52:59 +0000
Committer: Richard Pospesel, 2023-02-09 14:09:12 +0000
7cd0ca00 n
DoingProject 131Q4SecurityWindows
Review Mozilla 1762576: Firefox is not allowing Symantec DLP to inject DLL into the browser for Data Loss Prevention software
Bug 41149
: Re-enable DLL injection protection in all builds not just nightlies
Author: Dan Ballard, 2022-10-21 11:39:58 -0700
Committer: Richard Pospesel, 2023-02-09 14:09:12 +0000
a7f1e3dc n
MacOSesr-102
Remove privileged macOS installation from 102
Bug 41108
: Remove privileged macOS installation from 102
Author: Pier Angelo Vendrame, 2022-08-17 13:28:01 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:11 +0000
9b800046 n
Base Browser's .mozconfigs. Author: Pier Angelo Vendrame, 2022-05-23 17:01:24 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:11 +0000
673e2078 n
Adding issue template for bugs. Author: Gaba, 2021-06-28 11:44:16 -0700
Committer: Richard Pospesel, 2023-02-09 14:09:11 +0000
5643c993 n
DoingLinkabilityMacOSProject 131Proxy BypassQ4UX
Review Mozilla 1512851: Add Share Menu to File Menu on macOS
Bug 41117
: using MOZ_PROXY_BYPASS_PROTECTION disable share menu on mac and windows, and restpre email link on mac
Author: Dan Ballard, 2022-10-12 12:54:59 -0700
Committer: Richard Pospesel, 2023-02-09 14:09:10 +0000
7a872d5e n
Tweaks to the build system

DoingQ2
Rebase geckoview patches to 99.0
Bug 40857
: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment disabled. Mozilla does not use a similar configuration, but either runs a Firefox build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Prevent mach package-multi-locale from actually creating a packageBug 41458: Prevent mach package-multi-locale from actually creating a package

macOS builds need some files to be moved around with ./mach package-multi-locale to create multi-locale packages. The required command isn't exposed through any other mach command. So, we patch package-multi-locale both to prevent it from failing when doing official builds and to detect any future changes on it.

Author: Pier Angelo Vendrame, 2022-04-06 22:34:02 +0200
Committer: Richard Pospesel, 2023-02-09 14:09:10 +0000
c 8747fce6 n
fixup! RESOLVED FIXED(Fx100), Blocks: 1761505, 1761504, [fidedi-pdf]
Make Firefox PDF handler display Windows default PDF handler icon
Bug 1761389
- Add and use new PDF-specific document icon on Windows. r=bhearsum
Author: Richard Pospesel, 2022-09-02 19:10:46 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:17 +0000
95cd88aa n
Revert "RESOLVED FIXED(Fx93), fission-soft-blocker
a tab with an alert open and lots of pending microtasks may slow down other tabs using the same process
Bug 1724777
, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM"

This reverts commit 1eb1364357ac5bc2a4531337fb5416af39c3793f.

This fixes tor-browser#40721, tor-browser#40698, and Bug
Fix issue in https-e wasm
tor-browser#40706
. However, it is a temporary workaround, that we should revert once https://bugzilla.mozilla.org/show_bug.cgi?id=1744719 is fixed.

Author: Georg Koppen, 2021-12-07 16:19:15 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:16 +0000
c 67924adc n
RESOLVED FIXED(Fx106), Blocks: 1689981
Remove OSSpinLocks for good
Bug 1784018
- Remove deprecated OSSpinLocks r=glandium

On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space which degrades performance significantly. To obviate for this we spin in user-space like OSSpinLock does, for the same number of times and invoking x86-specific pause instructions in-between the locking attempts to avoid starving a thread that might be running on the same physical core.

Differential Revision: https://phabricator.services.mozilla.com/D154205

Author: Gabriele Svelto, 2022-08-24 09:18:57 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:16 +0000
c 8d63a5b9 n
RESOLVED FIXED(Fx104)
29.08 - 2.05% cross_origin_pageload / twinopen ext+twinopen:twinopen.html + 26 more (OSX) regression on Tue June 7 2022
Bug 1774458
- Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone

Differential Revision: https://phabricator.services.mozilla.com/D149599

Author: Gabriele Svelto, 2022-07-04 14:00:11 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:16 +0000
c 890d9731 n
RESOLVED FIXED(Fx103), Blocks: 1760382, 1784018, [mac:hang]
Replace deprecated OSSpinLock with os_unfair_lock
Bug 1670885
- Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium

Depends on D148287

Differential Revision: https://phabricator.services.mozilla.com/D99280

Author: Gabriele Svelto, 2022-06-07 07:37:20 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:15 +0000
98f783e2 n
RESOLVED FIXED(Fx103), Blocks: 1760382, 1784018, [mac:hang]
Replace deprecated OSSpinLock with os_unfair_lock
Bug 1670885
- Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium

macOS unfair locks enforce that a lock can only be released by the thread which locked it.

On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing.

Differential Revision: https://phabricator.services.mozilla.com/D148287

Author: Gabriele Svelto, 2022-06-07 07:37:20 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:15 +0000
c 3dc56306 n
RESOLVED FIXED(Fx107), Blocks: 1123480, [tor 21830]
nsTransferable disk-leaks when private browsing mode is enabled by default
Bug 1768907
- Part 2: nsTransferable disk-leaks when private browsing mode is enabled by default. r=handyman

nsTransferable was modified to prevent disk leakings when copying data in private browsing mode with RESOLVED FIXED(Fx38)
Prevent disk caching data leak with nsTransferable selections in private browsing mode
Bug 1123480
. However, the context is nullptr when it is initialized, so it still leaks if PBM is enabled by default. Our solution is to check the browser.privatebrowsing.autostart in this condition.

Differential Revision: https://phabricator.services.mozilla.com/D157800

Author: Neill Miller, 2022-09-22 00:26:17 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:15 +0000
26152089 n
RESOLVED FIXED(Fx107), Blocks: 1123480, [tor 21830]
nsTransferable disk-leaks when private browsing mode is enabled by default
Bug 1768907
- Part 1: Make browser.privatebrowsing.autostart a static pref. r=handyman,necko-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D157843

Author: Pier Angelo Vendrame, 2022-09-22 00:26:17 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:14 +0000
c 35877fe2 n
RESOLVED FIXED(Fx105), Blocks: 1658818, 1667131, [adv-main105+r]
stack-buffer-overflow in [@ mozilla::widget::GfxInfo::EnsureInitialized] on startup
Bug 1784588
- Fix SplitDriverVersion when the string has less than 4 numbers. r=aosmond

Differential Revision: https://phabricator.services.mozilla.com/D154897

Author: Jamie Nicol, 2022-08-18 12:57:47 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:14 +0000
c 2c225a70 n
RESOLVED FIXED(Fx105), [tor 32418]
Add a configure flag to load policies only from the local policies.json file
Bug 1769030
: Add a configure flag to load policies only from the local policies.json file r=mkaply,glandium

Add a configuration flag to make Enterprise Policies mechanism only consult a policies.json file (avoiding the Windows Registry, macOS's file system attributes, and /etc/firefox/policies/policies.json on other OS).

Differential Revision: https://phabricator.services.mozilla.com/D146300

Author: Pier Angelo Vendrame, 2022-08-16 14:42:20 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:14 +0000
c afb87585 n
RESOLVED FIXED(Fx105)
Bundled fonts are not picked up on macOS
Bug 1774413
: Bundled fonts are not picked up on macOS r=jfkthame

Bundled fonts were not picked up because also child processes need to register them. Also, they were assigned User visibility, instead of Base, which was not coherent with other platforms.

Differential Revision: https://phabricator.services.mozilla.com/D150400

Author: Pier Angelo Vendrame, 2022-08-02 10:30:35 +0000
Committer: Richard Pospesel, 2023-02-08 13:50:14 +0000
Generated at: 2025-04-28 08:32 UTC